Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220902230500.2624739-1-tharvey@gateworks.com> <20220908211916.GA3348959-robh@kernel.org>
In-Reply-To: <20220908211916.GA3348959-robh@kernel.org>
From:   Tim Harvey <tharvey@gateworks.com>
Date:   Thu, 8 Sep 2022 14:44:46 -0700
Message-ID: <CAJ+vNU1NEYWvev3s=1rPPNCRovBqa0p=JTXLHLpV7fOWf-dFLg@mail.gmail.com>
Subject: Re: [PATCH 1/2] dt-bindings: arm: Add i.MX8M Mini Gateworks GW7904 board
To:     Rob Herring <robh@kernel.org>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Sep 8, 2022 at 2:19 PM Rob Herring <robh@kernel.org> wrote:
>
> On Fri, Sep 02, 2022 at 04:04:59PM -0700, Tim Harvey wrote:
> > Add DT compatible string for i.MX8M Mini based Gateworks GW7904 board.
> >
> > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> > Cc: Shawn Guo <shawnguo@kernel.org>
> > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> > Cc: Fabio Estevam <festevam@gmail.com>
> > Cc: NXP Linux Team <linux-imx@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index 7431579ab0e8..ce89fac1898e 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -831,6 +831,7 @@ properties:
> >                - gw,imx8mm-gw7901          # i.MX8MM Gateworks Board
> >                - gw,imx8mm-gw7902          # i.MX8MM Gateworks Board
> >                - gw,imx8mm-gw7903          # i.MX8MM Gateworks Board
> > +              - gateworks,imx8mm-gw7904   # i.MX8MM Gateworks Board
>
> A useful comment would be ones that distuiguish these boards. It's
> obvious from the compatible it's a i.MX8MM board from Gateworks.

But isn't it clear that you need to go to the device-tree itself to
understand the details?

As far as basic features go sometimes there is very little difference
in these board models. It would be a struggle to list all the board
details (which I do in the dts commit) in a way that doesn't take up
too much space in fsl.yaml.

Best Regards,

Tim