Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp1214881rwn; Thu, 8 Sep 2022 15:38:15 -0700 (PDT) X-Google-Smtp-Source: AA6agR6eL4Vu4710OJXdhKjBeEayavvVUAgnKk1Bkmp5m705Bqe5VLk3wU3rfDTT5Ssh5Kyy6dRX X-Received: by 2002:a19:5f45:0:b0:492:df3d:d678 with SMTP id a5-20020a195f45000000b00492df3dd678mr3731686lfj.217.1662676695351; Thu, 08 Sep 2022 15:38:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662676695; cv=none; d=google.com; s=arc-20160816; b=jplwQst6obiM3qSSFFlZksuR8t+VR8gC7ELo+mFivORkbx8NSP7eC+OO7Tlru0EC2q 8uAguup6n4LeQe8hv6vBdgAQoHdaZp8wpefursXzGbrGWzi+Zgsg0tkfOBH0+124sEUQ O5ElgT6hk/jhwxM/6tPWXr5pvdvz30nY7je9hOIt4uHM27Sk4Rom6bmz2KArXP3Nty51 +QL9TSxQfkHVEl3MuGzyIQUqtG3gfDf91yGeMpMMkIsAqMGTcU4OMcrLwsWYgz6bfU1m K8FTvgv1uvG4xen1S7TJSEmGlGxEpHH8jplAbYESsXj94lUE7UGWvkEHL49i/ABXXjHy 1M8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=PY33xXugMpJrxaOfLtDoKIpmmKkUXM1FA6wgweiD9z8=; b=h3WXan5ru7pLja2gNNTUbxc4xosvujZBl2PiwRwl105Cptk6bnNebSHZXQ1Vbn5gfr SSpVd/pZfMLO6bghX/wVsPWB0n3oewaDXCBdxNAYYOsEc1Bpf9NlRGbd3mYf63ffl/TC jVmUKCN33iP5n6gdQIf6qkWEEaqv/T/Ldv/Tp4ymhBHpZQ9FLWkgB2fo+yt8tFHjLe2Z 5E+Ul4EQLkGWXeSGh2v9PGNywCqwIc9ZekollPq50TtVmitv2Qu8V+wCxTLcNxhcqSvK GMOsEJi+74EACA/iRTkre0h2MZYvQMP5wFY2Bi0bkfeZafdDCvqwouAUhK/rS4t9+0NB ycDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=rn4kWPRg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f6-20020a0565123b0600b00497a139c3a0si48152lfv.257.2022.09.08.15.37.45; Thu, 08 Sep 2022 15:38:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=rn4kWPRg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229521AbiIHWCx (ORCPT + 99 others); Thu, 8 Sep 2022 18:02:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbiIHWCg (ORCPT ); Thu, 8 Sep 2022 18:02:36 -0400 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 205B3B15; Thu, 8 Sep 2022 15:02:35 -0700 (PDT) Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 288Lhjvq002046; Thu, 8 Sep 2022 22:02:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding; s=pp1; bh=PY33xXugMpJrxaOfLtDoKIpmmKkUXM1FA6wgweiD9z8=; b=rn4kWPRg+UTz8Kl47uLenQ34cqMnrIoCLtr9K9QNF+Y5lohghgSf5Ky3E6DKrtLXO5l6 L2lR38/OvjTfnNyNF5d3miJfp8fjj1TnhOnkoEabFMJUsA+kEeFrFPqg48e8ILMcCIgK TciToMV+1Ukrit45EIXj8hmYiBIn1rIgeykfsN+oA99gpaRUvPxbkm28SWDDrJk5adTl D6xxni0+h52UzcYksmd9Rgx3bZSDSy5behv94taei+DzrKdNh70HXGVOXeAMokXKKnxS IH9e9qgcmpcZaQ6TkHEd37YjGMmneZ6sEUYQdEp9CBNYPb4wZZPUUXoRCmfcqSmIF4oQ MQ== Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3jfrjb8dbm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 08 Sep 2022 22:02:25 +0000 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 288Locc6032133; Thu, 8 Sep 2022 22:02:24 GMT Received: from b01cxnp22036.gho.pok.ibm.com (b01cxnp22036.gho.pok.ibm.com [9.57.198.26]) by ppma03dal.us.ibm.com with ESMTP id 3jbxjakmvy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 08 Sep 2022 22:02:24 +0000 Received: from b01ledav001.gho.pok.ibm.com (b01ledav001.gho.pok.ibm.com [9.57.199.106]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 288M2NIv30343552 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 8 Sep 2022 22:02:23 GMT Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5DAC628059; Thu, 8 Sep 2022 22:02:23 +0000 (GMT) Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 38E5928058; Thu, 8 Sep 2022 22:02:23 +0000 (GMT) Received: from localhost (unknown [9.41.178.242]) by b01ledav001.gho.pok.ibm.com (Postfix) with ESMTP; Thu, 8 Sep 2022 22:02:23 +0000 (GMT) From: Nathan Lynch To: linux-security-module@vger.kernel.org Cc: linux-kernel@vger.kernel.org, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com Subject: [PATCH] lockdown: ratelimit denial messages Date: Thu, 8 Sep 2022 17:02:22 -0500 Message-Id: <20220908220222.267255-1-nathanl@linux.ibm.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: Q3v9Rph-wyIMIc2GsPuy45gHr07uejIA X-Proofpoint-ORIG-GUID: Q3v9Rph-wyIMIc2GsPuy45gHr07uejIA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-08_12,2022-09-08_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1011 lowpriorityscore=0 bulkscore=0 phishscore=0 mlxscore=0 mlxlogscore=811 priorityscore=1501 spamscore=0 adultscore=0 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2209080076 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org User space can flood the log with lockdown denial messages: [ 662.555584] Lockdown: bash: debugfs access is restricted; see man kernel_lockdown.7 [ 662.563237] Lockdown: bash: debugfs access is restricted; see man kernel_lockdown.7 [ 662.571134] Lockdown: bash: debugfs access is restricted; see man kernel_lockdown.7 [ 662.578668] Lockdown: bash: debugfs access is restricted; see man kernel_lockdown.7 [ 662.586021] Lockdown: bash: debugfs access is restricted; see man kernel_lockdown.7 [ 662.593398] Lockdown: bash: debugfs access is restricted; see man kernel_lockdown.7 Ratelimiting these shouldn't meaningfully degrade the quality of the information logged. Signed-off-by: Nathan Lynch --- security/lockdown/lockdown.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/lockdown/lockdown.c b/security/lockdown/lockdown.c index 87cbdc64d272..a79b985e917e 100644 --- a/security/lockdown/lockdown.c +++ b/security/lockdown/lockdown.c @@ -63,7 +63,7 @@ static int lockdown_is_locked_down(enum lockdown_reason what) if (kernel_locked_down >= what) { if (lockdown_reasons[what]) - pr_notice("Lockdown: %s: %s is restricted; see man kernel_lockdown.7\n", + pr_notice_ratelimited("Lockdown: %s: %s is restricted; see man kernel_lockdown.7\n", current->comm, lockdown_reasons[what]); return -EPERM; } -- 2.37.1