Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp1216847rwn; Thu, 8 Sep 2022 15:40:47 -0700 (PDT) X-Google-Smtp-Source: AA6agR5vEN08brJ7TGZ4tuwNAj9KhhnmRMxBdK49vmnslbAyynxgnpuxXmkVT5HZkfB017iuUaL6 X-Received: by 2002:ac2:51b8:0:b0:497:ac71:736a with SMTP id f24-20020ac251b8000000b00497ac71736amr2670093lfk.510.1662676847342; Thu, 08 Sep 2022 15:40:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662676847; cv=none; d=google.com; s=arc-20160816; b=oCh1dcfG3Es5Qer3sg1upQpjp31In1zcQYx6fsD7i2bESWlfNFisPCDCGmb9IpBi7W +OgOKibv2j5UuMyn9IQ9KlQ3plq2Ea+KFA/fjukFb2+5krEp3jjaFEppsg51wSY/A29K 9OyLneaO0q3Gwt6vblst5KebRk2tX+I7PhH6dUsUrmxgctpoQEJ6FpzFswmmZtIERFja DBICQHU69h5MGiVScx/wmb4ldSJ27jp1wtXnX6STBB7nkdNgQjIQCyrs9yMm6dEEJTDE l9S2HHUNSCC9D9naVY3qllU5+7UewFvqYVdpr8UyeYZP47bqNpHksvJvWxMsdFILhVGe TV5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=owRTZNGDqD8OkXSsM5EZ0PBzmfLvZiHCsKH36J3GWzE=; b=gVVsLIxMlPIU3NXeDwEprxj5ni83BEvWhgq8t179xy1xP7bu3zOrGxUCIll0elrQ66 rN2J9PnX7O+B1g8NH8EluC7gHYj3x8gIkzkw7xKw+7EvU1IBuBkGAJnzEEXwJsfTwWrc st0e748jetx+9PqP5lpSYq+TyhkEmJpng1TBr3iB8owWkeDh9V6rKzxrBfX6jMYStE+P pZ9whKN2ZdWYE8o+66a9q8YxdUibj12bByWIbYkPPTsXj2gc+y6LiwAxCqo/KPSlFdVq L/ksSiYpB1Z9cc8+k0HP+gYnBrBpwMxJw9kQpCu3TBmOb0hlNAOMn4A0flvt60j2pA43 peGg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a41-20020a05651c212900b0026be2944e71si23423ljq.541.2022.09.08.15.40.18; Thu, 08 Sep 2022 15:40:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229945AbiIHWag (ORCPT + 99 others); Thu, 8 Sep 2022 18:30:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229552AbiIHWaf (ORCPT ); Thu, 8 Sep 2022 18:30:35 -0400 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADD9A98368; Thu, 8 Sep 2022 15:30:31 -0700 (PDT) Received: by mail-pl1-f171.google.com with SMTP id v1so78480plo.9; Thu, 08 Sep 2022 15:30:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=owRTZNGDqD8OkXSsM5EZ0PBzmfLvZiHCsKH36J3GWzE=; b=IW5wfUNojOUdLksrhQ8M1jLaDtbvk0JEhw/CbA0gvUsmftc9A/Grf5XNs/HPYMAfS1 uzbfEOerhMV6bc1STzE00vVlmTA69Tp4J4GNmPH7LeAQjAD4dIk3O1I8YLRssPGBJJ4P NeuOakTfVaLpxnuRLct7k6ut/m1PA9eBFXchie5mDWeceBRobPy1Opn4iLGX30+Oyrvf X0h4t4yP1aD2cuaWQJQQKDH416C7349dm6EZ6W/Gsz/7uoCGnJx6aUVTEY1PThkxpMuC mWNvrFi2Z6nZ3cQwfs8b6RfNajkPNzoFbqdZXdVgTFcLLUyFo0lOqRc21SS6i3THrGyW c5VA== X-Gm-Message-State: ACgBeo2zl5lVSRUrWSOQul8+hcbNeAnI9o2nQKM0MKXXWGjF/XTEq+Eq 1wMNfNyguJ+woICFU4tYX3A= X-Received: by 2002:a17:902:850a:b0:176:72af:65c1 with SMTP id bj10-20020a170902850a00b0017672af65c1mr11040922plb.81.1662676230853; Thu, 08 Sep 2022 15:30:30 -0700 (PDT) Received: from ?IPV6:2620:15c:211:201:c18a:7410:112c:aa7c? ([2620:15c:211:201:c18a:7410:112c:aa7c]) by smtp.gmail.com with ESMTPSA id q1-20020a17090a7a8100b001faf7a88138sm60776pjf.42.2022.09.08.15.30.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Sep 2022 15:30:30 -0700 (PDT) Message-ID: <3ea54f9b-896d-c70b-9024-4dc4f99ec2d4@acm.org> Date: Thu, 8 Sep 2022 15:30:27 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [RFC PATCH v3 4/4] ufs: host: qcom: Add MCQ support Content-Language: en-US To: Asutosh Das , quic_nguyenb@quicinc.com, quic_xiaosenh@quicinc.com, stanley.chu@mediatek.com, adrian.hunter@intel.com, avri.altman@wdc.com, mani@kernel.org, quic_cang@quicinc.com, beanhuo@micron.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, Alim Akhtar , "James E.J. Bottomley" , Andy Gross , Bjorn Andersson , Krzysztof Kozlowski , open list References: <260533ec3a80442b73d3999727bf0a9861462eba.1662157846.git.quic_asutoshd@quicinc.com> From: Bart Van Assche In-Reply-To: <260533ec3a80442b73d3999727bf0a9861462eba.1662157846.git.quic_asutoshd@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/2/22 15:41, Asutosh Das wrote: > +static int ufs_qcom_get_hba_mac(struct ufs_hba *hba) > +{ > + return MAX_SUPP_MAC; > +} The above implementation is not sufficient to convince me that the get_hba_mac vop is useful. Please remove this vop and use MAX_SUPP_MAC directly where ufshcd_mcq_vops_get_hba_mac() is called. Thanks, Bart.