Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3b96aeb7-4b41-9838-e0f9-bf0ea7c99404@intel.com>
Date:   Thu, 8 Sep 2022 15:43:51 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.2.1
Subject: Re: [PATCH v2 4/5] selftests/sgx: Include the dynamic heap size to
 the ELRANGE calculation
Content-Language: en-US
To:     Jarkko Sakkinen <jarkko@kernel.org>, <linux-sgx@vger.kernel.org>
CC:     Haitao Huang <haitao.huang@linux.intel.com>,
        Vijay Dhanraj <vijay.dhanraj@intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "Shuah Khan" <shuah@kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20220905020411.17290-1-jarkko@kernel.org>
 <20220905020411.17290-5-jarkko@kernel.org>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20220905020411.17290-5-jarkko@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmM5cWpnNXVuZGU5QUJNY04rSVJqMUNnZzFBckljcFlDNTIzWlNON0F6V2x1?=
 =?utf-8?B?a2ZVcVpudUUrMzk1QXZkRVpOT0d5UmsxYjBUc3lKUTlMSUxLTnFKNEFldGtt?=
 =?utf-8?B?K0RXR0ttaklvKzM2T0svTEtmWXg2UjVTK0VEakRIYnBKQUN1dUJVekE5b2FT?=
 =?utf-8?B?MFkwejdxZlVrc2Y2RDQ2aTV3bEg5bklWMVFibXVGbEhBK0JxWGp0Y0hMMnZj?=
 =?utf-8?B?K1YrZjF2czNRM3F1Y3M1NVBKS3VRN0NHOUZsV1dxYWd4dWlnNW5mMktUZDhQ?=
 =?utf-8?B?ekx6bDdGN3U5cWNCa1puc1N1UmZWRHFPL2VwU0ZGL3Fya2o0L3NScm9vMVc5?=
 =?utf-8?B?QXVvTDY0REFjMmVFQmNDaXorNVdJZXVydnVnN0lJeUJmK2x5WmU4enhWLyts?=
 =?utf-8?B?MFl0ZExIZHdCR3IzZ0l2RmRSVTR6b0FPQ0tJemVxRFZGRkZjVG9ZYWhTZWNi?=
 =?utf-8?B?aG1GcG5qak9vNTNlRmZrVitGQ0dMUGtsenhuNi9wUVVleDI4TVphZmlpVTBn?=
 =?utf-8?B?cnZmUlJZblN1K0tMa2NKN2wzWnhIOVBERFhtNGpkVVlUZWFKSFNOTnMvY1hG?=
 =?utf-8?B?Y3lRYjJycXNZUkVrcVhQZ0kvcjFxU280Ni9vMWxwNFdOTnRPbVp0NFcrTGVP?=
 =?utf-8?B?dHVoZjVpZFdVc0lPcXFYYUhRalR3V3E0RlJYbVJ6RW1mYnZKQnBSMkZhVU1i?=
 =?utf-8?B?ZDZyQ1Z1U3g1aWFqZXNweVkzemVHOTh3N3ErM3FrQkFvYnpidFZZU2ZDQldz?=
 =?utf-8?B?NGxSK2dxZE1nb2h3SVE4bUl2VnUydDhRbklsZ1FVYnZoWnJYL2xNZDJrNE9I?=
 =?utf-8?B?QnQ4Nk9NaGt3NGJiYzc4SEEvT2REaUJXV3ZTRHlpSGo4ckhla29ZQjJxSThL?=
 =?utf-8?B?OGlnbWVSUE5WTlNwdjhqSU12Zlp2R1o4L0FvVFZFdmM4Z1dPVTg1RDFlNGgy?=
 =?utf-8?B?bHlhbnpPS09pSjJmdnBEZjJoblJyNGUyVUNxZVlaelg4c2hTSkZ5SmlPUUN6?=
 =?utf-8?B?MjVBN0ZLdTFTNGFyd1pHQ2lsREVkbWgyeTdDQ202YTNLb1IwWHEzNXFiRG5L?=
 =?utf-8?B?SUVkekRzSHdOdXpVejNUdXNyZTRpb2h2b2c4WllZTThrc243QzJDOS9KQzJS?=
 =?utf-8?B?Nnl6a3ZDUDV1djdDOWZEMVpyN01OMkpPRjJZdzhQZjdCbWZKdytwc3JFSkNK?=
 =?utf-8?B?V3R0cXN4eWhVQkFVQ3dlY25udDhST3pWazVzenhsS2JGbFpTVzdMcm11OEF5?=
 =?utf-8?B?MWI0S1R0bzBROVhINFRzNkVOTHlQRnZPRHVQeGxOMkFjSGFsQ0MxRFlodWI5?=
 =?utf-8?B?T09UUEc1TE5UTG1DTEF0Vm5BYkZ4T05uVFhRSGpNM2JVdWpIazNNc2JCWDlR?=
 =?utf-8?B?U01PeHJnbEFOWm95TGgwUnE0UjZFUWRjMkw4czM5WWdya3NnR2JhWFFUVkgw?=
 =?utf-8?B?VzRYRkt3UnBtNW5HQUhoclRZaFY3M3JFVHlacDMrMGlzTmFVOGZuMUFjcFhu?=
 =?utf-8?B?RXpUT1JKSjR3KzhhdXJkK3FSQ05TOFlIRE5EWHR0cU80ZDh2UnJmMWVzcjh2?=
 =?utf-8?B?R2loYm9Sd28rcGExL2xOaTdYdU9rUWFBN0RNQUxmaWpQRWUxNjk0RDlGSkV6?=
 =?utf-8?B?dmp0eWxyVjdlalhqVjd4dUlSUjhuUzEybmErWDIvaUhPSVgydmYzRGJVZUNN?=
 =?utf-8?B?QzNPdGlZY3F1d1BxRWIvQVBzUkZ0WmplQ3B5dzRQZmo1bFBxT2lyalFuekxU?=
 =?utf-8?B?eVhiNVNjR3NNa2hibGxnanMxQUVZQS9CNWFlcnZweEhrL05KcGdpMVE4N2tN?=
 =?utf-8?B?VE53Z20zSG1YMlJZaFZ2clpJd3RSUGxKQkxTLzJZbEdaTzNxNzBDUlozQ2RM?=
 =?utf-8?B?ZWQ0c0NsTGIzdElIczlFVlVHa1JldXIxNE9BaDFYWnJJRS9VV1BHN3QwWXBX?=
 =?utf-8?B?Q2U5RXJudjNNbkFBUm1pRXhzZVpKdzdoSGExQ0hTYzN4SEN4T0VJWTZoZHZZ?=
 =?utf-8?B?R05SM25YZmk4RDVIbFh2amtkWTR2Zzg0Vk43MUFWZElQUUZXaDlaM2MxdFNO?=
 =?utf-8?B?bE5FeUdNdjltRHVLc1Z1dDVEaXV2SXlHYkN6aXI2YTZGSkhUZTlpdjNMeldt?=
 =?utf-8?B?L2txSzFmTEJUYlduU2R2ajlsMlAzUjZ4M2wwZHlyU2xVeG11TFl5aFlGMGlP?=
 =?utf-8?B?ekE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e3edb1c2-3f7f-4fcc-bf0b-08da91eba0db
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 22:44:02.9850
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GMX43Odaps5bPjJRTboI/JZA7Cw5GlPLf+oT+/xBkxl3gEtCk7PN3Gqn1BxxKFiFHZCnP6iQ5ErnjRg281napKRCF9OA2A1H3/JzxwGAyhI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4075
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jarkko,

On 9/4/2022 7:04 PM, Jarkko Sakkinen wrote:
> When calculating ELRANGE, i.e. the address range defined for an enclave,
> and represented by encl->encl_size, also dynamic memory should be taken
> into account. Implement setup_test_encl_dynamic() with dynamic_size
> parameter for the dynamic heap size, and use it in 'augment_via_eaccept'
> and 'augment' tests.
> 
> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>

This is a constructive addition, thank you very much.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette