Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Sep 2022 15:51:13 -0700
From:   Isaku Yamahata <isaku.yamahata@gmail.com>
To:     Yuan Yao <yuan.yao@linux.intel.com>
Cc:     isaku.yamahata@intel.com, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>, Will Deacon <will@kernel.org>,
        isaku.yamahata@gmail.com, Kai Huang <kai.huang@intel.com>,
        Chao Gao <chao.gao@intel.com>,
        Atish Patra <atishp@atishpatra.org>,
        Shaokun Zhang <zhangshaokun@hisilicon.com>,
        Qi Liu <liuqi115@huawei.com>,
        John Garry <john.garry@huawei.com>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Huang Ying <ying.huang@intel.com>,
        Huacai Chen <chenhuacai@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH v3 16/22] KVM: kvm_arch.c: Remove a global variable,
 hardware_enable_failed
Message-ID: <20220908225113.GA680494@ls.amr.corp.intel.com>
References: <cover.1662084396.git.isaku.yamahata@intel.com>
 <91715ddc16f001bf2b76f68b57ebd59092b40591.1662084396.git.isaku.yamahata@intel.com>
 <20220907055657.y7dcseig2qvjue6t@yy-desk-7060>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220907055657.y7dcseig2qvjue6t@yy-desk-7060>
Precedence: bulk

On Wed, Sep 07, 2022 at 01:56:57PM +0800,
Yuan Yao <yuan.yao@linux.intel.com> wrote:

> > +static void hardware_enable(void *arg)
> > +{
> > +	atomic_t *failed = arg;
> > +
> > +	if (__hardware_enable((void *)__func__))
> > +		atomic_inc(failed);
> >  }
> 
> A side effect: The actual caller_name information introduced in Patch
> 3 for hardware_enable() is lost. I tend to keep the information, but
> depends on you and other guys. :-)

That's true.  But only kvm_arch_add_vm() calls hardware_enable() and other call
sites are converted to call __hardware_enable().  There is no confusion with
other callers with this patch series.  So I decided not to bother to pass
function name in addition to a failed counter.

-- 
Isaku Yamahata <isaku.yamahata@gmail.com>