Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ef27cb3d-3d60-9be3-e665-0f6d7d02e18f@intel.com>
Date:   Thu, 8 Sep 2022 15:43:33 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.2.1
Subject: Re: [PATCH v2 3/5] selftests/sgx: Use encl->encl_size in sigstruct.c
Content-Language: en-US
To:     Jarkko Sakkinen <jarkko@kernel.org>, <linux-sgx@vger.kernel.org>
CC:     Haitao Huang <haitao.huang@linux.intel.com>,
        Vijay Dhanraj <vijay.dhanraj@intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "Shuah Khan" <shuah@kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20220905020411.17290-1-jarkko@kernel.org>
 <20220905020411.17290-4-jarkko@kernel.org>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20220905020411.17290-4-jarkko@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFRvdkdWM3EvakcvcisxZzB3U3BGVzdNby9yb0poREQvWE5YMkR6UUU1ekVL?=
 =?utf-8?B?QjRNTG1zVHpzSGtJRER6VWxMZ0U2dWNBQzFZSSs5cnNZbG02MGtIemtab1RE?=
 =?utf-8?B?Nnk1aVhvYnA0R0p5L21NdFNmSnBEWHluaXpVSFFqOXBGQU9HU1FyT01mSVdp?=
 =?utf-8?B?a1BvU2dlMUdGMmZFbGZGa0JhRUQ1UTRreFN1WS9mUFp4ZTR3bEFDYjV3cStY?=
 =?utf-8?B?YXZBZU0rY1BNcmlRazJUZ01hRnJvbGdRSytveVpvVWdvZEhtd3NJV3laZlpC?=
 =?utf-8?B?cGgxRjdqQnJhMU50K0YzRVYvRWQwbHpUV0Q5OG9UcS95VC9Bc1NtNldMbE9t?=
 =?utf-8?B?S29PS1E2cGluTHQ4Z2FkRjZNSGhPVFh3S3dlak1QSDdNT0R1eHo0M0JQRGw5?=
 =?utf-8?B?b3R6VVdIQUphWlorci9pcFJEM05lOGZFMTBZeDFRdUNldVU5eVNDSzdTcVhG?=
 =?utf-8?B?UWJ6MU14eXppYS8xWmZFQXhqQzJjWUFXNHdmbDh4M1hsNjlZSFpnTlBQbk5F?=
 =?utf-8?B?VEtsZXl3UTBzMzlEQlZ2Ni9MNG4xTGEyZTRKOHdFYmthbk1VSFhCVDh6RTZi?=
 =?utf-8?B?K3cvMkNKanBLZloyS3ZPSUJLZWtlZ3dhaUt5WUYwYU5tS2tjaHgxV0NwMzRi?=
 =?utf-8?B?bDN2NXVtd0NwY3BKU0oxd08zOEJIMzNBdDgvOGpoWFk4SXZqT2ZUTjQ5ODR1?=
 =?utf-8?B?V1RrM1YwSlhpSW1lU2EvSmNZdzZxWC9tSHRIc2hKRzFESzN0LzAxNFdYOGRU?=
 =?utf-8?B?QjRzYmNkOFBEemVXdlN2VjVBUEdMTFhTeTUxejBydm5OSGlRYjdQSzl1VEFz?=
 =?utf-8?B?N0l0Tk93STlMRm1hT3REQ0VDM2diMUREWW5xcnNPbVhTeXI5bDdBenlKVGxn?=
 =?utf-8?B?Q0ZxZGJXb0ZaUWtKd1N2NmFDb29NUkhUWWJjOG1UMCthaUJYalRyZVJPRERI?=
 =?utf-8?B?dmZicGRJSGxKRE5ONFRUNjNpYXdqTWtSV1V2ZzJSeWpWa3JTT1FFT0RaZVVm?=
 =?utf-8?B?YktZYzk4MVprUzRxaXdORkZuNVJtZjd4RjZtTnh4c1VTMldMbFBvenI2cjNT?=
 =?utf-8?B?ZjRCNXhhMTRGZVdqSVlORHdLRVNFaU1pakg5Nm9pMXpVUlZsNWxVN0oxSjMv?=
 =?utf-8?B?dWtlL3VLUU5VTHdIdXRodGZndEFuSS8wQkZhY0xSWTlGZ1NUb1BlelVISDBh?=
 =?utf-8?B?Tk45YjNrbi93NGUrdnp0ZVYxU2Fyc0FjUlZiejd2WGZtdTMxWlU5aGw0cmVn?=
 =?utf-8?B?SVpRSTZheEtWR3ZCMWdZaEZvSVJONUZCUzBvS3F0RUY4Z2JOK3c1V2hkT3hH?=
 =?utf-8?B?UllUdDJpSWJ1eW5jL1B2T0p2YktGS0Q5Z3cyc0FvZitHZXFzek03eThURUhl?=
 =?utf-8?B?RjlhWTltNXNGbmZRV21BTEJlaXJma3pFRFhMUzBrZVd3SUVOZDluMW53V3FW?=
 =?utf-8?B?aWk4VFJwNkRaSTdmNzRCYmhQcDhlVE5XaUtyZDd1dC9BVmFYNjJneGR3M2tC?=
 =?utf-8?B?L0NBSUFhN1I0TU94OUwvZ0xYRnYzdXFTbjJ4NWZ3SXhBVEVaRVJ4UWZGTmNX?=
 =?utf-8?B?N2RjUXhWQlhWcmJqanJUK3ZlZm0wVVlNUldzS09yS2h0NVl1THo0bzR6NUgv?=
 =?utf-8?B?VWxqbktxRThKZ3NEc0R2YmdPWnZEdTFXc3B6WStJdWppRTZIOWo2alRmNzZG?=
 =?utf-8?B?dXFPME16cm12b0REWFJVRjFQV3pUSkdMOVovNXBjM3h6aTA5Uk1ieUtTY1lL?=
 =?utf-8?B?TE5hbXdqYlJMVFZDaVREM1h5STNkNlVzRUdyZU5tZDh2R1JzemdPam1TOHg3?=
 =?utf-8?B?NWZEUDlib0MwNFVaK3pjek5Zd0xpbUh4cFBmQWFvS3hWSzdiendDUmZaczYr?=
 =?utf-8?B?bHhFdWFpMGV6SWpLQ1EvNXdDV0ZXeDFtc3BxcXFUZWg3eXBxeHBhSWZTY29o?=
 =?utf-8?B?Zmc1OERHcjFiVUlFRS9Md3dMRTZQNGcvc0o2OCs2RG94UFJWY2FZV1V4Njlq?=
 =?utf-8?B?TXpOWjJoNjM4RmRXdGtBOXd4RmhqSjBxSmY3TzVwbVJ5Z3FITjZpVWU0SUl5?=
 =?utf-8?B?b05vUVZYNmdFRk0rSFJBSUVIdFBZdzM0TlRUMTRLLzk2Y1UrTkgvMGVGNG9q?=
 =?utf-8?B?dFRNSW1mMElBK0JWa3B2NG0zNGcwZTQ0SUFQV1poL2Era2Facnl3V3RIVG9s?=
 =?utf-8?B?Ync9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 84848146-50b9-4a8f-ccaf-08da91eb9032
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 22:43:35.0655
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nU3J1znroBKnQLN1TN4bYEAFjTyP7wu8kPueMvjRrA9BpGVaEHwi5R/GC1sJVB7C7748mrS3ygHZBHOrimytb2jWD9kO3v8mS2wQpmbWYh0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4075
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jarkko,

On 9/4/2022 7:04 PM, Jarkko Sakkinen wrote:
> The final enclave address range (referred as ELRANGE in Intel SDM)
> calculation is a reminiscent of signing tool being a separate command-line
> utility, and sigstruct being produced during the compilation. Given that
> nowadays the sigstruct is calculated on-fly, use the readily calculated
> encl->encl_size instead, in order to remove duplicate code.
> 
> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>

Thank you very much.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette