Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp1351948rwn; Thu, 8 Sep 2022 18:29:09 -0700 (PDT) X-Google-Smtp-Source: AA6agR6unHX8kkpoH/xgTGIImMZwbXlV7KRdpHMxpe//TJnPXsz2iMLoAUK43EChWmAfUeayXHUc X-Received: by 2002:a05:6512:2302:b0:492:ce48:1bab with SMTP id o2-20020a056512230200b00492ce481babmr3293100lfu.266.1662686948821; Thu, 08 Sep 2022 18:29:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662686948; cv=none; d=google.com; s=arc-20160816; b=iooWVzGRXyo71DNEznaNb4wG34Rrg8FRP/t8Hem4S+I3XSUYYZbeN1WDmMFsisrz/1 lEqSwt6WEguZ5zAHACPrBsgaIkM9g9Kw8+SWah3gM0h0kO8KlsIy5Hvzk08ev4sx2Z9r 7uopD2SCoO9d4UJEcULcobt7uas2m8kS1Fzagn0Hb9eiD/WWd3MWDCZMpSWRBzY+sXN7 5VWXEpnt8vKLPoQ7JgDxT7N8H+9hDBwDX39BFtxqqBEwOGfmDAeVmNzdQ7o5pncBf8cb 37TTn5UPGoJahC+ISO9BZXb55F5x8QKN2iSWVWSDjwxbkz28KttiOePJDTCvP4/KeK5d bokg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=lVn1cmpmJIdfbr8ciE1uhdKdZMEBn2lsgxlg2Dfm4gU=; b=jgtGTtlO/hS81zE3SfQE6grOR2obFIEz5xETkli7FfcyJevXnmxDLAkzvzxXkDNpd0 EHkFWbBYRKWDQz5JVvbLX6c0dxKKd3925ejK3IkypOKc3Vr/7wSaVkH2Qgj7TnexLuFQ ShHVdRdMYmVsRORcG/wKXU4zEataAnwesvvs0YSHRLybFw+U24a1FZDJk7ZmFGrrb/zC tk6lRCegsmijjn1Ct/hPScCploYcte5rs3LSwy7tkMOuCVClgVS1A4+bIDPZFNakCq05 M5FPxlzYkxuAJy5y6s7OxmP/D4S/0+HPNQ+dl0dmX5mEZ8jZpKHAJsiFXe+TYj0N+yZR LCJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="T/d4eyoF"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p8-20020a056512234800b00492ec341b08si179986lfu.583.2022.09.08.18.28.39; Thu, 08 Sep 2022 18:29:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="T/d4eyoF"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229587AbiIIBVw (ORCPT + 99 others); Thu, 8 Sep 2022 21:21:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229546AbiIIBVv (ORCPT ); Thu, 8 Sep 2022 21:21:51 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABEA410B032; Thu, 8 Sep 2022 18:21:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3374561DE3; Fri, 9 Sep 2022 01:21:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66532C433C1; Fri, 9 Sep 2022 01:21:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662686509; bh=fVPajho/aOku1+8nabWUPcT67X3OaItOI+7Sotm7FB8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T/d4eyoFdQxk8p+PjLpEOdlfzaANQNJguMj9T0/2rVrTISomyq4dO9J6/B9wwZ327 ZXKzlYzzzK4Rh1mwKxe+7V1Z1/XpfCaggPh9JwTbGkAWf61f/3UwZQtacdq4Iv5do/ ATaMTXBe6nVFU+P5b5LV1uzi7sXQsm0Vpfe52HLtOS7v5ZGJqxpDe7uTA7vNiqEekY X6iLjiSF36DXHQhGDcIKrQ9cvd6Mcblx4ske0Cpk//Bfgb4v7l330gkspuQfLfzETh GP15eKqlJLQcSQHiK/rQIwpSANrstQAdfbtRkv2fvfNIiVc4fZ185yc9IV8MeUMTKQ +Yb+dEfLjr+6Q== Date: Thu, 8 Sep 2022 21:21:48 -0400 From: Sasha Levin To: =?iso-8859-1?B?Q3Pza+Fz?= Bence Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, "David S . Miller" , edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.19 24/33] fec: Restart PPS after link state change Message-ID: References: <20220830171825.580603-1-sashal@kernel.org> <20220830171825.580603-24-sashal@kernel.org> <243d3362-403d-7a94-34fa-12385100cc53@prolan.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <243d3362-403d-7a94-34fa-12385100cc53@prolan.hu> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 31, 2022 at 03:02:46PM +0200, Cs?k?s Bence wrote: > >On 2022. 08. 30. 19:18, Sasha Levin wrote: >>From: Cs?k?s Bence >> >>[ Upstream commit f79959220fa5fbda939592bf91c7a9ea90419040 ] >> >>On link state change, the controller gets reset, >>causing PPS to drop out and the PHC to lose its >>time and calibration. So we restart it if needed, >>restoring calibration and time registers. > >There is an ongoing investigation on netdev@ about a potential kernel >panic on kernels newer than 5.12 with this patch applied. Please hold >off on backporting to 5.19 until the bugfix is applied to upstream. Will do. -- Thanks, Sasha