Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp1382361rwn; Thu, 8 Sep 2022 19:15:44 -0700 (PDT) X-Google-Smtp-Source: AA6agR5gcKjpfugS+LpdCjFW+i5aTOuBT9hs3FoMP75Wj5Z/o0W7PH78Ip3SQ1AVtEgFz98JjIPW X-Received: by 2002:a05:6a00:b8b:b0:536:71f7:4ce3 with SMTP id g11-20020a056a000b8b00b0053671f74ce3mr11921395pfj.74.1662689744349; Thu, 08 Sep 2022 19:15:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662689744; cv=none; d=google.com; s=arc-20160816; b=qmI7krNx65ctZqIfMxfzzV5+Zo0j5K5/oPoXTQzQLIzf1xEXKxFLaM1JxmZH1lqP78 EU88NaPZe6FO09zmdhBX4BDEWyJ8OxEbq/HjdrY4+c++VbSNeVlxcFlakQ6V+DQocLTR ucFQbUUNlFlHRzv9qGhyFZSK+DB0VXHtiTmWY9cFmzBdWrduYMBzF47mz2v7nzXkJ+qI YXPNQiD5wKwS4HRgQez0GSZ+RhPZg6lMcyTEAybgqtoDgsydNKqdNzp/uDGNFLFn1Kxr A4HsH7Uet/kIMY2IpfnCC60YUQnIuw9YDMBFWMkxatPYEGbNB2/zNkfoOmrS2kbbpn+/ A6PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:cc:to:subject:message-id :from:content-transfer-encoding:date:dkim-signature:mime-version; bh=WymaQapTEnrtpVYLXL9nYq1V8BG7Nsc68KX/U9lk3pk=; b=NREZXHmP2nx2k47TnkO4dywwcE+JKt0tNXx7xrUwrwwjzydZiu1AOg1f2TFDxGJLFF pKC2H0xrm7ISWeOPQJT8yzRCBn0c14vCkn8/B1PpvMZQ60HzJ5NgCh794USVIm9TyHIY FTZK/6Jora6/WT6bs+SAj7KmrAxML4tFz9PWo7COc9m+Nb8/W5Xj33E0fnLhldatwI23 fgOkYg91fpE+9vWTf947vl8puamEN1zxvsO9+62bD7C0aFlVmeg6TH3+Fek2u/hGfeFF 1Wnfi9LgtVaWkqBRJzL757m39RZ1c7CaOh7erb81kDc/461n9gnMK5GOQscXP20Vc6dQ RWGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=rrWJpT2X; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r13-20020a63ec4d000000b00419f8572858si396569pgj.755.2022.09.08.19.15.32; Thu, 08 Sep 2022 19:15:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=rrWJpT2X; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229796AbiIIBxK (ORCPT + 99 others); Thu, 8 Sep 2022 21:53:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229505AbiIIBxH (ORCPT ); Thu, 8 Sep 2022 21:53:07 -0400 Received: from out1.migadu.com (out1.migadu.com [IPv6:2001:41d0:2:863f::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E335115CC1 for ; Thu, 8 Sep 2022 18:53:06 -0700 (PDT) MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662688384; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WymaQapTEnrtpVYLXL9nYq1V8BG7Nsc68KX/U9lk3pk=; b=rrWJpT2XGfSdXof8SEypioEGZ23VX5vbAUzXz1nozpGrLtDZADWOQPPHeicdovh6ni5OtV qIJUkdhO4kCNA7zbzK3p5aINzD/98Po4BT++tlQ0UZVfWrCKS9evQ9BzJeuWlRsDOdc6CV X6boWrsjpP/aJ7lTPmrb2LbNEQNxlps= Date: Fri, 09 Sep 2022 01:53:04 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Yajun Deng" Message-ID: <040c19a13f1d7973db7369553045cd8e@linux.dev> Subject: Re: [PATCH v2] mm/damon: introduce struct damos_access_pattern To: "SeongJae Park" Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org In-Reply-To: <20220908191756.129602-1-sj@kernel.org> References: <20220908191756.129602-1-sj@kernel.org> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org September 9, 2022 3:17 AM, "SeongJae Park" wrote:=0A=0A> = On Thu, 8 Sep 2022 18:43:56 +0000 SeongJae Park wrote:=0A= > =0A>> Hi Yajun,=0A>> =0A>> On Thu, 8 Sep 2022 11:26:11 +0800 Yajun Deng= wrote:=0A>> =0A>> The damon_new_scheme() has too = many parameters, we can introduce struct=0A>> damos_access_pattern to sim= plify it.=0A> =0A> Because my previous comments are only for trivial cosm= etic nits and the size of=0A> the patch is not tiny, I fixed those on my = own and posted it:=0A> https://lore.kernel.org/damon/20220908191443.12953= 4-1-sj@kernel.org=0A> =0AThank you! I'll do it more standard later.=0A=0A= > Thanks,=0A> SJ=0A> =0A> [...]