Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Peng Fan <peng.fan@nxp.com>
To:     Marek Vasut <marex@denx.de>,
        "tharvey@gateworks.com" <tharvey@gateworks.com>,
        Stephen Boyd <sboyd@kernel.org>
CC:     Matti Vaittinen <mazziesaccount@gmail.com>,
        linux-clk <linux-clk@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Fabio Estevam <festevam@gmail.com>,
        Shawn Guo <shawnguo@kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        Michael Turquette <mturquette@baylibre.com>
Subject: RE: BD71847 clk driver disables clk-32k-out causing RTC/WDT failure
Thread-Topic: BD71847 clk driver disables clk-32k-out causing RTC/WDT failure
Thread-Index: AQHYvlGBdqdb0Wka20ODtoakwJg21K3LiDmAgAozSACAAA+IgIAAKeoAgAAUeoCAAFoVIA==
Date:   Fri, 9 Sep 2022 02:06:36 +0000
Message-ID: <DU0PR04MB9417D8123D40FBC980E9C05388439@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <CAJ+vNU1Za2CPGVX3q4HKufsxbL5zRrk1B5CWFpKritetrTs4dA@mail.gmail.com>
 <59b6dd0a-7cbb-5dbd-8da0-57baeba3327e@gmail.com>
 <CAJ+vNU2FVQRwCa3DnOwkFjaZg-ntFLZmetwDbSggDXDdwOOGTg@mail.gmail.com>
 <2ab24cc4-4aa2-d364-9b29-55f5d6b23626@denx.de>
 <CAJ+vNU0voeMW06Je6nyrV1Ud3sT8Us+RACcQtsKUwKVaXF+dQw@mail.gmail.com>
 <ce0ffc43-bae7-a55b-ebea-985abc765c33@denx.de>
In-Reply-To: <ce0ffc43-bae7-a55b-ebea-985abc765c33@denx.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BCXisrlXztK6xmseWT0mhKymrpkMYAxQw/o6n5lz0rQ1i/Yj7wlQiCV6nBGH?=
 =?us-ascii?Q?E+AOtdGnV4n+2NSWUuyjpPGYLlujvPKRY2cWWz8m0eZX5VOU9I95xNKI6fTj?=
 =?us-ascii?Q?GtbSD+7PLHcIg53emeyfXqRq49jWQP7IaaEZvVdfyJuLovKjnMW7ZBepHqIV?=
 =?us-ascii?Q?pmLAYubebHywopUySjMBNB/YKVWx78mFIJmejlH9oMUSQkpPZnYayT1dc7OM?=
 =?us-ascii?Q?5yL/KnurKtoGa9gNLbERE5MVDDXX355bN1qc6BQOmQb+LmL2q8DRctaczs33?=
 =?us-ascii?Q?ZzsReQ5Cm/b2YGk6ZJldYQTTK1PJnsvsO52hJgPcjyRrPM0knOj8KFJWiVHh?=
 =?us-ascii?Q?s1d96CeDN/41GvSIneBTTzI9JRVMCYj0Lcqpsa4CeLBNC+gC2Jxv4k7Uk6jp?=
 =?us-ascii?Q?LEd3TAukFgOjil4I/PnBWyJLVXT57kvLJ7DRf5OutKtWW+f0gqjC1Ya4LY4M?=
 =?us-ascii?Q?h4XnvRaotbXWa1td8u65h/kvGGhcmxWCPzDTQ1C9lSAxBoKSxWQKEApenyFW?=
 =?us-ascii?Q?TO/hp61LQ6N+KN6m1OYdlUbWakzr/UFx8eom5zlqsHgWhKgxkhVMvCSzgHjB?=
 =?us-ascii?Q?0qPOtmpaljreXzVu0+mVSH6ZHFpR3dlP+q3K4Jpu2Z03QLt7GohgL4Z7oUzY?=
 =?us-ascii?Q?UM8C3VqelX423n2vKczc3wZ9W1M3nsPdLujqPrCGibxJb68SGqB+c9MTkUIg?=
 =?us-ascii?Q?l78a45PbIImBZqwNI+A8RvbE/22a6/grsRz6HtTfUMfytvpwM5V2wd3yANlD?=
 =?us-ascii?Q?f576plPfAMYhalgaRKW/Cw8cFbfxWezFSO17UC5sNqD752i1Zh7yJmXwURcM?=
 =?us-ascii?Q?IN7PyepVM9hZzxivTUQ+SBpUiHuTyBNjFX4berNJCvwEUecb1VjLy6BobXUm?=
 =?us-ascii?Q?CcB6joWv9NYsiMXCM6dgSVhrzNNzDNNWW+XzjVcBvEeGxjLoqWcGZGqAFaIc?=
 =?us-ascii?Q?Xle6p72D+4HopVAcUIRh0JOBoXJZ6ftAyrhSmlaMofW1lyBREGZ/lUyn5rmf?=
 =?us-ascii?Q?zTk8PCpEeVqsCSvLCctSovVcngRXSVudCs+hq64UtddkHqQucPCCu6GcpkCq?=
 =?us-ascii?Q?rRG1ObGD7hQBipGRjesWPKyCEAhWFP6ED1FIk20ROUACB0E/F3WQKR27Gcpp?=
 =?us-ascii?Q?nacga/djHJ7i3o6t+FZ1JSS4xzvhja9f4KLiTEfrS2WpWQOIbASH5E02/JwZ?=
 =?us-ascii?Q?MQTnb0dsCmcIYcu8UA3nNtplJLKz68mG/drEENsrihL8iNjFA7EcWhaMjKCD?=
 =?us-ascii?Q?dbYAAKQ5kXEIrD5yu1EfkisFOZNhlj/qiOm8o+QCFpgig2dR3bakVJCoodgu?=
 =?us-ascii?Q?EPtlKvPmJAhhR8NfuQOAWNNgUk4yislqoRk16TjzY04nC7Y91C1SSZiNHwDa?=
 =?us-ascii?Q?UWJjGBgPjw+mJDP7OWeKdhbTfSfdWnOnJ39Ip03ugA40VYQ15B0EtFxASu7V?=
 =?us-ascii?Q?IHWEVC70W2chVnmNkJv2nsi61Vrj3JVUkmFWorXI/dOS0j3i2CtMWN2Sqa9F?=
 =?us-ascii?Q?CYTZpncc4sQ583A2VhnKW5guVTcqZqdnQzjv/h0oHA1OsO9V2jusk2L2P3Mc?=
 =?us-ascii?Q?RCvW/sitTxNCyyHXfto=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 52852221-e1a1-429c-34e1-08da9207ed1e
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2022 02:06:36.6327
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NnS7eriArgI7KZr0x81yLerHFyAw4ayZOHJixK448b2rS+731Z2QUeX8FSunfC3HoRpitwN10VOs9E00LKQ1Ig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3944
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: Re: BD71847 clk driver disables clk-32k-out causing RTC/WDT fail=
ure
>=20
> On 9/8/22 21:25, Tim Harvey wrote:
> > On Thu, Sep 8, 2022 at 9:55 AM Marek Vasut <marex@denx.de> wrote:
> >>
> >> On 9/8/22 18:00, Tim Harvey wrote:
> >>> On Thu, Sep 1, 2022 at 9:14 PM Matti Vaittinen
> <mazziesaccount@gmail.com> wrote:
> >>>>
> >>>> Hi Tim,
> >>>>
> >>>> On 9/2/22 01:23, Tim Harvey wrote:
> >>>>> Greetings,
> >>>>>
> >>>>> I've found that the bd71847 clk driver
> (CONFIG_COMMON_CLK_BD718XX
> >>>>> drivers/clk/clk-bd718x7.c) disables clk-32k-out (the BD71847
> >>>>> C32K_OUT
> >>>>> pin) which is connected IMX8MM RTC_XTALI which ends up disabling
> >>>>> the IMX RTC as well as the IMX WDOG functionality.
> >>>>
> >>>> //snip
> >>>>
> >>>>> This happens via clk_unprepare_unused() as nothing is flagging the
> >>>>> clk-32k-out as being used. What should be added to the device-tree
> >>>>> to signify that this clk is indeed necessary and should not be disa=
bled?
> >>>>
> >>>> I have seen following proposal from Marek Vasut:
> >>>>
> >>>>
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fl
> >>>> ore.kernel.org%2Fall%2F20220517235919.200375-1-
> marex%40denx.de%2FT%
> >>>>
> 2F%23m52d6d0831bf43d5f293e35cb27f3021f278d0564&amp;data=3D05%7C0
> 1%7Cp
> >>>>
> eng.fan%40nxp.com%7C07d48edcc47c4694e08208da91da2bf4%7C686ea1d
> 3bc2b
> >>>>
> 4c6fa92cd99c5c301635%7C0%7C0%7C637982664162868785%7CUnknown%
> 7CTWFpb
> >>>>
> GZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI
> 6
> >>>>
> Mn0%3D%7C3000%7C%7C%7C&amp;sdata=3DuF26u9g4onuqCWzPRAvD%2F%
> 2FLByaEhh5
> >>>> Dtah9K8CcAOAM%3D&amp;reserved=3D0
> >>>>
> >>>> I am not sure if the discussion is completed though. I guess it was
> >>>> agreed this was needed/usefull and maybe the remaining thing to
> >>>> decide was just the property naming.
> >>>>
> >>>> Best Regards
> >>>>           -- Matti
> >>>>
> >>>
> >>> Thanks Matti,
> >>>
> >>> Marek - has there been any progress on determining how best to keep
> >>> certain clocks from being disabled?
> >>
> >> No. You can read the discussion above.
> >
> > Marek,
> >
> > I wasn't on the linux-clk list at that time so can't respond to the
> > thread but the discussion seems to have died out a couple of months
> > ago with no agreement between you or Stephen on how to deal with it.
> >
> > So where do we take this from here? It looks like there are about 18
> > boards with dt's using "rohm,bd718*" which would all have non working
> > RTC/WDOG with CONFIG_COMMON_CLK_BD718XX enabled (which it is in
> > arch/arm64/configs/defconfig) right?

Is there any requirement that the bd718xx clk needs to be runtime on/off?
I suppose the clk should always be never be off, if yes, why not have somet=
hing:

diff --git a/drivers/clk/clk-bd718x7.c b/drivers/clk/clk-bd718x7.c
index ac40b669d60b..109cef35418b 100644
--- a/drivers/clk/clk-bd718x7.c
+++ b/drivers/clk/clk-bd718x7.c
@@ -104,6 +104,8 @@ static int bd71837_clk_probe(struct platform_device *pd=
ev)
                dev_err(&pdev->dev, "No parent clk found\n");
                return -EINVAL;
        }
+       init.flags =3D CLK_IGNORE_UNUSED;
+
        switch (chip) {
        case ROHM_CHIP_TYPE_BD71837:
        case ROHM_CHIP_TYPE_BD71847:

>=20
> Feel free to continue the effort.

Tim, would you continue the effort?

Regards,
Peng.