Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Jason Gunthorpe <jgg@ziepe.ca>, Eric Auger <eric.auger@redhat.com>
CC:     Matthew Rosato <mjrosato@linux.ibm.com>,
        David Airlie <airlied@linux.ie>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Eric Farman <farman@linux.ibm.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Kirti Wankhede <kwankhede@nvidia.com>,
        Vineeth Vijayan <vneethv@linux.ibm.com>,
        Diana Craciun <diana.craciun@oss.nxp.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Longfang Liu <liulongfang@huawei.com>,
        "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        Leon Romanovsky <leon@kernel.org>,
        Halil Pasic <pasic@linux.ibm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>,
        "Wang, Zhi A" <zhi.a.wang@intel.com>,
        "Tony Krowiak" <akrowiak@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        "Heiko Carstens" <hca@linux.ibm.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        "Alex Williamson" <alex.williamson@redhat.com>,
        Harald Freudenberger <freude@linux.ibm.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
        "intel-gvt-dev@lists.freedesktop.org" 
        <intel-gvt-dev@lists.freedesktop.org>,
        Jason Herne <jjherne@linux.ibm.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        Yishai Hadas <yishaih@nvidia.com>,
        Cornelia Huck <cohuck@redhat.com>,
        Peter Oberparleiter <oberpar@linux.ibm.com>,
        Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
        Sven Schnelle <svens@linux.ibm.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Abhishek Sahu <abhsahu@nvidia.com>
Subject: RE: [PATCH v2 15/15] vfio: Add struct device to vfio_device
Thread-Topic: [PATCH v2 15/15] vfio: Add struct device to vfio_device
Thread-Index: AQHYvdNJtymT/Xe4J0W2tfymtujF8K3VSQ2AgAAC0ICAAAYqgIAAMbyAgADzG4A=
Date:   Fri, 9 Sep 2022 03:09:48 +0000
Message-ID: <BN9PR11MB5276FD68BBACD97741BAA1BB8C439@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20220901143747.32858-1-kevin.tian@intel.com>
 <20220901143747.32858-16-kevin.tian@intel.com>
 <50d82b01-86a3-e6a3-06f7-7f98e60131eb@redhat.com>
 <546463b8-54fa-2071-6a9a-e4087eb8bb2c@intel.com>
 <4c9350cd-c2ce-dc84-9a29-210907d2a2a2@redhat.com> <Yxnh87ZIS2JwvN7D@ziepe.ca>
In-Reply-To: <Yxnh87ZIS2JwvN7D@ziepe.ca>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?L5tOBBiJFVqP9RMyh5L8zQdFFFLDy/sPYNUkzQzFkEQNCU487SoX04c71JKm?=
 =?us-ascii?Q?EoVphOQufOR08aLiIwp9wMd3xixESFMuZhiF+ssN1SwqKFBnHqLIqsq676Py?=
 =?us-ascii?Q?LzusEI8OZD77UcDUG99BSIwk/I04Qny/4HjoeaFsIxGKSqYaxwJf5FwCE4Cp?=
 =?us-ascii?Q?Q7u5goKROC7Dz0U5IzRMptTJPlfVx9h6u6iifU3HYhEAiQENcPiBtVd27ug7?=
 =?us-ascii?Q?ODCcQJBeLajxOT0elDeXNV2J13jR2k2Ooq/ZI7PyOg84tYzS8j/OsuDbLd5R?=
 =?us-ascii?Q?RfpNT3RG36iN+2kWKSaboWsKIyyKxCRylE2TE+WutzdHyCT/yQyLXnxGpM3W?=
 =?us-ascii?Q?q72fPZZeWQGCGPIOc5aS1f15YU3mIQge3Ia/+srhHsWUYY12d02jWzLEeITB?=
 =?us-ascii?Q?DLqEXB+1Bd3Go+pEeG13an992jLdfDz612FA3qPWIBJ6CO6D3nSEDWLtccDs?=
 =?us-ascii?Q?8oIt8VviYFnKt4fM9LblMzQQtVTEae1SeCC1EyJmBia6llupRdFn2lyMjKEV?=
 =?us-ascii?Q?hCHfES15IiBI3nvMGf9izOH/GyG8Wo4norsyMOAgYbohs78zpH0t+gV+Oq7j?=
 =?us-ascii?Q?KRIN2DFlt+etO6Zfe7Rj3H56EQzbHN+CwKphn8167H8UnNAkfhAae9j/rh5Y?=
 =?us-ascii?Q?h3OWZsIq/UtWIzEAo+sbe1adF0s+MdI5CanCrLZhl3XAMUEUghxSZLHbFCm7?=
 =?us-ascii?Q?kS2ggg4J7tiOYnj1zO72ayA9v7pvHYlz7Xl4VfJfm5BSSlH2jeIhwQwZEjSj?=
 =?us-ascii?Q?Zwrnz5+2JkmiiCGS9kq8hmD/rbzwglnfpSChp9oJz8o1lq3fv6VdRbflXuYv?=
 =?us-ascii?Q?mOF7oHJWXKzX6pnsgjZBZ7+yXhKv2Bx/ZI79yvUvf1Pu1tKjpw8WluqFgDUK?=
 =?us-ascii?Q?4Zp6DGIPbf9KuJcgLt9x/JcS/3Txv80odHUqI2FmpRPpYN3J8hmILJAeauA4?=
 =?us-ascii?Q?KJS+iSo3Tc3UXBJ66qcHEDsOicHLPkVlsWc46SlhMuHKPHJJrO5QbORCQ9JZ?=
 =?us-ascii?Q?/DrileiUCvKoQPez2rJTrNtsFLRx4L7pxi/KVjt/K2wkAcA5q4v+1mLN6bKj?=
 =?us-ascii?Q?CIMoQbwOZD8Xs3T7YLr4z5Ylqoan3CayeL3XRTc9EymBPiO2kFr3YsGQheH/?=
 =?us-ascii?Q?5BzEIz7r21GhIwcym8BwJgx71kIn5ackdIqmWSvNgLBYbWvu+9xAjJWza9mH?=
 =?us-ascii?Q?k3dOOLLEBBqjg+roLI2Zp2bFMVkr05fO4ece8VY7je+Utak6gPfrOZ6DlAQp?=
 =?us-ascii?Q?OILR+RCi1t1G+bXoF4mjKIAQDG5Zp+b0PKtOWB2+ZjPcwj1mlzxY78RYY0CM?=
 =?us-ascii?Q?/z4Nvndyn4M0x/iTjOA36uDeInFBU0wtyYGIEtEmGBLd4zMTqV5iFFVkHOWh?=
 =?us-ascii?Q?+dssBjnRJRBAFFNMmCQay9fZzDBWJdS92ptqTXf1R1452qOvIZv7EGzsi+GJ?=
 =?us-ascii?Q?3m1m0sK6hcic+3VrFsZZKAlbeOKTFbuazWe9ok1vB9oucjwdbyGAZTASy7mR?=
 =?us-ascii?Q?/1z7ary5Cd2pzZIyX9u6wOS4KQKKHybIKuTAkDmzeVz2kykd72OqpCbAogZf?=
 =?us-ascii?Q?vQ7RS2EVFWNtTVrwNZpTFj5E3pyYRi6kDDaYoTBw?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 28d81a11-2c50-4c02-4236-08da9210c0fd
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2022 03:09:48.0989
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Co8Xw052x/UdDhrHTDw+p2Qjs6yugZ3t2NmtJrLH/9Ketln1y9wJ205QHmwLshYcUNPmA3CRnnsC1q/mgE0N/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6181
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Jason Gunthorpe
> Sent: Thursday, September 8, 2022 8:37 PM
>=20
> On Thu, Sep 08, 2022 at 11:39:07AM +0200, Eric Auger wrote:
>=20
> > >> I am not totally clear about remaining 'struct device *dev;' in
> > >> vfio_device struct. I see it used in some places. Is it supposed to
> > >> disappear at some point?
> > >
> > > no, Eric. *dev will not disappear, it stores the dev pointet passed i=
n by
> > > caller of vfio_init_device().
> >
> > yeah I see but you have device->device.parent =3D device->dev;
>=20
> IIRC we have a number of these redundancies now, often the drivers
> store another copy of the dev too.
>=20
> A significant use of dev is for printing things, what should be done
> here is to create a subsystem wide vfio_warn/etc that takes in the
> vfio_device, and then print properly from there. Now that we have a
> struct device all the prints should also include the VFIO struct
> device name, and then the PCI device perhaps in brackets.
>=20

Let me handle it in a separate patch (after this series).