Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762010AbXFRKx5 (ORCPT ); Mon, 18 Jun 2007 06:53:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760201AbXFRKxu (ORCPT ); Mon, 18 Jun 2007 06:53:50 -0400 Received: from pasmtpa.tele.dk ([80.160.77.114]:49816 "EHLO pasmtpA.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755657AbXFRKxt (ORCPT ); Mon, 18 Jun 2007 06:53:49 -0400 Date: Mon, 18 Jun 2007 12:54:52 +0200 From: Sam Ravnborg To: Satyam Sharma Cc: Yasunori Goto , Paul Mundt , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: More __meminit annotations. Message-ID: <20070618105452.GA22386@uranus.ravnborg.org> References: <20070618045229.GA31635@linux-sh.org> <20070618143943.B108.Y-GOTO@jp.fujitsu.com> <20070618074529.GA21222@uranus.ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 880 Lines: 21 > But then what > might happen is that everybody would think his particular use of inline > is correct and beneficial and all users of inline in kernel would end up > as __always_inline anyway. You miss that there is a big difference between "beneficial" and "needs". The latter is used when some assembly code has a specific knowlegde of how parameters are passed or that the function signature for other good reasons must not change. It has nothing to do with "beneficial". Any use of __always_inline outside arch/* is highly question able. And most use of *inline* in drivers/* today is due to bad behaving gcc in the past. Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/