Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp1465467rwn; Thu, 8 Sep 2022 21:21:15 -0700 (PDT) X-Google-Smtp-Source: AA6agR7sEvatO8pmiwPlSkZFjckC/QnwKVw0vbJN02N7lMBnZ3QKu7fWhRZnF6S6MDIS5Db3Yuoc X-Received: by 2002:a17:90b:1c07:b0:200:9728:b8cd with SMTP id oc7-20020a17090b1c0700b002009728b8cdmr7732241pjb.139.1662697275280; Thu, 08 Sep 2022 21:21:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662697275; cv=none; d=google.com; s=arc-20160816; b=wCj4KUzkRg998gtmYb3xDZYVin81/LNz47z2cHIJCIqpqBiYy2BocgZsF5IMFEAE11 M1ihWrt+M5PLBW17r/kcqstNWNi2YDPn25M6VnTUx1NdX8fjfkkMxBt1zCg41d4nFaxz Env+W/C7dzDyFj95dkaaVPM23MfSvmAEKENIYEoQjP4myNyBK3d1xqUZsy8wRzB0MLa3 bjCwBPSXMsoaTYDGATbjqWN1HquAHDgnm0yYoJ3AwdnCXDZAE2qL9jJostG9+CmlQAjh Eq1sVMhKPnaZzJ6QhzdCeP+wlIg3UqusP/BzT5DKzo/hD2UTYPW9K7+oCmyuX6DuhX4m OB0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=mTQeerp6vrMHbtmhw1xtF+7F71feU54gGWD+y0Ql+EQ=; b=NlRUnuwvmQSPzrY6dylXUeGZxCm/6H2yMVOso0hhlSKDBKFEJwR3Pb6L9l4w/PpnrW kpq5nBByMA6koKG5ec0qe6SEyYMCgaENM8uWSBcuODAGiFUC5UykvPwWB9HGKyEXQzEN SF++/3kCF743/B/MoVqVHpcpvKivdQ37fTtAdrh4pNEE5UPandvz2PkHOPWDy1pLAzXU 9ocnjB7IW9aMYw4VTr473kNxp0FyrtoR6nIeuyg+O+VPAwF6yd66kMct09WYr5gsMQw/ HPzJYPqoVnEIf1rriiJMUwhr6WY3ic2A8jpChRlgPNJFQJNqb6lWGROrdvd6Uof7kp5T TlyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ieUxokWw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e11-20020a63544b000000b004345da5a712si714320pgm.188.2022.09.08.21.21.03; Thu, 08 Sep 2022 21:21:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ieUxokWw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229897AbiIIERM (ORCPT + 99 others); Fri, 9 Sep 2022 00:17:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbiIIERK (ORCPT ); Fri, 9 Sep 2022 00:17:10 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB40F121129; Thu, 8 Sep 2022 21:17:07 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id x1-20020a17090ab00100b001fda21bbc90so4207950pjq.3; Thu, 08 Sep 2022 21:17:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=mTQeerp6vrMHbtmhw1xtF+7F71feU54gGWD+y0Ql+EQ=; b=ieUxokWwlpFX4V1oPWfeXKPgp9sMWrIi9HvmN+/guLJDZ+1MMEd2sQgtffkyE54x6M ECD7YfWvqIv1U9x5wrXaYnNZpZdAXGaGxePhcvgNo6q8Y3lS2e+0C+ikhetG5NLN2Ab0 GXHY/lXZvKyASTMh+3AMLdrawzTD2xjhnqYJurm6ZLEVpCcDBSOwnh4HRuGw5Tna4qZ/ RgyS7PS//xTPdKISycrzkiv4oL5TPkuZ39iu4MmfEKpkutbVUutdLQbdayCq25vqskMx XiTxDUmFqZWheepj6mPqgVYDBVo+BdJjrYhnu+/F6yoyBBKf5U+jEfJX6VmMvHRwoxdt HbSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=mTQeerp6vrMHbtmhw1xtF+7F71feU54gGWD+y0Ql+EQ=; b=NMG/+GvVrSopuPljIV5VuMBAPdgadErxYZ5uWRlVE2OCZDMIBNWMBiOpNrfaIRlhh9 cSkTIx1YhF2bvO0R6Fh0GADB0snKVsGSX/SVHaBgO6sz29YwCuhrv+ceFbdDMFva4sMs a0GcMQZyKJrxFsDHxcENAtjw1daJ5rhsJLeFHHPAdrzIU9fgLX2GlImByPqWinOqvfSb rHjVOIXxMURyTYHtiimHKbiiVRe4Azed+924uhEuSqXiiIWQjBhQqOnFGNKlbtUtf8nG BCyS6o1or4LHbbhm8kdWIUGxe/wG2wBrQau5l2T7zkX+lFkBz7WaGuoSxTDJwV0pWhcW RNlw== X-Gm-Message-State: ACgBeo3NUohefAntrHYsVfijB49h1oVQ+47QIMJqgW54KrqVDRxM25iY A8IhGZxC9CQE2OfLAdNvAF7iQwCOjEUx/Q== X-Received: by 2002:a17:90b:358e:b0:200:9d8a:7a70 with SMTP id mm14-20020a17090b358e00b002009d8a7a70mr7430140pjb.61.1662697027216; Thu, 08 Sep 2022 21:17:07 -0700 (PDT) Received: from localhost.localdomain (lily-optiplex-3070.dynamic.ucsd.edu. [2607:f720:1300:3033::1:4dd]) by smtp.googlemail.com with ESMTPSA id 201-20020a6217d2000000b0053e5daf1a25sm476194pfx.45.2022.09.08.21.17.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 21:17:06 -0700 (PDT) From: Li Zhong To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org Cc: pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, anthony.l.nguyen@intel.com, jesse.brandeburg@intel.com, Li Zhong Subject: [PATCH net-next v1] drivers/net/ethernet/intel/e100: check the return value of e100_exec_cmd() Date: Thu, 8 Sep 2022 21:16:45 -0700 Message-Id: <20220909041645.2612842-1-floridsleeves@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Check the return value of e100_exec_cmd() which could return error code when execution fails. Signed-off-by: Li Zhong --- drivers/net/ethernet/intel/e100.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c index 11a884aa5082..3b84745376fe 100644 --- a/drivers/net/ethernet/intel/e100.c +++ b/drivers/net/ethernet/intel/e100.c @@ -1911,7 +1911,8 @@ static inline void e100_start_receiver(struct nic *nic, struct rx *rx) /* (Re)start RU if suspended or idle and RFA is non-NULL */ if (rx->skb) { - e100_exec_cmd(nic, ruc_start, rx->dma_addr); + if (!e100_exec_cmd(nic, ruc_start, rx->dma_addr)) + return; nic->ru_running = RU_RUNNING; } } -- 2.25.1