Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762698AbXFRLB3 (ORCPT ); Mon, 18 Jun 2007 07:01:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760872AbXFRLBH (ORCPT ); Mon, 18 Jun 2007 07:01:07 -0400 Received: from postel.suug.ch ([194.88.212.233]:38333 "EHLO postel.suug.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760816AbXFRLBG (ORCPT ); Mon, 18 Jun 2007 07:01:06 -0400 Date: Mon, 18 Jun 2007 12:32:41 +0200 From: Thomas Graf To: Miklos Szeredi Cc: davem@davemloft.net, akpm@linux-foundation.org, viro@ftp.linux.org.uk, alan@lxorguk.ukuu.org.uk, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fix race in AF_UNIX Message-ID: <20070618103241.GX521@postel.suug.ch> References: <20070618.021813.105401188.davem@davemloft.net> <20070618.023520.102546505.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 930 Lines: 18 * Miklos Szeredi 2007-06-18 11:44 > Garbage collection only ever happens, if the app is sending AF_UNIX > sockets over AF_UNIX sockets. Which is a rather rare case. And which > is basically why this bug went unnoticed for so long. > > So my second patch only affects the performance of _exactly_ those > apps which might well be bitten by the bug itself. That's not entirely the truth. It affects all applications using AF_UNIX sockets while file descriptors are being transfered. I agree that the performance impact is not severe on most systems but if file descriptors are being transfered continously by just a single application it can become rather severe. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/