Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220909053038.33188-1-namcaov@gmail.com> <YxrTiN1OuJ2cbtrn@kroah.com>
In-Reply-To: <YxrTiN1OuJ2cbtrn@kroah.com>
From:   Nam Cao <namcaov@gmail.com>
Date:   Fri, 9 Sep 2022 08:01:29 +0200
Message-ID: <CA+sZ8B_VtmUWnvvfWBUV1WVq_=gRid+6ffGRQwdxp+9DYcLDtw@mail.gmail.com>
Subject: Re: [PATCH] staging: vt6655: fix potential memory conruption bug
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     forest@alittletooquiet.net, linux-kernel@vger.kernel.org,
        linux-staging@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Greg,

Just out of curiosity, how can we be sure that sizeof(unsigned int)
is never 8 bytes? The C standard doesn't say anything about this, as
far as I know.

Patch v2 will come later today or tomorrow.

Best regards,
Nam

On Fri, Sep 9, 2022 at 7:47 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> sizeof(unsigned int) is not going to be 8 bytes, so there's no memory
> issue here.  But your fix is good, so can you please just rewrite this
> to be "make it more obvious what is happening" type of patch?
>
> thanks,
>
> greg k-h