Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220908104337.11940-1-lukas.bulwahn@gmail.com>
 <20220908104337.11940-4-lukas.bulwahn@gmail.com> <20220908131303.1fe813cd@coco.lan>
 <20220908182050.7a1c46cd@coco.lan>
In-Reply-To: <20220908182050.7a1c46cd@coco.lan>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Fri, 9 Sep 2022 15:22:14 +0900
Message-ID: <CAK7LNARDY-XvbNbiHT8n4ztAv+Wh_ZZ1PLdbZZVBOuLVrmw5cQ@mail.gmail.com>
Subject: Re: [PATCH 3/6] media: remove reference to CONFIG_EMBEDDED in MEDIA_SUPPORT_FILTER
To:     Mauro Carvalho Chehab <mchehab@kernel.org>
Cc:     Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        X86 ML <x86@kernel.org>,
        Linux Media Mailing List <linux-media@vger.kernel.org>,
        Peter Chen <peter.chen@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb <linux-usb@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Mike Rapoport <rppt@linux.ibm.com>,
        Linux Memory Management List <linux-mm@kvack.org>,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        kernel-janitors@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Sep 9, 2022 at 1:20 AM Mauro Carvalho Chehab <mchehab@kernel.org> wrote:
>
> Em Thu, 8 Sep 2022 13:13:03 +0200
> Mauro Carvalho Chehab <mchehab@kernel.org> escreveu:
>
> > Em Thu,  8 Sep 2022 12:43:34 +0200
> > Lukas Bulwahn <lukas.bulwahn@gmail.com> escreveu:
> >
> > > The config EMBEDDED selects EXPERT, i.e., when EMBEDDED is enabled, EXPERT
> > > is usually also enabled. Hence, it sufficient to have the option
> > > MEDIA_SUPPORT_FILTER set to y if !EXPERT.
> > >
> > > This way, MEDIA_SUPPORT_FILTER does not refer to CONFIG_EMBEDDED anymore
> > > and allows us to remove CONFIG_EMBEDDED in the close future.
> > >
> > > Remove the reference to CONFIG_EMBEDDED in MEDIA_SUPPORT_FILTER.
> > >
> > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > > ---
> > >  drivers/media/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
> > > index ba6592b3dab2..283b78b5766e 100644
> > > --- a/drivers/media/Kconfig
> > > +++ b/drivers/media/Kconfig
> > > @@ -24,7 +24,7 @@ if MEDIA_SUPPORT
> > >
> > >  config MEDIA_SUPPORT_FILTER
> > >     bool "Filter media drivers"
> > > -   default y if !EMBEDDED && !EXPERT
> > > +   default y if !EXPERT
> > >     help
> > >        Configuring the media subsystem can be complex, as there are
> > >        hundreds of drivers and other config options.
> >
> > Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>
>
> As this is independent on the rest of the series, I just went ahead
> and merged it on media tree.
> >
> > Thanks,
> > Mauro
>
>
>
> Thanks,
> Mauro

Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>

-- 
Best Regards
Masahiro Yamada