Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Sep 2022 12:15:28 +0530
From:   "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
To:     Gaosheng Cui <cuigaosheng1@huawei.com>
Cc:     jack@suse.cz, amir73il@gmail.com, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fsnotify: remove unused declaration
Message-ID: <20220909064528.vbjafykgbm7kt35q@riteshh-domain>
References: <20220909033828.993889-1-cuigaosheng1@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220909033828.993889-1-cuigaosheng1@huawei.com>
Precedence: bulk

On 22/09/09 11:38AM, Gaosheng Cui wrote:
> fsnotify_alloc_event_holder() and fsnotify_destroy_event_holder()
> has been removed since commit 7053aee26a35 ("fsnotify: do not share
> events between notification groups"), so remove it.

It's a 2014 commit. Nice spotting. 
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>

> 
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> ---
>  fs/notify/fsnotify.h | 4 ----
>  1 file changed, 4 deletions(-)


> 
> diff --git a/fs/notify/fsnotify.h b/fs/notify/fsnotify.h
> index 87d8a50ee803..fde74eb333cc 100644
> --- a/fs/notify/fsnotify.h
> +++ b/fs/notify/fsnotify.h
> @@ -76,10 +76,6 @@ static inline void fsnotify_clear_marks_by_sb(struct super_block *sb)
>   */
>  extern void __fsnotify_update_child_dentry_flags(struct inode *inode);
>  
> -/* allocate and destroy and event holder to attach events to notification/access queues */
> -extern struct fsnotify_event_holder *fsnotify_alloc_event_holder(void);
> -extern void fsnotify_destroy_event_holder(struct fsnotify_event_holder *holder);
> -
>  extern struct kmem_cache *fsnotify_mark_connector_cachep;
>  
>  #endif	/* __FS_NOTIFY_FSNOTIFY_H_ */
> -- 
> 2.25.1
>