Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762909AbXFRLmh (ORCPT ); Mon, 18 Jun 2007 07:42:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761278AbXFRLm2 (ORCPT ); Mon, 18 Jun 2007 07:42:28 -0400 Received: from outpipe-village-512-1.bc.nu ([81.2.110.250]:40746 "EHLO the-village.bc.nu" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1754212AbXFRLm1 (ORCPT ); Mon, 18 Jun 2007 07:42:27 -0400 Date: Mon, 18 Jun 2007 12:47:21 +0100 From: Alan Cox To: Miklos Szeredi Cc: davem@davemloft.net, akpm@linux-foundation.org, viro@ftp.linux.org.uk, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fix race in AF_UNIX Message-ID: <20070618124721.56411b93@the-village.bc.nu> In-Reply-To: References: <20070618.005711.21897961.davem@davemloft.net> <20070618.021813.105401188.davem@davemloft.net> X-Mailer: Claws Mail 2.9.1 (GTK+ 2.10.8; i386-redhat-linux-gnu) Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a Lloegr o'r rhif cofrestru 3798903 Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1178 Lines: 28 > No, correctness always trumps performance. Lost packets on an AF_UNIX > socket are _unexceptable_, and this is definitely not a theoretical > problem. If its so unacceptable why has nobody noticed until now - its a bug clearly, it needs fixing clearly, but unless you can produce some kind of exploit from it (eg a DoS attack or kernel memory leak exploiter) it doesn't appear to be that serious. > And BTW my second patch does _not_ have the performance problems you > are arguing about, it's just plain ugly. But hey, if you can't live > with ugly code, go and fix it. If you put ugly code into the kernel you pay for maintaining it for years to come. If you get it right then you don't > Do you want me to send the patch to Andrew instead? His attitude > towards bugfixes is rather better ;) And it'll get NAKked and binned. DaveM is (as happens sometimes ;)) right to insist on the code being clean and efficient. Alan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/