Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Sep 2022 09:48:10 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     xkernel.wang@foxmail.com
Cc:     linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: rtl8723bs: fix potential memory leak in
 rtw_init_drv_sw()
Message-ID: <YxrvuoVF+IGfUikb@kroah.com>
References: <tencent_61623C1C5469E9DF0E448B5936B78E239C05@qq.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <tencent_61623C1C5469E9DF0E448B5936B78E239C05@qq.com>
Precedence: bulk

On Thu, Sep 08, 2022 at 03:31:25PM +0800, xkernel.wang@foxmail.com wrote:
> From: Xiaoke Wang <xkernel.wang@foxmail.com>
> 
> In rtw_init_drv_sw(), there are various init functions are called to 
> populate the padapter structure and some checks for their return value.
> However, except for the first one error path, the other five error paths 
> do not properly release the previous allocated resources, which leads to 

You have trailing whitespace on your text :(

> various memory leaks.
> 
> This patch fixes them and keeps the success and error separate. As there
> is no FooBar device to test with, no runtime testing was performed.

What do you mean by "FooBar"?  Please fix that up.

thanks,

greg k-h