Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Sep 2022 10:19:47 +0200
From:   Marco Elver <elver@google.com>
To:     Liu Shixin <liushixin2@huawei.com>
Cc:     Alexander Potapenko <glider@google.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        kasan-dev@googlegroups.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: Re: [PATCH] mm: kfence: convert to DEFINE_SEQ_ATTRIBUTE
Message-ID: <Yxr3I6Ru2WUGzEWn@elver.google.com>
References: <20220909083140.3592919-1-liushixin2@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220909083140.3592919-1-liushixin2@huawei.com>
User-Agent: Mutt/2.2.6 (2022-06-05)
Precedence: bulk

On Fri, Sep 09, 2022 at 04:31PM +0800, 'Liu Shixin' via kasan-dev wrote:
> Use DEFINE_SEQ_ATTRIBUTE helper macro to simplify the code.
> 
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>

Reviewed-by: Marco Elver <elver@google.com>
Tested-by: Marco Elver <elver@google.com>

> ---
>  mm/kfence/core.c | 15 ++-------------
>  1 file changed, 2 insertions(+), 13 deletions(-)
> 
> diff --git a/mm/kfence/core.c b/mm/kfence/core.c
> index 8c08ae2101d7..26de62a51665 100644
> --- a/mm/kfence/core.c
> +++ b/mm/kfence/core.c
> @@ -719,24 +719,13 @@ static int show_object(struct seq_file *seq, void *v)
>  	return 0;
>  }
>  
> -static const struct seq_operations object_seqops = {
> +static const struct seq_operations objects_sops = {
>  	.start = start_object,
>  	.next = next_object,
>  	.stop = stop_object,
>  	.show = show_object,
>  };
> -
> -static int open_objects(struct inode *inode, struct file *file)
> -{
> -	return seq_open(file, &object_seqops);
> -}
> -
> -static const struct file_operations objects_fops = {
> -	.open = open_objects,
> -	.read = seq_read,
> -	.llseek = seq_lseek,
> -	.release = seq_release,
> -};
> +DEFINE_SEQ_ATTRIBUTE(objects);
>  
>  static int __init kfence_debugfs_init(void)
>  {
> -- 
> 2.25.1