Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Sep 2022 11:42:01 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     Patrick Rudolph <patrick.rudolph@9elements.com>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] pinctrl: cy8c95x0: Use 'default' in all
 switch-cases (part 2)
Message-ID: <Yxr8WYfRT+XKEKGK@smile.fi.intel.com>
References: <20220908142134.59068-1-andriy.shevchenko@linux.intel.com>
 <CACRpkdYHWSc-kVUdr_YJ-YvMEc-LqrgDj0D62F2WKdA1H5Uvrw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CACRpkdYHWSc-kVUdr_YJ-YvMEc-LqrgDj0D62F2WKdA1H5Uvrw@mail.gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Fri, Sep 09, 2022 at 10:02:51AM +0200, Linus Walleij wrote:
> On Thu, Sep 8, 2022 at 4:21 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> 
> > Move the default values to the 'default' case in the switches.

> Patch applied!

Thanks!

...

> >         case CY8C95X0_DRV_PP_SLOW:
> >         case CY8C95X0_DRV_HIZ:
> >                 return true;
> > +       default:
> > +               return false;
> >         }
> > -
> > -       return false;
> 
> Clearly this is better style, I wonder if we could teach checkpatch to
> look for this? Or cocinelle?

The latter I believe. But I'm too busy and too lazy to go that road.

-- 
With Best Regards,
Andy Shevchenko