Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp1662244rwn; Fri, 9 Sep 2022 01:55:14 -0700 (PDT) X-Google-Smtp-Source: AA6agR76eqkFnPe3ecP2D7k2d1h+/3jZ/eAp8SuYvtDcOBoPTGIwyodRTmBz7ZpYZsWVgYbDUR+e X-Received: by 2002:a17:90a:9409:b0:200:52d9:660d with SMTP id r9-20020a17090a940900b0020052d9660dmr8375107pjo.62.1662713714514; Fri, 09 Sep 2022 01:55:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662713714; cv=none; d=google.com; s=arc-20160816; b=VtlO7JBpLCaBECRUfTHafl5OiqIFaIa/X18m8Mv8aumHn70tGIozmpp7elY81Z46KX JRCY5uEWX0XrBCoca2u/ZtOhtw2cxqFyObAw2/lJEmRpgzMuXzcyoQUSbXFFjuB/fjiy dtNa/L94jiVyEAcPyvklV3xcX/TmVowGUB6zDeKqsLZUIYHD4SgivfrCeLUd6swV9MJA qZvL/OVu4xrtSZPZm7jeEC7E7T/zcvxba5r8DBB2eGWiqQyE9q+tHhJ+KRGiBLDiY7Nf eUar/bbkMNauzsSs9IznHKQ0/TqaF3GbWsoZ891vQlEkHFjnkx0Zd9l6wD4UzQTUBglR d+aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=NQ9A54Z8CrY5jmH+r9/WMnhPXv0fZegOM1GsxMLYivs=; b=dqEF+n+oeNEAA3hQoKoAzHlaNbKlg90FS+rgrdjJNTOP3+RsfROvgpBvGrUMEW8b/h vaMzB7yZz93ywT5CtZMytzF+3X0nNJQ3YTKtPUedCnxlnA+81HMBhlBw8nTeLV5lSFdF a1+DFxRL13qLu9dAPuOdKG45/0dPnmm5uBARIU50+/qbZZtRVF7+mWFMWgmI7l12KdH9 XcBBxodJan9/ZLwh1C0z63k+eJmBj9imbO2D++mNHfq5TmOSYNdhylSURl5WS/L57tLx XXFMaolCIzXb3Ry3JsHXdOvlmbppngN1TbZO3r5ofrFPe1Ck9VPszuFrx/xy1UAjisAA XskQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=fsuGRjKJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f2-20020a170902ce8200b00174a7230e39si1511724plg.329.2022.09.09.01.55.02; Fri, 09 Sep 2022 01:55:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=fsuGRjKJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231281AbiIIIuq (ORCPT + 99 others); Fri, 9 Sep 2022 04:50:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229899AbiIIIun (ORCPT ); Fri, 9 Sep 2022 04:50:43 -0400 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4BD512B341 for ; Fri, 9 Sep 2022 01:50:42 -0700 (PDT) Received: by mail-pg1-x536.google.com with SMTP id g4so986520pgc.0 for ; Fri, 09 Sep 2022 01:50:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=NQ9A54Z8CrY5jmH+r9/WMnhPXv0fZegOM1GsxMLYivs=; b=fsuGRjKJLd6qfgSCuLuq3Lt6Y3e0yzujg28kWkL6OWPHdyEsFnzJfcfEuOvjIkg4ne tmnlQNnKoUdM46/oEukw1eYmkfgIP8rfXe9G1RJV6K2CN6FamgH+UuGDEYv9LUalZ9Yp WTc0KOpfouqx7byOabYsqG+/ARlXvXQ4Cgjc8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=NQ9A54Z8CrY5jmH+r9/WMnhPXv0fZegOM1GsxMLYivs=; b=jWbr0HuLyjPjkbfjaZY5hgNnyrt58IhpzrF8qcxoKz/RyAaUdYR8T2hYBdJDnQb1yw ONCGuE1JziaqW/Qv/QA8xPkbceBUL4UJBB66usv+pMbe8TDpfEZbykIzbhNxH5aZssgt jU6qcL9fcDqL8/hpQgjYexhuHZWTfCdwv2UPYR5TLdh5mP0eYYAPcO9WYVDH7mZ9ccBU RiLzAnDnr4sPqkp2sZp0uhz39fGRgYYqlTuwCh9BBwjv1pZj98RJ4xP9sExFNwHZ89oc Y6svA+VtUkrb5E7GeiYjcEX9nf/4f2A8Fp2x9drCKLbFO8urSS3Mypzf3cPuZ3hVP7Gq 2ETg== X-Gm-Message-State: ACgBeo3ZaVRf6JJOc1N7OJx6RtSPhN+d6b1d/7WBBW3wSgnktqP72N3T 0Z6pnrDAy4b79dggjNo+1bKVHA== X-Received: by 2002:a63:6b05:0:b0:41c:2216:d2b2 with SMTP id g5-20020a636b05000000b0041c2216d2b2mr11697974pgc.118.1662713442523; Fri, 09 Sep 2022 01:50:42 -0700 (PDT) Received: from google.com ([240f:75:7537:3187:48ca:975b:3395:bf]) by smtp.gmail.com with ESMTPSA id b2-20020a636702000000b0041cd2417c66sm796886pgc.18.2022.09.09.01.50.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Sep 2022 01:50:41 -0700 (PDT) Date: Fri, 9 Sep 2022 17:50:36 +0900 From: Sergey Senozhatsky To: Alexey Romanov Cc: minchan@kernel.org, senozhatsky@chromium.org, ngupta@vflare.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel@sberdevices.ru Subject: Re: [PATCH v1] zsmalloc: use correct types in _first_obj_offset functions Message-ID: References: <20220909083722.85024-1-avromanov@sberdevices.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220909083722.85024-1-avromanov@sberdevices.ru> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (22/09/09 11:37), Alexey Romanov wrote: > Since commit ffedd09fa9b0 > ("zsmalloc: Stop using slab fields in struct page") we are using > page->page_type (unsigned int) field instead of page->units (int) > as first object offset in a subpage of zspage. So get_first_obj_offset() > and set_first_obj_offset() functions should work with unsigned int type. > > Fixes: ffedd09fa9b0 ("zsmalloc: Stop using slab fields in struct page") > Signed-off-by: Alexey Romanov Reviewed-by: Sergey Senozhatsky