Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Sep 2022 11:36:34 +0200
From:   Jan Kara <jack@suse.cz>
To:     Miaohe Lin <linmiaohe@huawei.com>
Cc:     axboe@kernel.dk, dhowells@redhat.com, vbabka@suse.cz,
        willy@infradead.org, akpm@linux-foundation.org,
        zhanglianjie@uniontech.com, neilb@suse.de, jack@suse.cz,
        bvanassche@acm.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] writeback: remove unused macro DIRTY_FULL_SCOPE
Message-ID: <20220909093634.od4aukp2oumgflcc@quack3>
References: <20220909025711.32012-1-linmiaohe@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220909025711.32012-1-linmiaohe@huawei.com>
Precedence: bulk

On Fri 09-09-22 10:57:11, Miaohe Lin wrote:
> It's introduced but never used. Remove it.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  include/linux/writeback.h | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/include/linux/writeback.h b/include/linux/writeback.h
> index 3f045f6d6c4f..06f9291b6fd5 100644
> --- a/include/linux/writeback.h
> +++ b/include/linux/writeback.h
> @@ -17,20 +17,12 @@ struct bio;
>  DECLARE_PER_CPU(int, dirty_throttle_leaks);
>  
>  /*
> - * The 1/4 region under the global dirty thresh is for smooth dirty throttling:
> - *
> - *	(thresh - thresh/DIRTY_FULL_SCOPE, thresh)
> - *
> - * Further beyond, all dirtier tasks will enter a loop waiting (possibly long
> - * time) for the dirty pages to drop, unless written enough pages.
> - *
>   * The global dirty threshold is normally equal to the global dirty limit,
>   * except when the system suddenly allocates a lot of anonymous memory and
>   * knocks down the global dirty threshold quickly, in which case the global
>   * dirty limit will follow down slowly to prevent livelocking all dirtier tasks.
>   */
>  #define DIRTY_SCOPE		8
> -#define DIRTY_FULL_SCOPE	(DIRTY_SCOPE / 2)
>  
>  struct backing_dev_info;
>  
> -- 
> 2.23.0
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR