Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Sep 2022 12:20:19 +0200
From:   Lorenzo Pieralisi <lpieralisi@kernel.org>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc:     Kishon Vijay Abraham I <kishon@ti.com>, bhelgaas@google.com,
        kw@linux.com, robh@kernel.org, vidyas@nvidia.com,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] PCI: endpoint: Use link_up() callback in place of
 LINK_UP notifier
Message-ID: <YxsTYzGkfzFiBIsq@lpieralisi>
References: <20220811094237.77632-1-manivannan.sadhasivam@linaro.org>
 <20220811094237.77632-3-manivannan.sadhasivam@linaro.org>
 <c200a544-31fe-b660-82bb-4bbed5acf135@ti.com>
 <20220831082025.GC5076@thinkpad>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220831082025.GC5076@thinkpad>
Precedence: bulk

On Wed, Aug 31, 2022 at 01:50:25PM +0530, Manivannan Sadhasivam wrote:
> On Thu, Aug 25, 2022 at 03:47:10PM +0530, Kishon Vijay Abraham I wrote:
> > Hi Mani,
> > 
> > On 11/08/22 15:12, Manivannan Sadhasivam wrote:
> > > As a part of the transition towards callback mechanism for signalling the
> > > events from EPC to EPF, let's use the link_up() callback in the place of
> > > the LINK_UP notifier. This also removes the notifier support completely
> > > from the PCI endpoint framework.
> > > 
> > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > > ---
> > >  drivers/pci/endpoint/functions/pci-epf-test.c | 33 ++++++-------------
> > >  drivers/pci/endpoint/pci-epc-core.c           |  8 +++--
> > >  include/linux/pci-epc.h                       |  8 -----
> > >  include/linux/pci-epf.h                       |  8 ++---
> > >  4 files changed, 18 insertions(+), 39 deletions(-)
> > > 
> > 
> > .
> > .
> > <snip>
> > .
> > .
> > > diff --git a/drivers/pci/endpoint/pci-epc-core.c b/drivers/pci/endpoint/pci-epc-core.c
> > > index 805f3d64f93b..a51ba9f158c3 100644
> > > --- a/drivers/pci/endpoint/pci-epc-core.c
> > > +++ b/drivers/pci/endpoint/pci-epc-core.c
> > > @@ -690,10 +690,15 @@ EXPORT_SYMBOL_GPL(pci_epc_remove_epf);
> > >   */
> > >  void pci_epc_linkup(struct pci_epc *epc)
> > >  {
> > > +	struct pci_epf *epf;
> > > +
> > >  	if (!epc || IS_ERR(epc))
> > >  		return;
> > >  
> > > -	atomic_notifier_call_chain(&epc->notifier, LINK_UP, NULL);
> > > +	list_for_each_entry(epf, &epc->pci_epf, list) {
> > > +		if (epf->event_ops->link_up)
> > > +			epf->event_ops->link_up(epf);
> > > +	}
> > 
> > how do you ensure there is no race while invoking the call back
> > functions during add/remove of epf?
> > 
> 
> Good catch! These should be guarded by epf->lock.

I shall wait for v2 then and mark this one as "Changes requested".

Lorenzo