Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp1836246rwn; Fri, 9 Sep 2022 05:00:55 -0700 (PDT) X-Google-Smtp-Source: AA6agR58YzM+aZYdiaHl8EMa3NBabS37WXaScad2TbN9WYqdAJ7rVselL0WXwfH5CtdTvOAvY/gE X-Received: by 2002:a63:688:0:b0:435:41f0:258d with SMTP id 130-20020a630688000000b0043541f0258dmr8114437pgg.135.1662724855029; Fri, 09 Sep 2022 05:00:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662724855; cv=none; d=google.com; s=arc-20160816; b=j1msrT8hss9E39JbqxhScarffpzCsJsHqreFxUZhuj/uV++XtQViUTvaPZYUnhtAKP lILl3R03iP2qhaeL8py9dPmldMe9CDTS+S1/dYcUFNvJyWlNw+0f/JMam5AefDzg99qQ KsGTGV3fPCYCe8OgGp8BXe4kuADfy6dKw7x84XIoh8J0TRedgQNlVOXABUy083Hx9nrP 60QScCfLtXzkotwXyyEncVEBD6XXlNogS2smiOWkREDx26fKrv/iWml9/Jtwlv4k275D TWLJppuQRwwUbgC1g6uWDcLqY7zJ9jnNxYR2qIgAZ/Vll2Ex0OzfRhssRgGfje2R5gtl aUMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=7Jo9u7GazJ+NBxWj7pityHgzrKi8PfZunYuslMS0vVc=; b=jxWa5v8d8IAWI1g3I6XBEsf25PBLG1Njk347sImJMY1Sc1DQM2+ylsPJmhHVYXDFHM yD3eQUaY9kFLe09HSH0bKA35aajthm2h1Qj/8P3sfu8PnMgIhiubTtzGOlCBuStUTYCn FhLVslNzVV1vZM/J0c1SDrk2/2se9nMy6l3OYfXq+ladIAk1ZHkB+9e63fABmQW5MvAW PquwxROnS3i0vhTXJ0J1s35lhRnosW9r0z5gMOXxKSNMGGGcgh/t5qlpnbunJK5Eg98M 7QuDeVSl0/Q8uYWh0Ca/juW/vGJt5g/OIY9LgkMcQrY0Yn0JAis+zvQnrH8FTVGYjQkR 1oIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=NTTtBLGG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g5-20020a056a0023c500b0052b2d61f2c8si364007pfc.293.2022.09.09.05.00.41; Fri, 09 Sep 2022 05:00:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=NTTtBLGG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230208AbiIILaB (ORCPT + 99 others); Fri, 9 Sep 2022 07:30:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230167AbiIIL36 (ORCPT ); Fri, 9 Sep 2022 07:29:58 -0400 Received: from mail-yw1-x1136.google.com (mail-yw1-x1136.google.com [IPv6:2607:f8b0:4864:20::1136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F722DED for ; Fri, 9 Sep 2022 04:29:56 -0700 (PDT) Received: by mail-yw1-x1136.google.com with SMTP id 00721157ae682-3487d84e477so15355597b3.6 for ; Fri, 09 Sep 2022 04:29:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=7Jo9u7GazJ+NBxWj7pityHgzrKi8PfZunYuslMS0vVc=; b=NTTtBLGGL2eNQYdTb+zzpdTYz91YLvxK1ithhO8wg2x7oYFaEm66B2BmGfm/Y8U+43 in5FuyQwSxzoUECDy0A8wniORIB7Awd3F8wh0EBJ9IUIN+IH9E8pOEPAZ7yb1akOue3R UJFHD7AUv1dkh3xKoBLX8TTL5/MkfJlO4Vc2m1FwXPcE1j0uEHWFL/0DSJAVgDde2vzQ jgBbWqi+zWSGenExXq6eY++zOJ7QKoHPQg6OrKjnEjW70uT9zuU2R33rPhTKiDUCPTYy cbMUg+9qN7U/LaBC0WyxKja1f3v5YqcVpIoPhjM+0RUr3wfnv/1zBom8ERWDJPIq+dwt cK7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=7Jo9u7GazJ+NBxWj7pityHgzrKi8PfZunYuslMS0vVc=; b=r1MGYv3fpl2WeCjc31lxw3KFxxaOgo1Gq+lOHX6bZY0rXE8eg5bKBpQNcM+UOqLYyu 9x/YTGlOvziN4XWo8vccNaaGqn0B614nW1j+zGTUeRsC5TZbaEZeRZYyHGxzkUoaQUUm zf40SRyoLkCtjZT+dgy60hIYtqUPa3z0HwpAjIVSxKk5xWSc5YRSLEBoZdGCAmqSUZno mmQwiHYrEJ8RblYE8osSAmxd3/mnMTepr42tRGXHEUSJ1GGx7c3zKZBcDX6uw6rjcVQC KWuYJZRSmXdjmsi24BBuHiBqAuwG3BWq7jTzBvXAWhBJrBvbZgUE1+NFM0o8O9bPI3OE d39A== X-Gm-Message-State: ACgBeo2r4vj9YG+UJiGptuKKvB8c31uoGCwHLTSubjveN7hYV3xLrBo+ NDteJRLT/PBRZHuAuH4Wfqqi0loNDS9J78DC154= X-Received: by 2002:a0d:ee01:0:b0:324:d943:19dc with SMTP id x1-20020a0dee01000000b00324d94319dcmr10912160ywe.325.1662722995847; Fri, 09 Sep 2022 04:29:55 -0700 (PDT) MIME-Version: 1.0 References: <20220909090856.18427-1-namcaov@gmail.com> In-Reply-To: From: Nam Cao Date: Fri, 9 Sep 2022 13:29:44 +0200 Message-ID: Subject: Re: [PATCH v2] staging: vt6655: use memset to make code clearer To: Greg KH Cc: forest@alittletooquiet.net, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 9, 2022 at 12:23 PM Greg KH wrote: > Why do you have to cast this to (void *)? That should almost never be > needed. Because I want to suppress a compiler warning: drivers/staging/vt6655/device_main.c:869:9: warning: passing argument 1 of =E2=80=98memset=E2=80=99 discards =E2=80=98volatile=E2=80=99 qualifier= from pointer target type [-Wdiscarded-qualifiers] 869 | memset(&rd->rd0, 0, sizeof(rd->rd0)); | ^~~~~~~~ Best regards, Nam