Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Sep 2022 11:52:28 +0200
From:   Claudio Imbrenda <imbrenda@linux.ibm.com>
To:     Matthew Rosato <mjrosato@linux.ibm.com>
Cc:     linux-s390@vger.kernel.org, nrb@linux.ibm.com,
        pmorel@linux.ibm.com, schnelle@linux.ibm.com, farman@linux.ibm.com,
        borntraeger@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com,
        agordeev@linux.ibm.com, svens@linux.ibm.com, frankja@linux.ibm.com,
        david@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: s390: pci: fix GAIT physical vs virtual pointers
 usage
Message-ID: <20220909115228.0399098f@p-imbrenda>
In-Reply-To: <20220907155952.87356-1-mjrosato@linux.ibm.com>
References: <20220907155952.87356-1-mjrosato@linux.ibm.com>
Organization: IBM
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed,  7 Sep 2022 11:59:52 -0400
Matthew Rosato <mjrosato@linux.ibm.com> wrote:

> The GAIT and all of its entries must be represented by physical
> addresses as this structure is shared with underlying firmware.
> We can keep a virtual address of the GAIT origin in order to
> handle processing in the kernel, but when traversing the entries
> we must again convert the physical AISB stored in that GAIT entry
> into a virtual address in order to process it.
> 
> Note: this currently doesn't fix a real bug, since virtual addresses
> are indentical to physical ones.
> 
> Reviewed-by: Pierre Morel <pmorel@linux.ibm.com>
> Acked-by: Nico Boehr <nrb@linux.ibm.com>
> Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>

Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>

> ---
>  arch/s390/kvm/interrupt.c | 2 +-
>  arch/s390/kvm/pci.c       | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
> index b9c944b262c7..ab569faf0df2 100644
> --- a/arch/s390/kvm/interrupt.c
> +++ b/arch/s390/kvm/interrupt.c
> @@ -3324,7 +3324,7 @@ static void aen_host_forward(unsigned long si)
>  	if (gaite->count == 0)
>  		return;
>  	if (gaite->aisb != 0)
> -		set_bit_inv(gaite->aisbo, (unsigned long *)gaite->aisb);
> +		set_bit_inv(gaite->aisbo, phys_to_virt(gaite->aisb));
>  
>  	kvm = kvm_s390_pci_si_to_kvm(aift, si);
>  	if (!kvm)
> diff --git a/arch/s390/kvm/pci.c b/arch/s390/kvm/pci.c
> index bb8c335d17b9..8cfa0b03ebbb 100644
> --- a/arch/s390/kvm/pci.c
> +++ b/arch/s390/kvm/pci.c
> @@ -71,7 +71,7 @@ static int zpci_setup_aipb(u8 nisc)
>  		rc = -ENOMEM;
>  		goto free_sbv;
>  	}
> -	aift->gait = (struct zpci_gaite *)page_to_phys(page);
> +	aift->gait = (struct zpci_gaite *)page_to_virt(page);
>  
>  	zpci_aipb->aipb.faisb = virt_to_phys(aift->sbv->vector);
>  	zpci_aipb->aipb.gait = virt_to_phys(aift->gait);