Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp1866848rwn; Fri, 9 Sep 2022 05:24:33 -0700 (PDT) X-Google-Smtp-Source: AA6agR5G1kHd/pm0lWLs3CPNSwTCZfI6YTSDtApt4c7rPzMBOKNm15D0MGsVpFzXHuiEH32y5zp5 X-Received: by 2002:aa7:c956:0:b0:43b:206d:c283 with SMTP id h22-20020aa7c956000000b0043b206dc283mr11145999edt.381.1662726273207; Fri, 09 Sep 2022 05:24:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662726273; cv=none; d=google.com; s=arc-20160816; b=FDGpIFh6qdKsYtj/ZZrSNi87wTq1/5EFGoAFN8+6NADZoESQCFUIqHKdOeIo1MQQSb zEsGQqvllcj2fOVPT6fbpKyrsBx/CzKhbnDSrAZySE8vBtkgO6yF5rAJbxD9fEkf80L3 T1kHNnGd0of3qIzmJIhoeP2ydjBXaf6AsX97hQxjkUY9ezgYftbyT9MnYTxFZLNDJQJv FycufGW1FJ3NGu3KepiS0WW4Dnjnb+S9XJLTmoxvuMVQqqrR1/mk6PXhq21WKLRlbiWm 1yb+U0SqBU0uVSa6HU19t3xOWV76x3pQkJRdDBZB0RfU5EH5qrelx2wKQb7dY0LRsCNK 6f4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from; bh=aRcQW5v1fNsrom955qZ0GlVvmwqeKdYPL3yOUxOs4zw=; b=hW86g7sVrtgtXPhY5XK8Cu7Xr8wN1ntvDMvEtogyKjFS/xV1f7cYMFA0cntH47SjE3 BayIWNmK39bDslirjwzezmx2watIeTdrYW5Arcbhez/HLaAq9WeBHAYtxFmApsHR5X/J AzAVi+Q5dNVQqn3hRTlH9dE/FNAUrTloQ0E8DIHAWScV9CBBmkgBuB56P8epMR3jH9rb X5ABC1HXMNXCYQdyH4azpQhbv8XLd/nyhs2Ux5nvBg6OVw/QjuI7MjQOb5bt7hB8t2lY FZQppQWvMy+qJ5yHX24UMa6Wes+D/Vm3qmr88zt1in+ORGsgMZRRSX7RRCcYKY2tTEHe 3jFQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nc5-20020a1709071c0500b00730a3b5af1fsi66621ejc.338.2022.09.09.05.24.06; Fri, 09 Sep 2022 05:24:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230212AbiIIMMF (ORCPT + 99 others); Fri, 9 Sep 2022 08:12:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230467AbiIIMKx (ORCPT ); Fri, 9 Sep 2022 08:10:53 -0400 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 488D613813F for ; Fri, 9 Sep 2022 05:10:20 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4MPFDq68V6z4xcg; Fri, 9 Sep 2022 22:10:19 +1000 (AEST) From: Michael Ellerman To: agust@denx.de, paulus@samba.org, christophe.leroy@csgroup.eu, Liang He , maz@kernel.org, benh@kernel.crashing.org, wangqing@vivo.com, mpe@ellerman.id.au Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org In-Reply-To: <20220616144007.3987743-1-windhl@126.com> References: <20220616144007.3987743-1-windhl@126.com> Subject: Re: [PATCH] powerpc: platforms: 52xx: Fix refcount leak in media5200.c Message-Id: <166272522307.2076816.4288363534230982761.b4-ty@ellerman.id.au> Date: Fri, 09 Sep 2022 22:07:03 +1000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Jun 2022 22:40:07 +0800, Liang He wrote: > In media5200_init_irq(), of_find_compatible_node() will return a > node pointer with refcount incremented. We should use of_node_put() > in fail path or when it is not used anymore. > > Don't worry about 'fpga_np==NULL' as of_node_put() can correctly > handle it. > > [...] Applied to powerpc/next. [1/1] powerpc: platforms: 52xx: Fix refcount leak in media5200.c https://git.kernel.org/powerpc/c/593d7b89c6a2bf7aea2324c94f10ef3c21308418 cheers