Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6c073c53-a8ed-7654-4fdc-460015a60537@ideasonboard.com>
Date:   Fri, 9 Sep 2022 15:58:06 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] drm: omapdrm: dss: replace ternary operator with max()
Content-Language: en-US
To:     Guo Zhengkui <guozhengkui@vivo.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Benoit Parrot <bparrot@ti.com>,
        Cai Huoqing <cai.huoqing@linux.dev>,
        Arnd Bergmann <arnd@arndb.de>,
        "open list:DRM DRIVERS FOR TI OMAP" <dri-devel@lists.freedesktop.org>,
        open list <linux-kernel@vger.kernel.org>
Cc:     zhengkui_guo@outlook.com
References: <20220517050208.121488-1-guozhengkui@vivo.com>
From:   Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
In-Reply-To: <20220517050208.121488-1-guozhengkui@vivo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 17/05/2022 08:02, Guo Zhengkui wrote:
> Fix the following coccicheck warning:
> 
> drivers/gpu/drm/omapdrm/dss/dispc.c:2454:21-22: WARNING opportunity for max()
> 
> Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
> ---
>   drivers/gpu/drm/omapdrm/dss/dispc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/dispc.c b/drivers/gpu/drm/omapdrm/dss/dispc.c
> index c4de142cc85b..0ee344ebcd1c 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dispc.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dispc.c
> @@ -2451,7 +2451,7 @@ static int dispc_ovl_calc_scaling_44xx(struct dispc_device *dispc,
>   
>   	*decim_x = DIV_ROUND_UP(width, in_width_max);
>   
> -	*decim_x = *decim_x > decim_x_min ? *decim_x : decim_x_min;
> +	*decim_x = max(*decim_x, decim_x_min);
>   	if (*decim_x > *x_predecim)
>   		return -EINVAL;
>   

Thanks, applying to drm-misc.

  Tomi