Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Sep 2022 10:46:00 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     James Clark <james.clark@arm.com>
Cc:     Gaosheng Cui <cuigaosheng1@huawei.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, jolsa@kernel.org,
        namhyung@kernel.org, atrajeev@linux.vnet.ibm.com,
        eranian@google.com
Subject: Re: [PATCH 2/2] perf tools: remove perf_pmu_lex declaration
Message-ID: <YxtDmJWVx05Pmwwl@kernel.org>
References: <20220909044542.1087870-1-cuigaosheng1@huawei.com>
 <20220909044542.1087870-3-cuigaosheng1@huawei.com>
 <50fba997-d8c1-257b-fd11-db2bb1e53f70@arm.com>
 <YxtDGLZwi2Cu2U+p@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YxtDGLZwi2Cu2U+p@kernel.org>
Precedence: bulk

Em Fri, Sep 09, 2022 at 10:43:52AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Sep 09, 2022 at 11:29:43AM +0100, James Clark escreveu:
> > 
> > 
> > On 09/09/2022 05:45, Gaosheng Cui wrote:
> > > perf_pmu_lex has been removed since
> > > commit 65f3e56e0c81 ("perf tools: Remove auto-generated bison/flex files"),
> > > so remove it.
> > 
> > Not 100% sure if that is the right commit to reference because it didn't
> > touch pmu.y.
> 
> Yeah, indeed, unsure if at that time the declaration was needed.
>  
> > perf_pmu_lex is still used and there are plenty of references to it, but
> > maybe the extern declaration isn't needed anymore because it still
> > builds for me with this change.
> 
> Ditto here, I'll remove the reference and rewrite the cset log a bit.

I left it as:

perf pmu: Remove perf_pmu_lex() needless declaration

It builds without it, perhaps with some older combination of flex/bison
we needed this, clean it up a bit removing this.