Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220829131502.165356-1-yukuai1@huaweicloud.com>
 <CAPhsuW6pKMeaULJajDGSjDRVmBUDEd=QQdGftK_Oo0vgsEuKVg@mail.gmail.com> <3e9385af-b02c-e886-bc4b-d85cb4f447af@huaweicloud.com>
In-Reply-To: <3e9385af-b02c-e886-bc4b-d85cb4f447af@huaweicloud.com>
From:   Song Liu <song@kernel.org>
Date:   Fri, 9 Sep 2022 07:45:47 -0700
Message-ID: <CAPhsuW4aOfOjnUx39k4YHcZrNck-WGax1z4qdb61koE0ZugAEA@mail.gmail.com>
Subject: Re: [PATCH -next 0/3] md/raid10: reduce lock contention for io
To:     Yu Kuai <yukuai1@huaweicloud.com>
Cc:     linux-raid <linux-raid@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>, yi.zhang@huawei.com,
        "yukuai (C)" <yukuai3@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Sep 2, 2022 at 11:08 PM Yu Kuai <yukuai1@huaweicloud.com> wrote:
>
> Hi, Song
>
> =E5=9C=A8 2022/09/01 2:00, Song Liu =E5=86=99=E9=81=93:
> > On Mon, Aug 29, 2022 at 6:03 AM Yu Kuai <yukuai1@huaweicloud.com> wrote=
:
> >>
> >> From: Yu Kuai <yukuai3@huawei.com>
> >>
> >> patch 1 is a small problem found by code review.
> >> patch 2 avoid holding resync_lock in fast path.
> >> patch 3 avoid holding lock in wake_up() in fast path.
> >>
> >> Test environment:
> >>
> >> Architecture: aarch64
> >> Cpu: Huawei KUNPENG 920, there are four numa nodes
> >>
> >> Raid10 initialize:
> >> mdadm --create /dev/md0 --level 10 --bitmap none --raid-devices 4 /dev=
/nvme0n1 /dev/nvme1n1 /dev/nvme2n1 /dev/nvme3n1
> >>
> >> Test cmd:
> >> fio -name=3D0 -ioengine=3Dlibaio -direct=3D1 -group_reporting=3D1 -ran=
dseed=3D2022 -rwmixread=3D70 -refill_buffers -filename=3D/dev/md0 -numjobs=
=3D16 -runtime=3D60s -bs=3D4k -iodepth=3D256 -rw=3Drandread
> >>
> >> Test result:
> >> before this patchset:   2.9 GiB/s
> >> after this patchset:    6.6 Gib/s
> >
> > Nice work! Applied to md-next.
>
> Can you drop this version? There are something to improve. I can send a
> new version.

Sure, I will drop it from md-next.

Song