Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Petlozu Pravareshwar <petlozup@nvidia.com>
To:     Thierry Reding <thierry.reding@gmail.com>
CC:     Jonathan Hunter <jonathanh@nvidia.com>,
        "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
        "dmitry.osipenko@collabora.com" <dmitry.osipenko@collabora.com>,
        "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
        "Kartik ." <kkartik@nvidia.com>,
        "cai.huoqing@linux.dev" <cai.huoqing@linux.dev>,
        Sandipan Patra <spatra@nvidia.com>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] soc/tegra: pmc: Print reset info during probe
Thread-Topic: [PATCH] soc/tegra: pmc: Print reset info during probe
Thread-Index: AQHYsmmGR8fp18152ESxKlaB5UYTsq20xbIAgAm3/4CAAuglgIAV4rHQ
Date:   Fri, 9 Sep 2022 14:16:00 +0000
Message-ID: <DM6PR12MB316490295E5380D548396C39B5439@DM6PR12MB3164.namprd12.prod.outlook.com>
References: <20220817184456.1184459-1-petlozup@nvidia.com>
 <Yv5XarzacTOkTL1k@orome>
 <DM6PR12MB316434A9BA61A01251E3BA3CB5739@DM6PR12MB3164.namprd12.prod.outlook.com>
 <Ywjuuw/rSRUSORFF@orome>
In-Reply-To: <Ywjuuw/rSRUSORFF@orome>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?67s91SXdSdZSLrU1mxd++Pg8dd48u0vtfVmGdUbcQFMzYkrBKHLr0/xgMlub?=
 =?us-ascii?Q?wlGK2YdRfoaE4ENbqj2xiyyR51TkuAm17i0aQUDsWWk+BllaGfALlw13Uo+R?=
 =?us-ascii?Q?z7XNpDC/4r1EZDrLH79N1hFFwY/PLG4j9DR1ghZxcLlO64aaoMmgZhdnKERH?=
 =?us-ascii?Q?+9CFN2OqmIZ/s/nKCfwKDgbYWHHc+OrWJW3ks+MONubVzw9eKRqwV5j69Yct?=
 =?us-ascii?Q?nSB0DDktGkLitLJ+HtaR13cpD48NGwq638ivnQviSbQKM8ZWFpMum+6fUCZ/?=
 =?us-ascii?Q?ljLNRnLZIujuoTfsk9J08HXU885EQQidayuyyR5jkHE5FyF/2RBxzhDkhUsu?=
 =?us-ascii?Q?YeZJVEsRlHdiYKKw5JZwV97FnJg91NNR4ljeNFAZzLQWWujY/7NifuMh9MDs?=
 =?us-ascii?Q?BLAep23tI7anCIShDcAO6hTqRn/j2zAeZbcqvSBHjcfRoceCp6E1DMHY0HYx?=
 =?us-ascii?Q?I5BLz03dmGtxHVmjhCcuZCx6VA5TK7f8WUGD6FLII0PBeSLsU1VTvaML1vGI?=
 =?us-ascii?Q?ndnIDDU1W5xP/90a+9QVv/oU7EnlkrTCJbIuu3OMJa3WtTeIPlNQBk4OZ/8w?=
 =?us-ascii?Q?+7Ze0BNuEq4s+/zlgUHhYBBQM9S/+RcvBZGTePkrmOHlaIu1aJlWFdtBIc1W?=
 =?us-ascii?Q?BBn0OJxCBctMa2CvQSQOuFwW0jYkgPirku+iJgEYZDG0tPVmkvOlsFqbmtlR?=
 =?us-ascii?Q?rUOOwCv9chFS/XtcM4Tft23v1VXMe70S+/fQ5dh+uKEqukK4u8bttldgg00m?=
 =?us-ascii?Q?GLG8t1ZGQ8AwWZyhOnTZAGiolJey01ju4wGYmaTolanxYj8OLJjcmrJEJzt4?=
 =?us-ascii?Q?gzo4KVKkpC3efkS1Ghnr0x7auhjlBNz+epoBJ36gONWsQIQZZW8spOXl60Gx?=
 =?us-ascii?Q?0vHcCviD8myXtSCUISOZFLq8YbhY0BeSdY+yH9snD5Nnnq8GaMv3CU/gZQzT?=
 =?us-ascii?Q?nGVFHYgXTb0Cgpxc8bOiN/Vo6KPyMV+XQ6U1h5M1w0NYbKF00kRbPu3ohNrn?=
 =?us-ascii?Q?+egPoQAbl881WBwK9uWBSB6el5kuTRtTAc7VVICVwGTohqHjeji0IC3UECaJ?=
 =?us-ascii?Q?szgqKvC19c0eX/14HRO3WG30hQqp7MIf9U/qn4bvcjJST8JWb0eYUVMT50cG?=
 =?us-ascii?Q?gKWakhb1EpWMKv44fl887kM0xDntzrrbaacNsWQnbp33L70YSdYkXrAlP4Ns?=
 =?us-ascii?Q?u7Mkr1NsnVMhV0A0C05itaxyMePpczeM5vxFEVJxBqhCWZJr8bPFVRNUgemQ?=
 =?us-ascii?Q?EwN8UCG/mSxep5W8OP0m3TkvZpSrucXewF04uFjQ5gErM4ublp0TSfzkfCEp?=
 =?us-ascii?Q?IJsx86U8KbYpjG95uHLMk2ocWIz98KhFKXEDtTaQzAE1JGSXV57oehMr4lV2?=
 =?us-ascii?Q?R8gBvi1AhjJF78Q1zd2pDPM54AGO5bq+x2B5FZzyFa97rPdnlPydtYpUxxLg?=
 =?us-ascii?Q?FTGrkYX15MvxQRCfgOIu5VAAVzNzYukKf2JIfgSZJeTFQHAJzjTmDCsoSURP?=
 =?us-ascii?Q?+xpc1cKWSoYsM2Fid9ZcAppKp6+5puaTO6MP2qQ6JgQ0HPKmlQXV6HrCjXb7?=
 =?us-ascii?Q?uDQ/zKP3KhiEmOwSWeqy7JuQSMUL4pSIEU7OndKZ?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3164.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c849a58-bb61-4394-63ea-08da926dd2b4
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2022 14:16:01.0162
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XiXcWhhRxp9338TgEGQRmIxHlHkk+X9u1synAT2heyXKzRLetFY4vR7pgPliSJCPc6gCXLfXIVOQ18nl9Szb2w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4423
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Wed, Aug 24, 2022 at 07:39:46PM +0000, Petlozu Pravareshwar wrote:
> > >
> > > On Wed, Aug 17, 2022 at 06:44:56PM +0000, Petlozu Pravareshwar wrote:
> > > > During PMC probe, print previous reset related info such as reset
> > > > reason and reset level.
> > > >
> > > > Signed-off-by: Petlozu Pravareshwar <petlozup@nvidia.com>
> > > > ---
> > > >  drivers/soc/tegra/pmc.c | 27 +++++++++++++++++++++++++++
> > > >  1 file changed, 27 insertions(+)
> > >
> > > We already expose this information in sysfs, why do we need to print
> > > it during boot?
> > >
> > > Thierry
> > There are some tests which would parse the boot log for this informatio=
n.
> > But I agree, since we are already providing this information through
> > sysfs, there is no need to print it during boot.
>=20
> It'd be a good idea to transition the tests to try and obtain this inform=
ation
> through sysfs first and if that fails they could fall back to using the b=
oot log.
> Although to be honest, I think we've supported this sysfs interface for l=
ong
> enough that we probably don't have to worry about a fallback.
>=20
> Thierry
Agree. Transitioning the tests to obtain the information through sysfs look=
s
good to me. I think this change can be discarded as printing the info in th=
e
boot log is no longer needed.

Thanks.