Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Sep 2022 11:47:10 -0500
From:   Rob Herring <robh@kernel.org>
To:     Ibrahim Tilki <Ibrahim.Tilki@analog.com>
Cc:     jdelvare@suse.com, linux-kernel@vger.kernel.org,
        krzysztof.kozlowski+dt@linaro.org, linux@roeck-us.net,
        linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v8 3/4] dt-bindings: hwmon: Add bindings for max31760
Message-ID: <20220909164710.GA1537271-robh@kernel.org>
References: <20220909133718.388213-1-Ibrahim.Tilki@analog.com>
 <20220909133718.388213-4-Ibrahim.Tilki@analog.com>
 <1662740789.477872.1507147.nullmailer@robh.at.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1662740789.477872.1507147.nullmailer@robh.at.kernel.org>
Precedence: bulk

On Fri, Sep 09, 2022 at 11:26:29AM -0500, Rob Herring wrote:
> On Fri, 09 Sep 2022 16:37:17 +0300, Ibrahim Tilki wrote:
> > Adding bindings for Analog Devices MAX31760 Fan-Speed Controller
> > 
> > Signed-off-by: Ibrahim Tilki <Ibrahim.Tilki@analog.com>
> > ---
> >  .../bindings/hwmon/adi,max31760.yaml          | 44 +++++++++++++++++++
> >  1 file changed, 44 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/hwmon/adi,max31760.yaml
> > 
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> ./Documentation/devicetree/bindings/hwmon/adi,max31760.yaml: error checking schema file

Not sure why the error is useless ATM. I'm checking that.

The problem is that 'reg' is a matrix and you need to either fully 
define it or use the simplified form for a single cell:

reg:
  minimum: 0x50
  maximum: 0x57

The full, expanded form is:

reg:
  items:
    - items:
        - minimum: 0x50
          maximum: 0x57

> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/adi,max31760.yaml: ignoring, error in schema: properties: reg

> Documentation/devicetree/bindings/hwmon/adi,max31760.example.dtb:0:0: /example-0/i2c/fan-controller@50: failed to match any schema with compatible: ['adi,max31760']

This will go away when the schema passes checks.

Rob