Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Sep 2022 10:16:07 -0700
From:   Lucas De Marchi <lucas.demarchi@intel.com>
To:     "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
CC:     "joonas.lahtinen@linux.intel.com" <joonas.lahtinen@linux.intel.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "Winkler, Tomas" <tomas.winkler@intel.com>,
        "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>,
        "airlied@linux.ie" <airlied@linux.ie>,
        "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>,
        "Usyskin, Alexander" <alexander.usyskin@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "daniel@ffwll.ch" <daniel@ffwll.ch>,
        "Lubart, Vitaly" <vitaly.lubart@intel.com>
Subject: Re: [Intel-gfx] [PATCH v7 00/15] GSC support for XeHP SDV and DG2
Message-ID: <20220909171607.ntchts7ykjrno73p@ldmartin-desk2.lan>
References: <20220806122636.43068-1-tomas.winkler@intel.com>
 <YxDLFWjIllqqh9de@kroah.com>
 <166271909777.4265.10724483511179344068@jlahtine-mobl.ger.corp.intel.com>
 <b959d485-5986-4524-8a84-6086f1076cc5@intel.com>
 <a3512279e0ebcd7c4d60926f118dbd435e0b7819.camel@intel.com>
Content-Type: text/plain; charset="us-ascii"; format=flowed
Content-Disposition: inline
In-Reply-To: <a3512279e0ebcd7c4d60926f118dbd435e0b7819.camel@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9VG9ZrzHFS+dT9YNgAtdF6TWpfi3TUgsVAdcfsayg/DDU4b8h5UauTOTu/eD?=
 =?us-ascii?Q?IfZcCZWSu/qjfO4ZaspAOUj7nLKVoLdN5ONe5qieBeG1+W+SZq0VYDfRwgSr?=
 =?us-ascii?Q?hSTnB493WUeVG+8OcRHYxjn3shwJ9q+K4xNWyYKwfit5xrUw2e9zxJx4czvL?=
 =?us-ascii?Q?wC/HwZQ2Sahc5MEtyzN/Ah1CyILWfs8KB4NNXblfYLkZ5ZjMhPwYMPeSEkfI?=
 =?us-ascii?Q?c/9tmd52wqy69gBh+OJxnsrbZA+DyLWLXxDIMWekrg/G7ilikalVnQ5CR/rD?=
 =?us-ascii?Q?ecQQTqddDd99iaFSPbFLsXYz+hJX9KuEY6GhGrFGaycCtkKIimm1R9En7fOX?=
 =?us-ascii?Q?1J9DhndtT9AC/q0q7txlb51rsJjTkgVOpVUtH47J987X4wZ+riVXlbGWEWwH?=
 =?us-ascii?Q?Ryg9EgWcMsR7BUVUgRSmItAYya+xUAc9sozD4DHLGcWvDn5pHTXUAHkMOp7k?=
 =?us-ascii?Q?bU4EcwPf2Wqz86AzmleX5hutitw2URVF59SsYgXRfsRZW+rDGDMj6HdJ5TNI?=
 =?us-ascii?Q?RoFFEl/TYksOtVHBSC5wic0OUm4a5+LDV4et94+6aoMcckM6FhKJ5aHY0ILp?=
 =?us-ascii?Q?lhh9m0ZJd3/el4WgOGlPszykIk7bOMFMurb0QzKGUcJbcDug56+I+k64ck6d?=
 =?us-ascii?Q?ieNwLT/M9Z/d4eXhj8fxKJzwlt2mgY1p4JUGFENbhda0DjgIkRd5f5TTGHTI?=
 =?us-ascii?Q?jXgdsDy8TgBCRgRO+f3yDLWeOGsFb5ETjrpFUtaPQdGKAIQILe7OW7SY3mNL?=
 =?us-ascii?Q?rDRvIhYqiRktobgWsHcB5Tq0SfCVWgwK3b6pVLeoneORbLa9KlGr+VywSCT/?=
 =?us-ascii?Q?Kzm+FnhwZ4Gf7DFXaGK3oVQPaDBkFaj5aLyiE52hTYhtCrfDY1KUH+1BEK+b?=
 =?us-ascii?Q?HzCCCNa10iGSUZU5a42UuY6oYz765+JLwV7XPFmVLOoTyFq9oZ6ZcDRWD4JV?=
 =?us-ascii?Q?yvf+6119QPdI0QfN4AvoVE/UY9DypLZ49IE+i0Odssiwa57s6cB6XFFGpjEO?=
 =?us-ascii?Q?WTlOn67Pxg+qK70qC7N07aFKpMGXoYaBmuQN+HhPwW5JHa5ksJverd7Xc6JL?=
 =?us-ascii?Q?nrScICYLX2n5roMXtKk35f37DMzbbL64gFvJWPCVinyz6iAExJJfQkvmc5Nb?=
 =?us-ascii?Q?d+uMI1FSZxXIzWgrLwZRwNnQAMuLOCfHbU6/Ft6/YPT+wUn6rB4e8ABpBQdx?=
 =?us-ascii?Q?hrdFGa5j3xPlD5DE7skD92Qa+NzE5VjAc5BPyqk4vesYJTRZ9y9xmjNziMuQ?=
 =?us-ascii?Q?bPrIveOcRxloXQf+giRCQwN46TWqbnX0h7Ru0rFw/kPHj9PPp+fV9Mo9BIId?=
 =?us-ascii?Q?/RtrhdSo1SPO7tdvJR4UkucUrVeodUCrA4iw94UN2xs/94014rDCy1UcgfsW?=
 =?us-ascii?Q?MB2hZ0VKTTJjA4Nq6nvrP6v65kJkBgNZ6A0MFOs1LjUO3/CwD05BPRzAO8ql?=
 =?us-ascii?Q?dF1a8a4vwWq3c0JtPmT8CL6iY/T8DvUCAWax2R8WTzOIXx31dl0NxCfEHc+2?=
 =?us-ascii?Q?wx71WkZn3hIQXw50cxFHIprlnFiORk7DzTHdUw4HfkcBhI1HCs2URRouOEok?=
 =?us-ascii?Q?ZIUX24jH6oh3+D0eYelh+jUgoRS9rKNkX79xOtJ89xKvDYqFkM00q0HmsHAz?=
 =?us-ascii?Q?xw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 130d6739-19b8-4941-a063-08da9286fd36
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6139.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 17:16:10.0022
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qHEmq3u3ww5rDgcWfRuQaWdQ/JI/fYO1IZtBjf4WD9OrdSkF5n5PIHGNz8BLvIvkwIsAsCRTpQHO+gGWQmlMcMVyqlQdjNgZBsgD1FNlXVk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6504
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 09, 2022 at 04:33:45PM +0000, Rodrigo Vivi wrote:
>On Fri, 2022-09-09 at 08:17 -0700, Ceraolo Spurio, Daniele wrote:
>>
>>
>> On 9/9/2022 3:24 AM, Joonas Lahtinen wrote:
>> > Dave, do you have a preference how to deal with the mishap here,
>> > shall I do a
>> > force-push to drm-intel-gt-next to correctly record the Acked-by or
>> > revert and
>> > re-push? Or just leave it as is?
>
>Dave and Daniel, this question is still pertinent.
>
>> >
>> > Quoting Greg Kroah-Hartman (2022-09-01 18:09:09)
>> > > On Sat, Aug 06, 2022 at 03:26:21PM +0300, Tomas Winkler wrote:
>> > > > Add GSC support for XeHP SDV and DG2 platforms.
>> > > >
>> > > > The series includes changes for the mei driver:
>> > > > - add ability to use polling instead of interrupts
>> > > > - add ability to use extended timeouts
>> > > > - setup extended operational memory for GSC
>> > > >
>> > > > The series includes changes for the i915 driver:
>> > > > - allocate extended operational memory for GSC
>> > > > - GSC on XeHP SDV offsets and definitions
>> > > >
>> > > > This patch set should be merged via gfx tree as
>> > > > the auxiliary device belongs there.
>> > > > Greg, your ACK is required for the drives/misc/mei code base,
>> > > > please review the patches.
>> > > With the exception that you all don't know what year it is:
>> > >
>> > > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> > Daniele, why were the patches applied without this A-b?
>>
>> Apologies, I usually rely on dim to pick up all the correct r-bs and
>> acks from the ML and to warn me if something is missing, and I didn't
>> realize that it hadn't automagically picked up the ack.
>
>I understand the feeling. Recently I merged a patch from Vinay relying
>on patchwork to get the reviewed-by and I forgot to double check.
>
>dim picks up the "Link:", but I don't believe it picks any ack or rv-b
>from the mailing list. Patchwork does if you use pwclient or something
>like that.

When you download the patch from patchwork, it will include the
r-b/a-b for the patches, not the cover letter.

	$ curl https://patchwork.freedesktop.org/api/1.0/series/106638/revisions/5/mbox/ | \
		grep Acked-by
	$

Patchwork simply ignores the cover and does nothing.

b4 has an option to propagate the a-b on cover to the patches (-t):

	$ b4 am -o - -t YxDLFWjIllqqh9de@kroah.com | grep Acked
	...
	Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
	Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
	...

b4 also has options to work on your local mailbox instead of relying on
the external server to apply a-b/r-b. Maybe people should be using it
more instead of relying on patchwork.

Should the Acked-by be recorded on each patch? That is what is usually
done, but if preference would be for a merge commit to be created and
Acked-by recorded in the merge commit, dim would need to learn a
few things. b4 is already prepared:

	$ b4 shazam -M -P1-15 YxDLFWjIllqqh9de@kroah.com

Lucas De Marchi