Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tilki, Ibrahim" <Ibrahim.Tilki@analog.com>
To:     Rob Herring <robh@kernel.org>
CC:     "jdelvare@suse.com" <jdelvare@suse.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "linux@roeck-us.net" <linux@roeck-us.net>,
        "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH v8 3/4] dt-bindings: hwmon: Add bindings for max31760
Thread-Topic: [PATCH v8 3/4] dt-bindings: hwmon: Add bindings for max31760
Thread-Index: AQHYxFFeyfAJY5xBI0Cum0e0PCDEpa3XSTGAgAAFxwCAABDn0A==
Date:   Fri, 9 Sep 2022 17:48:05 +0000
Message-ID: <DM8PR03MB624727E043782EC34DBBE6B196439@DM8PR03MB6247.namprd03.prod.outlook.com>
References: <20220909133718.388213-1-Ibrahim.Tilki@analog.com>
 <20220909133718.388213-4-Ibrahim.Tilki@analog.com>
 <1662740789.477872.1507147.nullmailer@robh.at.kernel.org>
 <20220909164710.GA1537271-robh@kernel.org>
In-Reply-To: <20220909164710.GA1537271-robh@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lLoKJv8PsW52Dl3rVS9ARVy4AairvN9FfYqTFZEbs60LZpghxi0A8ksERPQi?=
 =?us-ascii?Q?SL6YB0uSjsVxTXjf+gyzsdLrH0vWMBwHR4VkWF4O0Ro42RQDeWcf4MS5adG+?=
 =?us-ascii?Q?tvBmjMvEx9mBr/LQ22lNz6B7kxvbGYqiJt0Mc4Pc6Ln3G/uae32XuRffZ53U?=
 =?us-ascii?Q?sK7SGCqo6QTXkSA6FThYfIqfnOzKUXY0fjE2XUMlI9tio9e1Zg5XZkvO/a3K?=
 =?us-ascii?Q?p82C6j19NMbsvMXinAVIZpnin50HEU4bRp4w7ddCdcKkzNnFaLLqoUol+hc0?=
 =?us-ascii?Q?rxYNneFq9wTKTR/mTlZDO9R5PyGm8Bv8S7vBgjSJTmJxN/fsH5RRlNABsAfZ?=
 =?us-ascii?Q?ZMLAnaTOtE8GOvgwdFC8Q5Bpua+StwaIkwB3/5IInNkBalXcnulMcOg8eRJS?=
 =?us-ascii?Q?sGAgERYiBTJxCyheS1T9zwS6fKNdpztCI52OWfdEuKgLE9PdVI5IatHR3Je4?=
 =?us-ascii?Q?mm3gLROIczIrHpVJl/dQ9amTEXCirEBsAUpy84YYSXZBnKhm4jqL8+JPGROA?=
 =?us-ascii?Q?y4I7qZnTuwPainwRGTYcCdLg4oheSeULS3FUD7oJKAGvOR6BmZPWGt5T2/+T?=
 =?us-ascii?Q?VhQWzc3FuxPKMgKFkF7cGYMBi46I0eK2CTLz+MyMdiHlsWOuuOjEPad8vMzQ?=
 =?us-ascii?Q?vwYN7SVTtJm4eQFdMVhHwUVKemj9j9LbVVeDSYhAKzEthMe9xdA9+nC853Ru?=
 =?us-ascii?Q?6vC9x7j/8gEIoeGQzER9gQxh/2sHdPYDxjjx89KPU8yeKoDEbOp3dgmVLoiS?=
 =?us-ascii?Q?VRLJugZULoTd9AFOVUxxcqqMBVljVJF/H9lAYLBknvXfT+dhK0Bb3jBzQ56O?=
 =?us-ascii?Q?PmySTpqbDfhYAHiB45Ez1tAZWgijhZSTY1MsFbfF0HgES+rZaKTpz3aI9wkj?=
 =?us-ascii?Q?Fhs/oF43IBuMWIeyDGHWdGlYqxlbsH4lsz948i8JwmjkpiV7Ruyd4HU8OhYM?=
 =?us-ascii?Q?U/6B8tBut5V8jMxMqvPOUvWQv1r+d6zwCw2g9Mn2uyNFeLPrc2Sq+Y1SZfpU?=
 =?us-ascii?Q?ceY9kcGVEPv94Kk43gqgmGBoLO2Q0GGrWWKxWffb0bX3Zz1MMkFTz3t/6ezt?=
 =?us-ascii?Q?FdlHWzADLpVNloFAZnt7sizLeYPUZMhCWZWQJQOsRVp6xWxsNF9nlMdcmNq1?=
 =?us-ascii?Q?8/HAFjXgF8ocqbh8pwDbV31HQI2ip1zaig/ANovA07QkcT6XQCjVZJNqNPKb?=
 =?us-ascii?Q?BD9I+7DlLBvQaGAEAYx55C9/nsJx1AEP+kwR0UtaEdOMcaAfG8yro8UPwdxC?=
 =?us-ascii?Q?YkwniUH0P+tIdga24awOBsg3V+4LHPe0UBuALQ9iD+JEtLxRtuBrm0Zc9w2+?=
 =?us-ascii?Q?GG4pKUJFwfVbwADy2Vgl86ShAUuJq4BDR/0Z4ZDzTZrEu5jedGQcJs03wgNi?=
 =?us-ascii?Q?5g1DM6tlDPDxk0rB4I0rv6mTVuMnba9M6b0p//1N92XLqVww1qgR3X3/G2lR?=
 =?us-ascii?Q?h/bGSKYhcf+8R0xOIpGe4Sx+YBjTMGu5OTC5gOP4ohQrX2RpBkbIiTZ5v4HZ?=
 =?us-ascii?Q?Gcg8gytxFC91SPu/fOk2/uDGbDUbbvtw8tYtOsShHWjGCnqIZ5GaJUXg9YLk?=
 =?us-ascii?Q?maPh7LIcVLuPEz9mQA4hdSO+PXsKBpVX62Rw48VS?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR03MB6247.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 58331dfc-e65b-41ea-95ff-08da928b7319
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2022 17:48:05.4887
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0RGDELryuiAHhoZlGfJErGLWO2N5hySmIhGNi+7DhaobFFPmgXoLKCH9KvLcGlC72Wx0hsbGqHkbXKo+dhcv1ADOyFRYl4kF5taGpW9tTks=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5144
X-Proofpoint-GUID: NSYOannz-7evMOWVKDSrZTSWtt3H-EbN
X-Proofpoint-ORIG-GUID: NSYOannz-7evMOWVKDSrZTSWtt3H-EbN
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-09_08,2022-09-09_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 adultscore=0
 impostorscore=0 priorityscore=1501 malwarescore=0 mlxlogscore=567
 lowpriorityscore=0 mlxscore=0 bulkscore=0 spamscore=0 suspectscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2207270000 definitions=main-2209090062
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Fri, Sep 09, 2022 at 11:26:29AM -0500, Rob Herring wrote:
> > On Fri, 09 Sep 2022 16:37:17 +0300, Ibrahim Tilki wrote:
> > > Adding bindings for Analog Devices MAX31760 Fan-Speed Controller
> > >=20
> > > Signed-off-by: Ibrahim Tilki <Ibrahim.Tilki@analog.com>
> > > ---
> > >  .../bindings/hwmon/adi,max31760.yaml          | 44 +++++++++++++++++=
++
> > >  1 file changed, 44 insertions(+)
> > >  create mode 100644=20
> > > Documentation/devicetree/bindings/hwmon/adi,max31760.yaml
> > >=20
> >=20
> > My bot found errors running 'make DT_CHECKER_FLAGS=3D-m dt_binding_chec=
k'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >=20
> > yamllint warnings/errors:
> >=20
> > dtschema/dtc warnings/errors:
> > ./Documentation/devicetree/bindings/hwmon/adi,max31760.yaml: error=20
> > checking schema file
>=20
> Not sure why the error is useless ATM. I'm checking that.
>=20
> The problem is that 'reg' is a matrix and you need to either fully define=
 it or use the simplified form for a single cell:
>=20
> reg:
>   minimum: 0x50
>   maximum: 0x57
>=20
> The full, expanded form is:
>=20
> reg:
>   items:
>     - items:
>         - minimum: 0x50
>           maximum: 0x57
>=20

Actually it passes the check when I remove maxItems property:

  reg:
    description: I2C address of slave device.
    items:
      minimum: 0x50
      maximum: 0x57

I cannot find a way to specify both maxItems and min-max limits.
Which one should I drop? Line below is from the output of dt_bindigs_check:

hint: "maxItems" is not needed with an "items" list

Regards,
Ibrahim

> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/binding
> > s/hwmon/adi,max31760.yaml: ignoring, error in schema: properties: reg
>=20
> > Documentation/devicetree/bindings/hwmon/adi,max31760.example.dtb:0:0:=20
> > /example-0/i2c/fan-controller@50: failed to match any schema with=20
> > compatible: ['adi,max31760']
>=20
> This will go away when the schema passes checks.
>=20
> Rob