Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <82b3b47a-c6f6-5d06-d1d5-3a1c132d80da@amd.com>
Date:   Fri, 9 Sep 2022 13:52:47 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [PATCH 4/7] cpufreq: amd_pstate: add AMD pstate EPP support for
 shared memory type processor
Content-Language: en-US
To:     Perry Yuan <Perry.Yuan@amd.com>, rafael.j.wysocki@intel.com,
        ray.huang@amd.com, viresh.kumar@linaro.org
Cc:     Deepak.Sharma@amd.com, Nathan.Fontenot@amd.com,
        Alexander.Deucher@amd.com, Jinzhou.Su@amd.com,
        Shimmer.Huang@amd.com, Xiaojian.Du@amd.com, Li.Meng@amd.com,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220909164534.71864-1-Perry.Yuan@amd.com>
 <20220909164534.71864-5-Perry.Yuan@amd.com>
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <20220909164534.71864-5-Perry.Yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UlN0VjhadmlzdTV3dDVrOG1jcytmT0tlMkRCOHZYQmVubitPdjlrNkdqUmY3?=
 =?utf-8?B?QVplamI2Q1lUeTUrR1llRGRlOW5NQWtuUThvalRKdXlhdXNZc2NyWDk5LzBw?=
 =?utf-8?B?dTNWQnhtWm1qSVlHMkRFVW1pTEtORGJ5REFSUW5SYkw5U3J2TEdkcWVnTHBI?=
 =?utf-8?B?a0VnWkk2ZkkrL2lBSzJJTDVwMVkycExCVjloT0JBT0x1T1V0QjF0NHFueHhZ?=
 =?utf-8?B?bzJXd1JwVCtQT1RmYmJJd1AxeTRVU3VyMXVadjNnYUh1SEJlMUNMQ2poRWJX?=
 =?utf-8?B?bFBoMHF5ZW13UVlWMm5SVzNvTlpERUpEb01VVmJpaE43TkNOU25OR0piVTlW?=
 =?utf-8?B?QjlBTTJBeEtZRnBpTm5ieVk5a1VFdG5XTmpPOGNKdEdXNW9hUG9ac2FGRVg5?=
 =?utf-8?B?VzN4RDQxY3Nrdk1xNzAva2pENUE3N1FOL0RlM2VnNDk4MGdGYXlabG5sK3Zu?=
 =?utf-8?B?WklhZE1NYVNvenVobUN2eFllNXA3aFZrT3dYd2psT1pGWjc5bllRVG9JZXJ1?=
 =?utf-8?B?T1BTckh5RFczOXpYSXZXQVhCOFNjUUVuNno1UHZOSk00bXlDZXNsdkFUTzVv?=
 =?utf-8?B?bG15SHJ3amJ3MThZNFRiV3gzRnNKWG1xMlVXSDJqNngwVlJuOHd4OGJYY3B4?=
 =?utf-8?B?SU1ja3A4bUNtcWNYV0FIRE4xYTd2QWd6eThnR1VPbG9NUzhCVk9ldW4yb28z?=
 =?utf-8?B?cWtzR1NDYmlpWnRZN3dFNzFVbGxhaVFKaHNMVDZLSG0zZEluMjJlNWZweENr?=
 =?utf-8?B?a1haVVU5RHNST2RMMjNBc2U3MkxKYkRmdS95VXJRb1puVzJIRWtUY2dPMEZQ?=
 =?utf-8?B?OHpxeUhiZkZjQUszeUZPUGFNRUdsVzlvUndHcER4TFVtQ000aVcra2JoZnBs?=
 =?utf-8?B?N21PZXlrcmsyMHp2TDZDNllnUzR1UHNweEhLaHdrTkJwbFNRZEFydWMwWW9m?=
 =?utf-8?B?Z0hzRTBVVEVFbHRzSm9XZlNWci9LeGRQa1RORVNncW9JWk1nNFBoRE9VTERW?=
 =?utf-8?B?VWRhVTVxbU1uWnlMcUx6R0xzM1N1b1d0eTA4cnZvMlRPVVdIL0drVDV1bC9i?=
 =?utf-8?B?bVQzcS90cG5YYVB3djlnYk13ZmY2Qk96NHk4bVoxTUEzblNLUHU3LzRZeGt1?=
 =?utf-8?B?VjZNb1NObTdjS1gzY0lMMGdMVDF1aGRYM00zUk51Y0k2cUplRlhaSU5WL3Uz?=
 =?utf-8?B?VmVaNklDM1BhRGlZd2UxUDVySUhGVW9XbS9Vend5eWJ3aVBaeCtLcnNBbW43?=
 =?utf-8?B?cng3eDVWQ2ZqNkpuOFl3QTRsKy94TkwwanRKa0cxbnlUSWxPR2g3bDdUYmx4?=
 =?utf-8?B?OWU2N3h2dEJEaXZxaTltK29MaFdWeXozZEUrdkRJZFFEY0VaTk1WWkVubDFE?=
 =?utf-8?B?NVdOZmZzTTRwVVpQTlg4OC9DVTNnYkU3QTRESWdzWVV3clo0Q3ZvdDhLZDdy?=
 =?utf-8?B?bkp0R2M2V1dtZEVpWExjYVB4ZDVPcFRTSnZldzRYdmdoREJCendtenhPYjZp?=
 =?utf-8?B?dkhMcnE3eEZ2dXVuQXBDZXR0LzlMMjRZTy9pbHEzVndVWVNuVkR6ZkVHMk03?=
 =?utf-8?B?eWdRZkFCbXhtazF2K3NjdG1WRnVhcm1JRk00WmlENkhoSEZDYWhqTEpjaVFq?=
 =?utf-8?B?ZG52VzRWdzdhS2hpSGI1ejFxc2VFOEJwY1ZINHltVkRxMDJudWY5QTRVTGgx?=
 =?utf-8?B?ajk4RHg1cHBVVmpmVVQvVnBiN3o0T2tBU1JmY1NGV0VoRnpPV1k5MlVBSUwv?=
 =?utf-8?B?VTUrU1pTZDN6NWRheGkreDVhb0pCVWdGZzYrdWlwZzFPUjNJYWQzWUVaZ2h0?=
 =?utf-8?B?QzZUNFk5ckRFeEhwV1pnZVpYUk1uc0l1YmNhTWYvYk9IUFhzbHRmM0hicklr?=
 =?utf-8?B?bXRjSE0vVnJPam8ydTBnT1NlSXp4OWZHRTg1b1JsU05jalRBbEgwZWkyOFJ4?=
 =?utf-8?B?TjhvNmhoSzZlRXVZd3lCUHFXYTRhKzNCS0tlVlU4dHNGZVZEREpmNGFCTGYv?=
 =?utf-8?B?bDFwT0dWZ2ZZNGM3OFRsemhpRzVaTW4rSFpWL1BTVzVNdWlGTm0vVXFVUjI2?=
 =?utf-8?B?bFo2NEZHUzlFRm5qcGI0S3VOZ1RYSHdENTNwcVJqNlhtVDBNRU5pSFZUMTVa?=
 =?utf-8?Q?JFbQe4o2/iRUDJTh+3XKUYiLD?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 851caf51-42c8-4c23-cbb5-08da92947e3c
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 18:52:49.8493
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: crmU8SSwWtSxg+VWM4FptkMz9zS7xEXNOr1Ryz+HA5OAEluxSns8UU99LFPAZf6kJ0zTv4EfeZniPQWL/qqBGQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6424
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/9/2022 11:45, Perry Yuan wrote:
> Add Energy Performance Preference support for AMD SOCs which only
> support the shared memory interface that implemented on Zen2 and Zen3
> processors, because this type CPU has no MSR supported, it will use
> ACPI PCC channel to enable EPP and reset desired perf to be zero.

This reads like all Zen2 and Zen3 processors don't have the MSR, but 
that's not true. How about:

"Add Energy Performance Preference support for AMD SOCs which do not 
contain a designated MSR for CPPC support. A shared memory interface
is used for CPPC on these SOCs and the ACPI PCC channel is used to
enable EPP and reset the desired performance."

> 
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
> ---
>   drivers/cpufreq/amd-pstate.c | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 451295284a26..fff298744a8e 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -133,12 +133,24 @@ static inline int pstate_enable(bool enable)
>   
>   static int cppc_enable(bool enable)
>   {
> +	struct cppc_perf_ctrls perf_ctrls;
>   	int cpu, ret = 0;
>   
>   	for_each_present_cpu(cpu) {
>   		ret = cppc_set_enable(cpu, enable);
>   		if (ret)
>   			return ret;
> +
> +	/* Enable active mode for EPP */
> +	ret = cppc_set_auto_epp(cpu, enable);
> +	if (ret)
> +		return ret;
> +
> +	/* Set zero to desired perf to enable EPP control*/
> +	perf_ctrls.desired_perf = 0;
> +	ret = cppc_set_perf(cpu, &perf_ctrls);
> +	if (ret)
> +		return ret;
>   	}
>   
>   	return ret;