Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Sep 2022 12:44:40 -0700
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     Kefeng Wang <wangkefeng.wang@huawei.com>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Kees Cook <keescook@chromium.org>,
        Iurii Zaikin <yzaikin@google.com>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] sched: Move numa_balancing sysctls to its own file
Message-ID: <YxuXqF63RIMstdEN@bombadil.infradead.org>
References: <20220908072531.87916-1-wangkefeng.wang@huawei.com>
 <YxqDa+WALRr8L7Q8@bombadil.infradead.org>
 <679d8f0c-f8cc-d43e-5467-c32a78bcb850@huawei.com>
 <d99630ed-0753-da9e-ab03-848b66bc3c63@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <d99630ed-0753-da9e-ab03-848b66bc3c63@huawei.com>
Sender: Luis Chamberlain <mcgrof@infradead.org>
Precedence: bulk

On Fri, Sep 09, 2022 at 11:37:41AM +0800, Kefeng Wang wrote:
> 
> On 2022/9/9 9:46, Kefeng Wang wrote:
> > 
> > On 2022/9/9 8:06, Luis Chamberlain wrote:
> > > On Thu, Sep 08, 2022 at 03:25:31PM +0800, Kefeng Wang wrote:
> > > > The sysctl_numa_balancing_promote_rate_limit and sysctl_numa_balancing
> > > > are part of sched, move them to its own file.
> > > > 
> > > > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> > > There is quite a bit of random cleanup on each kernel release
> > > for sysctls to do things like what you just did. Because of this it
> > > has its
> > > own tree to help avoid conflicts. Can you base your patches on the
> > > sysctl-testing branch here and re-submit:
> > 
> > Found this when reading memory tiering code，sure to re-submit based
> > your branch,
> > 
> > thanks.
> > 
> > > 
> > > https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=sysctl-testing
> > > 
> Hi Luis，the numa_balancing_promote_rate_limit_MBps from commit 1db91dd846e0
> “memory tiering: rate limit NUMA migration throughput”only on
> linux-next（from mm repo），
> 
> 1）only send sysctl_numa_balancing changes based on your branch
> or
> 
> 2）queued this patch from mm repo if no objection， Cc'ed Andrew
> 
> Which one do your like, or other options, thanks.

2) as that would give more testing to the new code as well. We can deal
with merge conflicts on my tree later.

  Luis