Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764156AbXFRRuW (ORCPT ); Mon, 18 Jun 2007 13:50:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753537AbXFRRuK (ORCPT ); Mon, 18 Jun 2007 13:50:10 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:32935 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758998AbXFRRuJ (ORCPT ); Mon, 18 Jun 2007 13:50:09 -0400 Date: Mon, 18 Jun 2007 10:48:45 -0700 (PDT) From: Linus Torvalds To: Miklos Szeredi cc: mingo@elte.hu, cebbert@redhat.com, chris@atlee.ca, linux-kernel@vger.kernel.org, tglx@linutronix.de, akpm@linux-foundation.org Subject: Re: [BUG] long freezes on thinkpad t60 In-Reply-To: Message-ID: References: <20070524144447.GA25068@elte.hu> <20070524210153.GB19672@elte.hu> <20070616103707.GA28096@elte.hu> <20070618064343.GA31113@elte.hu> <20070618081204.GA11153@elte.hu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 997 Lines: 25 On Mon, 18 Jun 2007, Miklos Szeredi wrote: > > > Hmm? Untested, I know. Maybe I overlooked something. But even the > > generated assembly code looks fine (much better than it looked before!) > > Boots and runs fine. Fixes the freezes as well, which is not such a > big surprise, since basically any change in that function seems to do > that ;) Yeah, and that code really was *designed* to make all "locking in a loop" go away. So unlike the patches adding random barriers and cpu_relax() calls (which might fix it for some *particular* hw setup), I pretty much guarantee that you can never get that code into a situation where there is some lock being starved on *any* hw setup. Ingo, an ack for the patch, and I'll just apply it? Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/