Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220901083438.105561-1-yang.lee@linux.alibaba.com>
In-Reply-To: <20220901083438.105561-1-yang.lee@linux.alibaba.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Fri, 9 Sep 2022 16:43:49 -0400
Message-ID: <CADnq5_NAWok8spV=A6JKoRL+Cz3ACTtp8HGt5OA_c16zDOQr1A@mail.gmail.com>
Subject: Re: [PATCH -next] drm/amd/display: remove possible condition with no
 effect (if == else)
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     alexander.deucher@amd.com, sunpeng.li@amd.com,
        Abaci Robot <abaci@linux.alibaba.com>, Xinhui.Pan@amd.com,
        Rodrigo.Siqueira@amd.com, linux-kernel@vger.kernel.org,
        amd-gfx@lists.freedesktop.org, airlied@linux.ie,
        dri-devel@lists.freedesktop.org, christian.koenig@amd.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Applied.  Thanks!

Alex

On Thu, Sep 1, 2022 at 4:34 AM Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> Conditional statements have no effect to next process.So remove it.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2028
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  .../drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c   | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
> index e4fd540dec0f..8f1c0e12dd86 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
> @@ -4663,10 +4663,6 @@ void dml32_CalculateMinAndMaxPrefetchMode(
>         } else if (AllowForPStateChangeOrStutterInVBlankFinal == dm_prefetch_support_uclk_fclk_and_stutter) {
>                 *MinPrefetchMode = 0;
>                 *MaxPrefetchMode = 0;
> -       } else if (AllowForPStateChangeOrStutterInVBlankFinal ==
> -                       dm_prefetch_support_uclk_fclk_and_stutter_if_possible) {
> -               *MinPrefetchMode = 0;
> -               *MaxPrefetchMode = 3;
>         } else {
>                 *MinPrefetchMode = 0;
>                 *MaxPrefetchMode = 3;
> --
> 2.20.1.7.g153144c
>