Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c85af2ae-42b2-89e4-0dc1-17658379ac3a@acm.org>
Date:   Fri, 9 Sep 2022 16:38:14 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [RFC PATCH v3 1/4] ufs: core: prepare ufs for multi circular
 queue support
Content-Language: en-US
To:     "Asutosh Das (asd)" <quic_asutoshd@quicinc.com>,
        quic_nguyenb@quicinc.com, quic_xiaosenh@quicinc.com,
        stanley.chu@mediatek.com, adrian.hunter@intel.com,
        avri.altman@wdc.com, mani@kernel.org, quic_cang@quicinc.com,
        beanhuo@micron.com, martin.petersen@oracle.com,
        linux-scsi@vger.kernel.org
Cc:     linux-arm-msm@vger.kernel.org,
        Alim Akhtar <alim.akhtar@samsung.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        open list <linux-kernel@vger.kernel.org>
References: <cover.1662157846.git.quic_asutoshd@quicinc.com>
 <757bbfe36629b7c31ef2630971f8678a7801223f.1662157846.git.quic_asutoshd@quicinc.com>
 <37d36dd9-f467-233c-babd-4e7c1c953c6c@acm.org>
 <4ef3ee8f-1210-3a03-da14-1bfdf6def297@quicinc.com>
From:   Bart Van Assche <bvanassche@acm.org>
In-Reply-To: <4ef3ee8f-1210-3a03-da14-1bfdf6def297@quicinc.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 9/9/22 15:48, Asutosh Das (asd) wrote:
> Hello Bart,
> Thanks for the comments.
> 
> On 9/8/2022 2:58 PM, Bart Van Assche wrote:
>> On 9/2/22 15:41, Asutosh Das wrote:
>>> Preparatory changes for upcoming multi circular queue.
>>
>> One patch per change please and also describe each individual change. 
>>  From 
>> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#split-changes: 
>> "Separate each logical change into a separate patch".
>>
> The intent of this change was to have all the non-mcq related changes to 
> the ufshcd as a separate patch.
> I would add more details to the commit message of this change.
> If there's anything specific in this patch that may need changes, please 
> let me know.

Please follow the "one change per patch" rule. This is a widely followed 
rule in the Linux kernel community. This rule exists because it is the 
responsibility of the developer(s) who post a patch series to make it 
easy for reviewers to review their work.

Thanks,

Bart.