Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5440c1b9-6b46-32b8-e3c7-41c5285525c4@linux.intel.com>
Date:   Fri, 9 Sep 2022 16:45:30 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH v4 5/9] PCI/PTM: Move pci_ptm_info() body into its only
 caller
Content-Language: en-US
To:     Bjorn Helgaas <helgaas@kernel.org>,
        Kai-Heng Feng <kai.heng.feng@canonical.com>,
        Rajvi Jingar <rajvi.jingar@linux.intel.com>,
        "Rafael J . Wysocki" <rafael@kernel.org>
Cc:     Koba Ko <koba.ko@canonical.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        "David E . Box" <david.e.box@linux.intel.com>,
        linux-pci@vger.kernel.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
References: <20220909202505.314195-1-helgaas@kernel.org>
 <20220909202505.314195-6-helgaas@kernel.org>
From:   Sathyanarayanan Kuppuswamy 
        <sathyanarayanan.kuppuswamy@linux.intel.com>
In-Reply-To: <20220909202505.314195-6-helgaas@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 9/9/22 1:25 PM, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> pci_ptm_info() is simple and is only called by pci_enable_ptm().  Move the
> entire body there.  No functional change intended.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---

Looks good to me.

Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>

>  drivers/pci/pcie/ptm.c | 38 +++++++++++++++++---------------------
>  1 file changed, 17 insertions(+), 21 deletions(-)
> 
> diff --git a/drivers/pci/pcie/ptm.c b/drivers/pci/pcie/ptm.c
> index 70a28b74e721..fc296b352fe2 100644
> --- a/drivers/pci/pcie/ptm.c
> +++ b/drivers/pci/pcie/ptm.c
> @@ -9,26 +9,6 @@
>  #include <linux/pci.h>
>  #include "../pci.h"
>  
> -static void pci_ptm_info(struct pci_dev *dev)
> -{
> -	char clock_desc[8];
> -
> -	switch (dev->ptm_granularity) {
> -	case 0:
> -		snprintf(clock_desc, sizeof(clock_desc), "unknown");
> -		break;
> -	case 255:
> -		snprintf(clock_desc, sizeof(clock_desc), ">254ns");
> -		break;
> -	default:
> -		snprintf(clock_desc, sizeof(clock_desc), "%uns",
> -			 dev->ptm_granularity);
> -		break;
> -	}
> -	pci_info(dev, "PTM enabled%s, %s granularity\n",
> -		 dev->ptm_root ? " (root)" : "", clock_desc);
> -}
> -
>  static void __pci_disable_ptm(struct pci_dev *dev)
>  {
>  	u16 ptm = dev->ptm_cap;
> @@ -213,16 +193,32 @@ static int __pci_enable_ptm(struct pci_dev *dev)
>  int pci_enable_ptm(struct pci_dev *dev, u8 *granularity)
>  {
>  	int rc;
> +	char clock_desc[8];
>  
>  	rc = __pci_enable_ptm(dev);
>  	if (rc)
>  		return rc;
>  
>  	dev->ptm_enabled = 1;
> -	pci_ptm_info(dev);
>  
>  	if (granularity)
>  		*granularity = dev->ptm_granularity;
> +
> +	switch (dev->ptm_granularity) {
> +	case 0:
> +		snprintf(clock_desc, sizeof(clock_desc), "unknown");
> +		break;
> +	case 255:
> +		snprintf(clock_desc, sizeof(clock_desc), ">254ns");
> +		break;
> +	default:
> +		snprintf(clock_desc, sizeof(clock_desc), "%uns",
> +			 dev->ptm_granularity);
> +		break;
> +	}
> +	pci_info(dev, "PTM enabled%s, %s granularity\n",
> +		 dev->ptm_root ? " (root)" : "", clock_desc);
> +
>  	return 0;
>  }
>  EXPORT_SYMBOL(pci_enable_ptm);

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer