Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765032AbXFRSLb (ORCPT ); Mon, 18 Jun 2007 14:11:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753537AbXFRSLX (ORCPT ); Mon, 18 Jun 2007 14:11:23 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:53599 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761790AbXFRSLW (ORCPT ); Mon, 18 Jun 2007 14:11:22 -0400 Date: Mon, 18 Jun 2007 19:11:01 +0100 From: Christoph Hellwig To: Arnd Bergmann Cc: Arjan van de Ven , Mike Frysinger , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, rmk@arm.linux.org.uk Subject: Re: [patch] use __asm__ and __volatile__ in i386/arm/s390 byteorder.h Message-ID: <20070618181101.GA15922@infradead.org> Mail-Followup-To: Christoph Hellwig , Arnd Bergmann , Arjan van de Ven , Mike Frysinger , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, rmk@arm.linux.org.uk References: <200706171833.29046.vapier@gentoo.org> <1182120674.22999.4.camel@laptopd505.fenrus.org> <200706180124.25574.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200706180124.25574.arnd@arndb.de> User-Agent: Mutt/1.4.2.3i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 980 Lines: 23 On Mon, Jun 18, 2007 at 01:24:24AM +0200, Arnd Bergmann wrote: > On Monday 18 June 2007, Arjan van de Ven wrote: > > > > On Sun, 2007-06-17 at 18:33 -0400, Mike Frysinger wrote: > > > This changes asm() to __asm__() and volatile to __volatile__ so that these > > > headers can be used with gcc's -std=c99. > > > > hmm but the kernel doesn't use -std=c99... > > The byteorder headers are exported to user space through > include/asm-generic/Kbuild.asm, and they are used by a number > of other exported headers, so they should work with any > gcc flags that a user might want to use. No, they should not be exported and the headers using them should be fixed to not require this. Userspace has it's own endianess handling already. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/