Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0c594ac2-d775-6424-6850-191c0c30275d@bytedance.com>
Date:   Sat, 10 Sep 2022 15:50:26 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.1.2
Subject: Re: [ammarfaizi2-block:arm64/linux/for-next/misc 2/2]
 arch/arm64/kernel/irq.c:81:6: warning: no previous prototype for function
 'do_softirq_own_stack'
Content-Language: en-US
To:     Catalin Marinas <catalin.marinas@arm.com>
Cc:     Arnd Bergmann <arnd@arndb.de>, kernel test robot <lkp@intel.com>,
        llvm@lists.linux.dev, kbuild-all@lists.01.org,
        Ammar Faizi <ammarfaizi2@gnuweeb.org>,
        GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>,
        linux-kernel@vger.kernel.org
References: <202209091157.akimiv18-lkp@intel.com>
 <a37a1b71-e7b4-4b7a-9aec-a9ce64d13d84@www.fastmail.com>
 <69409ea6-6daa-7973-c950-c6ca9ad96f50@bytedance.com>
 <Yxt/ICkxAH/+tn08@arm.com>
From:   Qi Zheng <zhengqi.arch@bytedance.com>
In-Reply-To: <Yxt/ICkxAH/+tn08@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2022/9/10 02:00, Catalin Marinas wrote:
> On Fri, Sep 09, 2022 at 03:07:36PM +0800, Qi Zheng wrote:
>> On 2022/9/9 14:30, Arnd Bergmann wrote:
>>> On Fri, Sep 9, 2022, at 5:12 AM, kernel test robot wrote:
>>>> tree:   https://github.com/ammarfaizi2/linux-block
>>>> arm64/linux/for-next/misc
>>>> head:   2d2f3bb897a3de4190b1b6b296c3429d01327554
>>>> commit: 2d2f3bb897a3de4190b1b6b296c3429d01327554 [2/2] arm64: run
>>>> softirqs on the per-CPU IRQ stack
>>>> config: arm64-randconfig-r023-20220907
>>>> compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project
>>>> 1546df49f5a6d09df78f569e4137ddb365a3e827)
>>>> reproduce (this is a W=1 build):
>>>>           wget
>>>> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
>>>> -O ~/bin/make.cross
>>>>           chmod +x ~/bin/make.cross
>>>>           # install arm64 cross compiling tool for clang build
>>>>           # apt-get install binutils-aarch64-linux-gnu
>>>>           #
>>>> https://github.com/ammarfaizi2/linux-block/commit/2d2f3bb897a3de4190b1b6b296c3429d01327554
>>>>           git remote add ammarfaizi2-block
>>>> https://github.com/ammarfaizi2/linux-block
>>>>           git fetch --no-tags ammarfaizi2-block arm64/linux/for-next/misc
>>>>           git checkout 2d2f3bb897a3de4190b1b6b296c3429d01327554
>>>>           # save the config file
>>>>           mkdir build_dir && cp config build_dir/.config
>>>>           COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1
>>>> O=build_dir ARCH=arm64 SHELL=/bin/bash arch/arm64/kernel/
>>>>
>>>> If you fix the issue, kindly add following tag where applicable
>>>> Reported-by: kernel test robot <lkp@intel.com>
>>>>
>>>> All warnings (new ones prefixed by >>):
>>>>
>>>>>> arch/arm64/kernel/irq.c:81:6: warning: no previous prototype for function 'do_softirq_own_stack' [-Wmissing-prototypes]
>>>>      void do_softirq_own_stack(void)
>>>>           ^
>>>>      arch/arm64/kernel/irq.c:81:1: note: declare 'static' if the function
>>>> is not intended to be used outside of this translation unit
>>>>      void do_softirq_own_stack(void)
>>>>      ^
>>>>      static
>>>
>>>
>>> I think we are missing an "#include <asm/softirq_stack.h>"
>>> in arch/arm64/kernel/irq.c
>>
>> Indeed. Hi Catalin, do I need to resend the v4 version? Or can you help
>> me to apply the following code change to the for-next/misc directly?
>> Both are fine for me, depending on which way is convenient for you. :)
> 
> I'll fold this in, that's the easiest.

Thank you very much! :)

> 
> Thanks.
> 

-- 
Thanks,
Qi