Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: ewYlTomsdmGOC+i0S46HiHOg+4PJnjJrhpnE5OCT3KE5PA7Cc0se96f8c3JrRS8t+2YneCHSGh
 DroIDg7jUPJJQyd210wQt6WfFWNlJokIzBiy7IEoRurapEuYuwcUh+XuYftmQdcroQk1WcU66Q
 cVNomDA1UXqWxd+vm2bJFAPNzf4ksU7fQtRKpjrhiflH03fRX6iEEhpbvij9exsaapt6ckN0le
 dd4+wGEIW87jW/y6tuaxAWB4XNszzX0uTFkA12ulpjYWSNtHhZzaVcpQGxZJQsNhDLPKpMwMWV
 ePtaR+3EC/D19zik2p+9Q47r
IronPort-SDR: DFncbpgrrPnXT2K8VtQpTZGSGBNsbz+EFTB0VfGcNo0PgE20EHD1gLGHBlHNUnZbtKcwQl7jJR
 5clIByephv1ig85XC0yQoWHx+bZ5sDd/cisrBD/rtStB/mB27D0Yk2f0OjNuu+cr7eOGh33OoL
 sCamLbkcP0FxpP3EyIQnBButJojqnmv64coC7sFWV2JGVxGNKVwiT3qQJXaeO3iXXpsL4RQCMh
 47VZ4q8LYr2BrkGOsqtHmQhKNqFG8GFL0CugKrLwM8guZ0rhDpYq9+ldGty/ETbKHAGMJzgkgK
 7po=
WDCIronportException: Internal
Message-ID: <3597fe1a-aca3-b854-ae30-f5d069c5003b@opensource.wdc.com>
Date:   Sat, 10 Sep 2022 17:24:27 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.2.1
Subject: Re: [PATCH] drivers/ata: fix repeated words in comments
To:     James Bottomley <James.Bottomley@HansenPartnership.com>,
        Conor.Dooley@microchip.com, wangjianli@cdjrlc.com
Cc:     linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220908124937.25962-1-wangjianli@cdjrlc.com>
 <e2f882f7-6871-a754-fbbd-6a5201f45f4a@microchip.com>
 <3a73cf7f02915891c77dc5a3203dc187f6d91194.camel@HansenPartnership.com>
Content-Language: en-US
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <3a73cf7f02915891c77dc5a3203dc187f6d91194.camel@HansenPartnership.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/09/08 22:02, James Bottomley wrote:
> On Thu, 2022-09-08 at 12:56 +0000, Conor.Dooley@microchip.com wrote:
>> On 08/09/2022 13:49, wangjianli wrote:
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you
>>> know the content is safe
>>>
>>> Delete the redundant word 'in'.
>>>
>>> Signed-off-by: wangjianli <wangjianli@cdjrlc.com>
>>> ---
>>>   drivers/ata/libata-eh.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
>>> index 7c128c89b454..ca865a95cf24 100644
>>> --- a/drivers/ata/libata-eh.c
>>> +++ b/drivers/ata/libata-eh.c
>>> @@ -863,7 +863,7 @@ void ata_eh_fastdrain_timerfn(struct timer_list
>>> *t)
>>>    *
>>>    *     Set ATA_PFLAG_EH_PENDING and activate fast drain if
>>> @fastdrain
>>>    *     is non-zero and EH wasn't pending before.  Fast drain
>>> ensures
>>> - *     that EH kicks in in timely manner.
>>> + *     that EH kicks in timely manner.
>>
>> Hey wangjianli,
>> This does not look like the right fix to me.. To me, it looks like it
>> should be s/in in/in in a/.
>>
>> If you're using an automated tool, which I can only assume you are,
>> to find these typos it'd be a good idea to check the output for
>> correctness prior to sending patches.
> 
> And it would also have been nice to accommodate the exact same feedback
> last time these patches were posted:
> 
> https://lore.kernel.org/all/cec12e246d7151f6041bf553629a3047e81d4afe.camel@HansenPartnership.com/
> 
> It's really disappointing you haven't accommodated any feedback either
> into your bot or the patches it sends.  Not doing so really does render
> this work largely useless.

And another submitter sent a similar incorrect "fix", twice, ignoring my
comments. I am OK with applying such fixes, even though they have little value.
But the submitter has to be willing to listen and fix their patches. I will not
do that for them :)


-- 
Damien Le Moal
Western Digital Research