Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 10 Sep 2022 10:48:58 +0200
From:   "niklas.soderlund@corigine.com" <niklas.soderlund@corigine.com>
To:     Joe Perches <joe@perches.com>
Cc:     Philippe Schenker <philippe.schenker@toradex.com>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "dwaipayanray1@gmail.com" <dwaipayanray1@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "lukas.bulwahn@gmail.com" <lukas.bulwahn@gmail.com>,
        "apw@canonical.com" <apw@canonical.com>,
        "sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
        "louis.peens@corigine.com" <louis.peens@corigine.com>,
        "simon.horman@corigine.com" <simon.horman@corigine.com>,
        "oss-drivers@corigine.com" <oss-drivers@corigine.com>
Subject: Re: [PATCH v4] checkpatch: warn for non-standard fixes tag style
Message-ID: <YxxPepPX8Vp91XEA@oden.dyn.berto.se>
References: <20220908164434.122106-1-niklas.soderlund@corigine.com>
 <3275d886491dc934e3277cde9cc766b0ce0886ea.camel@toradex.com>
 <Yxrt1aa60xY0H7j0@oden.dyn.berto.se>
 <9f9a0740aef282d30af8fa02ca7c6479e80aa9a0.camel@perches.com>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <9f9a0740aef282d30af8fa02ca7c6479e80aa9a0.camel@perches.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?SLHNWQOFkCRnLFLj/obCq7GqQzWT5y21tk1ZYbM9KNBmvmvemZPzf0MlPJ?=
 =?iso-8859-1?Q?WBOP296Bl/f6sWuViU9OA28+n4ZXHxXAJysX6/1ufhSHcpwZe9gzYOLRDB?=
 =?iso-8859-1?Q?rSlx8kxNZhM52jNrXWxC+2x9I8LbjII3lkWh/nhCJPd2Wy6mJFYrvLJ4v1?=
 =?iso-8859-1?Q?kRdFiskeQpT1H87suRkJZlIVwEMiEeb3ad2MWLCztoSoYV0UGpns9Mu+RR?=
 =?iso-8859-1?Q?WV+RgSnvSTDI3aOqXfHvSHUdYZ8dsoZnf+pGtk95T/dNbvHKS2znwsO2xW?=
 =?iso-8859-1?Q?Qkn8yl2kSupIAxXxIbhnvLYwNFSCBrQGdSBETgRocIeQ+WzpNQwCWJwhrC?=
 =?iso-8859-1?Q?imdnDnfU6ZYfYTLOeyRHXKdqwS1vkR1rFTDWO1h/tbAWd+bdNj08tQnSiU?=
 =?iso-8859-1?Q?sftPKkMuV0ii2b7aTSpOwsfcdc7XpcuAxol8q8nHwmjpxYxO1hejeYsDWp?=
 =?iso-8859-1?Q?LwNzAp21XaDoKeM6yKy3Rbl9WsdhaETZAZnh3Rpl7atwpQA/EkE3aSKSsI?=
 =?iso-8859-1?Q?7mMIi2afXiH+8zgDPBu2zn/gIQJYLNQ/l8dx9pxaTv6T2IAa6MNOkOdvW3?=
 =?iso-8859-1?Q?Tbbay+W3rGmr7Y7F3lD+gxO0h3y9xay0I4JIxJ6xQQg6USmSstC+Cj1Iwo?=
 =?iso-8859-1?Q?kF7mvdQoxJLZuw8K8sIKAS9DWo86GSSllgkyXcMA+p1DjifI5OY6A2dnaT?=
 =?iso-8859-1?Q?IwxDoSpZ/NxtZTWQrdhh/gogvTkz7Gj4cAABM/WWSv1QAEyoDJ/Xc4esxQ?=
 =?iso-8859-1?Q?HOYM8SfUk6rrtlveGQqs8cg/0JI92BepyvvUnARha2DKVCjZ3IMdQz2HvC?=
 =?iso-8859-1?Q?Z2ObU2DroeUyWpMjqsnk7Xoo2TSzc6q2i6gtdc2MTXg+o5BQOO5hFldZ3C?=
 =?iso-8859-1?Q?l/XmuKWqlaKJJcIzPjH6xA6EVmsczQi2l1QJLLxPbb6QV44FZ70Ef2aNMf?=
 =?iso-8859-1?Q?VYL/+3rzQJGBybstXJCGXAMhPnrm42LQ6k5xVYC8WWNsRmkFTdAhN9DamU?=
 =?iso-8859-1?Q?gN7O0PxKvzBTT5UPAlRu5Jne1LuBGKKOdYr65ptgw26ACR9RQOBd+QVr/w?=
 =?iso-8859-1?Q?f3JL90MG2lkpj5LffzRdGjaV17mHQR1NrnyJdwmi/TuZwac4QUCpm8f4hg?=
 =?iso-8859-1?Q?MQ4KwIIVlbl++BAmcVGzQLpOvMl/RnF+65IimUl1MT8ZNnvGWE2i7V/Lms?=
 =?iso-8859-1?Q?m4n4DARw9K62W41IKMlqb5JqrcerxSTH1OY17L3CQe0c7vpcCk/2n+Flym?=
 =?iso-8859-1?Q?KweIr8/Gy+LRyo+pyALDoBvVBXedpREQE75akiS5xW6vhS0S92vZpKojTD?=
 =?iso-8859-1?Q?X6PMDRicFw6s3vqlQiDRepMkviWNXUzJib9ll05eDdzstV8LgQpHfEcNsm?=
 =?iso-8859-1?Q?spSXGaU1pHeYYPHzsyn0AWLyyhhfVL+f+WEfiPNUcZBT3FhK3gWqQSsDWS?=
 =?iso-8859-1?Q?1a+f27l4vNLSQ5XEluqApvwQUFDAoQYcwGGVpGEpWHJ7FJMwVQJkYN+vVl?=
 =?iso-8859-1?Q?6AUvHDfTQmHeeqRc5xrkQJamz7LEtAmiw5vkC+BMkchBRIuKlBCrdgp0HL?=
 =?iso-8859-1?Q?aMqJvOCVAh8J+RvaR0VOSA6u3gsCTuoFwv7pO0v6D/8objaxT09Y6kKCSf?=
 =?iso-8859-1?Q?ecjkH8uR/77QlIijMPB18BE3sC32tLwYJw5EJaiYXkSn1IX2dQgStioA?=
 =?iso-8859-1?Q?=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR13MB5540
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID,
        DKIM_SIGNED,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Joe,

Thanks for your feedback.

On 2022-09-09 10:57:10 -0700, Joe Perches wrote:
> I think it's better to make sure that there is a likely SHA1 of some
> minimum length after the fixes line.
> 
> And a relatively common defect is to have the word "commit" after fixes.
> 
> e.g.:
> 
> Fixes commit 554c0a3abf216 ("staging: Add rtl8723bs sdio wifi driver").
> Fixes commit a2c60d42d97c ("Add files for new driver - part 16").
> 
> So maybe:
> 
> 	if (!$in_header_lines &&
> 	    $line =~ /^\s*fixes:?\s*(?:commit\s*)?[0-9a-f]{5,}\b/i)

I'm sorry I just sent out v6 and missed this comment, which I think is a 
great idea. I will let v6 stew for a day or two in case there is other 
feedback and then spin a v7 with this addressed.

-- 
Kind Regards,
Niklas S?derlund