Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: icd3146c6:Fastmail
User-Agent: Cyrus-JMAP/3.7.0-alpha0-927-gf4c98c8499-fm-20220826.002-gf4c98c84
Mime-Version: 1.0
Message-Id: <17ef2c79-b5e8-43f0-886f-641ce45f18ee@www.fastmail.com>
In-Reply-To: <d2fd289d-a5b5-f0af-3125-417ba9d242f0@linux.dev>
References: <20220909092107.3035-1-oss@lmb.io>
 <d2fd289d-a5b5-f0af-3125-417ba9d242f0@linux.dev>
Date:   Sat, 10 Sep 2022 12:02:41 +0100
From:   "Lorenz Bauer" <oss@lmb.io>
To:     "Martin KaFai Lau" <martin.lau@linux.dev>
Cc:     bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
        "Alexei Starovoitov" <ast@kernel.org>,
        "Daniel Borkmann" <daniel@iogearbox.net>,
        "Andrii Nakryiko" <andrii@kernel.org>,
        "Song Liu" <song@kernel.org>, "Yonghong Song" <yhs@fb.com>,
        "John Fastabend" <john.fastabend@gmail.com>,
        "KP Singh" <kpsingh@kernel.org>,
        "Stanislav Fomichev" <sdf@google.com>,
        "Hao Luo" <haoluo@google.com>, "Jiri Olsa" <jolsa@kernel.org>
Subject: Re: [PATCH bpf] bpf: btf: fix truncated last_member_type_id in
 btf_struct_resolve
Content-Type: text/plain
Precedence: bulk

On Fri, 9 Sep 2022, at 19:17, Martin KaFai Lau wrote:
>
> The fix tag should be
>
> Fixes: a0791f0df7d2 ("bpf: fix BTF limits")

Ah, thanks very much! Sent a v2.

> The change makes sense.
>
> The kernel's vmlinux and module btf parsing doesn't go through this 
> resolve check though.  Are you trying to __sys_bpf(BPF_BTF_LOAD) the btf 
> from the vmlinux file into the kernel ?

Yes, with the twist that the BTF was serialised by github.com/cilium/ebpf instead of libbpf.