Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <32422d2a-993e-c351-5f0e-788e28b09335@efficios.com>
Date:   Sat, 10 Sep 2022 09:35:51 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [RFC PATCH 2/2] Revert "csky: Add support for restartable
 sequence"
Content-Language: en-US
To:     Guo Ren <guoren@kernel.org>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        paulmck <paulmck@kernel.org>, Boqun Feng <boqun.feng@gmail.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        "linux-csky@vger.kernel.org" <linux-csky@vger.kernel.org>
References: <20210723161600.19688-1-mathieu.desnoyers@efficios.com>
 <20210723161600.19688-2-mathieu.desnoyers@efficios.com>
 <CAJF2gTR9_SzAm2kPXyP+xJDVmdvM=XSm7kJn_eNq-wQmhLqTeg@mail.gmail.com>
 <2070284546.6496.1627316900287.JavaMail.zimbra@efficios.com>
 <cbd08ae8-4558-60e3-17e4-988e625984a1@efficios.com>
 <CAJF2gTRbn-JiUMiX_s52geJSiTs7qYV3oEkW1+NC8Vwp1YAKvg@mail.gmail.com>
From:   Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
In-Reply-To: <CAJF2gTRbn-JiUMiX_s52geJSiTs7qYV3oEkW1+NC8Vwp1YAKvg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmRwN0lkeVh0MjRFclp1aXlzcldoUE1WWStuNVh3akgrMXBGVXl6bHRCQUVn?=
 =?utf-8?B?N0JVTUxKL3VBSVliSlZ2bnpuNGFQeUN2ZHptSFZKYW5xay9reHVrRUdLQnVs?=
 =?utf-8?B?WFdscUhnQWYwdjYydWtXYlE2N0NuWmFpQmpBNTRsdkFwYlYrN1daeFRQQlBM?=
 =?utf-8?B?Slg0MUF5SEFEdWFud2J5L2Y3WGMvb1FmdHdTQTZ2MDcyekRwZm95dEZSRGsz?=
 =?utf-8?B?UWh6amx6VHFhSW5NVWpiWGtmM1lmME1wcCtneXFaMWxLRjhtZFZwOW96cGRM?=
 =?utf-8?B?QUdERzNrOXB6TVNCNG5xRkdWaUNSaDBmaVZxUDJmczM3cUJwcVpuYjVMQm1z?=
 =?utf-8?B?bDRKL1JaWlFkQkh6Qmh0WGpBbUdFZE1TbHplMlpJQnVmcWpUem9WM09IQ3o4?=
 =?utf-8?B?cE9sQWRFbXZ2YTB1TE5kSzdhSzZpOS9TYlBQa0x6OVhXRWFtK293VGxFcS9U?=
 =?utf-8?B?TGsvMVhpbzQxS3ZmL01uRjdVNWd6YmVrcHFvUkR0azVIQVJtSEVLeWNmWlor?=
 =?utf-8?B?TCtBU2kwV0tDWi8rOWFyU3pFYlMxZW9Vcys4RFNDcDg5QkFibjBsRTQvakhy?=
 =?utf-8?B?VUZuNXl1dDRWWTlvc3Q4SnpwYVRibXJwRmhJR1E3Z3FWcGgrTmVGdkxTb3Rs?=
 =?utf-8?B?TnFXeWE4S2N1MXBRcndSd21hckJObGd6alZaV0QvNXF2ZjcxOHAxUENVL1JR?=
 =?utf-8?B?ZnYyRjU1NmU3WVpNajc5dnQ0SnluWk02UlkzYmp4amFEbGhMTTB1T25oRWZ3?=
 =?utf-8?B?Z01kK1Mwc1diU3c4T0U3R0h6YWtNU3hpMkl4UnVQUjRaYTNWSCtjYlFVaFhV?=
 =?utf-8?B?UWdVTVhKNFJDb1EyV1FmUjJWNHBPcTFZM2pVcFZveWZ3WnJWU1dwOXNJbUJZ?=
 =?utf-8?B?UFRTbVVGVURRYmcyYzJXVHlaV1o5Tkd5R25GMjROZWxsNnFVQTVGRVFkM1Qw?=
 =?utf-8?B?WGZSSzhlQjNNMFZxTDVVT0xvaFNvekg0Q2VONGUza1dzK3BobXdGajRuaGNK?=
 =?utf-8?B?UythdW9TYkJGbGVOMVc1OHhiVzk3dktPKzhZU2NYaTB2emVaT3pOMHpkWkZP?=
 =?utf-8?B?VExWTlpZUldCTGRUZ3V5Y1FycTlYcENWUWpIWkk1ZDloQlFjeGtPWW1haGxt?=
 =?utf-8?B?dXB2NTFUSFJYQWlsYW04cW9nOXpqeDVUejR6Tmxudkl4TXlIQ0E3aGljdmwv?=
 =?utf-8?B?Q3M1NXdpYldGSEovQVpKWVVKaGJtekF0cEkyZVAzQ3dvNSs3Si9CNzFrSytV?=
 =?utf-8?B?MHNLakhuVEF3YTB4b0NHY04rUVJNelFxWW5nRzdVQnNUVFpTY05ySFBVUURJ?=
 =?utf-8?B?S1lyRm1zaDNNSlFJZ0o2ZDdoQ0hhRUNPMVl1Nkh2MURBY3JVZGNKVGNhd1Zr?=
 =?utf-8?B?L2czdmF1ZWxteW92M2FPbE5yUnVlaGtUYTdhR2RCZ0thZGVrYkxYTDlwN29H?=
 =?utf-8?B?Unk2NXVHcVdVbTNJV1BsUEpTWGo0dWNtYzA3bElzL0ZBU1RnYlB3a3d5OFQ1?=
 =?utf-8?B?bXZHclgvOFlBaG5wRktzUjQ4alorSDJQOGxZT3ZtRVozV0hQQm5FczFlNHBt?=
 =?utf-8?B?R05lMVFEeHk2d3M3c203alE4UFJDVDk1elYra1hCTmFxcVJUMCtCZldNeGtu?=
 =?utf-8?B?a05jUlhPZkViNzdMNHFuWnBYWmNyRVdjTmZ2S1V4cGtlWlh6d0FhMmxwOW1E?=
 =?utf-8?B?bGNmd0dZUkxwY2hwNGg5YWJlQmlYSkZ6RlJ0dmRGSDFmSDdWMGZBOTExUy9B?=
 =?utf-8?B?cjdyVFF0WXgrbGY4N2tqRlpPdkN0eDFWZUFMWFhJVGZuOXplU1ZOVmRsQSt0?=
 =?utf-8?B?RzgyL2dUd3pTSVJlVUV6ZEphbUNYQkJIWUwwemdrUFpTd2JSY05Bb3JPT1NH?=
 =?utf-8?B?dEYxZVJxYXRDREk1alVGUmhMSVZqUTFhNmdrNm4xYUg3dFFjS3BNNk5qUjFq?=
 =?utf-8?B?cmtIc1NjVEt1MEdmampiV0F6ZUJMZTlTOHR5d0lINjd1b1hZRHY0eEs5QlNX?=
 =?utf-8?B?WTdJVFBZaGdJcmt2QWhQTnBORWY3U3Z2bkRtN2hQczh3SDQzR1V3M3dsSGRv?=
 =?utf-8?B?UG5nVUtTNnhKK2t4c2p0UE0yaGhraWNaUXpmR2c1b1JWdll1SlNZc0VKclll?=
 =?utf-8?B?bndUbk9WV3V1d2V0VGI3OFFQUndBbWxHUnlCdHRjcXVhQWVHOUc3VEQxNG0y?=
 =?utf-8?B?bkE9PQ==?=
X-OriginatorOrg: efficios.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 53e462ed-cce9-49c6-f5b1-08da93314b90
X-MS-Exchange-CrossTenant-AuthSource: YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2022 13:35:15.8849
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Y6ulb4Dz56LF4dq8LhkTnbpRZ1cB6KwgMRvY4d/3dMUOhiAYsE+0HOXKMZkjKzZLo76gHbIKizODYiesZNLrpaCDAC7wHGO50Jyr8t/QcX0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB8612
X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-09-09 22:35, Guo Ren wrote:
> On Sat, Sep 10, 2022 at 4:01 AM Mathieu Desnoyers
[
>> A friendly ping after 1.5 year about the fact that the selftests code is
>> still missing for the csky architecture. So there is no way to validate
>> that the kernel pieces that were merged actually work on that architecture.
>>
>> What is the timeline for contribution of the missing bits needed to enable
>> those tests ?
> I would send the 1st version of patchset before 2022/10/30, or just
> revert it from csky.

OK. I can help by answering questions or with code review. I'm not 
fluent in csky assembly, but I'll try to learn as I go.

> 
> 1. a patch for fixup the bug:
> diff --git a/arch/csky/kernel/signal.c b/arch/csky/kernel/signal.c
> index b7b3685283d7..434dcf2e8e37 100644
> --- a/arch/csky/kernel/signal.c
> +++ b/arch/csky/kernel/signal.c
> @@ -179,8 +179,6 @@ static void handle_signal(struct ksignal *ksig,
> struct pt_regs *regs)
>          sigset_t *oldset = sigmask_to_save();
>          int ret;
> 
> -       rseq_signal_deliver(ksig, regs);
> -
>          /* Are we from a system call? */
>          if (in_syscall(regs)) {
>                  /* Avoid additional syscall restarting via ret_from_exception */
> @@ -206,6 +204,8 @@ static void handle_signal(struct ksignal *ksig,
> struct pt_regs *regs)
>                  }
>          }
> 
> +       rseq_signal_deliver(ksig, regs);
> +
>          /* Set up the stack frame */
>          ret = setup_rt_frame(ksig, oldset, regs);

Yes, this fix is really needed.

> 
> 2. Add tools/testing/selftests/rseq/rseq-csky* codes.

It looks like a good plan,

Thanks,

Mathieu


> 
> 
> 
>>
>> Here are the required header files:
>>
>> tools/testing/selftests/rseq/rseq-csky.h
>> tools/testing/selftests/rseq/rseq-csky-thread-pointer.h (only if __builtin_thread_pointer is not implemented by gcc)
>>
>> I'm open to suggestions from other rseq co-maintainers on how to best address
>> this situation.
>>
>> Thanks,
>>
>> Mathieu
>>
>> --
>> Mathieu Desnoyers
>> EfficiOS Inc.
>> https://www.efficios.com
> 
> 
> 


-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com