Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 10 Sep 2022 15:35:59 +0100
Message-ID: <87y1urpa9c.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Frank Li <frank.li@nxp.com>
Cc:     "tglx@linutronix.de" <tglx@linutronix.de>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kw@linux.com" <kw@linux.com>,
        "bhelgaas@google.com" <bhelgaas@google.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        Peng Fan <peng.fan@nxp.com>,
        Aisheng Dong <aisheng.dong@nxp.com>,
        "jdmason@kudzu.us" <jdmason@kudzu.us>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "kishon@ti.com" <kishon@ti.com>,
        "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
        "ntb@lists.linux.dev" <ntb@lists.linux.dev>,
        "lznuaa@gmail.com" <lznuaa@gmail.com>,
        "imx@lists.linux.dev" <imx@lists.linux.dev>,
        "manivannan.sadhasivam@linaro.org" <manivannan.sadhasivam@linaro.org>
Subject: Re: [EXT] Re: [PATCH v9 2/4] irqchip: Add IMX MU MSI controller driver
In-Reply-To: <AM9PR04MB8793746D9ECC6F07FD5B841888439@AM9PR04MB8793.eurprd04.prod.outlook.com>
References: <20220907034856.3101570-1-Frank.Li@nxp.com>
        <20220907034856.3101570-3-Frank.Li@nxp.com>
        <87fsh2qpq4.wl-maz@kernel.org>
        <AM9PR04MB879338D6D4B55A74CD002E6D88409@AM9PR04MB8793.eurprd04.prod.outlook.com>
        <877d2dvs0d.wl-maz@kernel.org>
        <AM9PR04MB8793CE5AAAB281CE628845AC88409@AM9PR04MB8793.eurprd04.prod.outlook.com>
        <87edwkrbs4.wl-maz@kernel.org>
        <AM9PR04MB8793746D9ECC6F07FD5B841888439@AM9PR04MB8793.eurprd04.prod.outlook.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 09 Sep 2022 15:59:01 +0100,
Frank Li <frank.li@nxp.com> wrote:
> 
> > >
> > > [Frank Li] According to my understand, raw_spinlock skip some lockdep
> > > /debug feature to get better performance, which should be used when
> > > Frequently call, such as irq handle\polling thread.
> > 
> > I'm afraid you are terribly misguided. They both have the same debug
> > features because they are both using the same core implementation, and
> > the only difference is whether this is preemptible for RT purposes or
> > not.
> > 
> > > Spinlock have DEBUG feature to check wrong use lock.  Allocate MSI
> > generally
> > > only is call once when driver probe.
> > 
> > Again, you should really read the code and the documentation and stop
> > making things up.
> 
> [Frank Li] Thanks. You give me the correct direction. Some stackoverflow's
> Doc was misleaded.  I double checked spin_lock implementation.  PREEMPT_RT
> Kernel map spin_lock to rt_mutex.
> 
> I am curious  why exist spin_lock_irqsave and raw_spin_lock_irqsave before
> PREEMTP_RT merge into kernel tree. 

Because the RT merge has been going on for 10 years or so, long before
CONFIG_RT was merged. Also, a mutex has a spin lock at its core, and
it makes sense to have a single primitive for all these lock types.

	M.

-- 
Without deviation from the norm, progress is not possible.