Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp3600102rwn; Sat, 10 Sep 2022 15:54:01 -0700 (PDT) X-Google-Smtp-Source: AA6agR74nTTWjjjfpSZUa+OSQmgPKGnUbedyUleRL+SfcAlFYfbZgCxxPKNY+zzHF7oCW3ROEe6w X-Received: by 2002:a17:90b:4f81:b0:1fe:591a:3c04 with SMTP id qe1-20020a17090b4f8100b001fe591a3c04mr17065740pjb.66.1662850441330; Sat, 10 Sep 2022 15:54:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662850441; cv=none; d=google.com; s=arc-20160816; b=safs8WfHntUMzU3Y5YV/jzJTXSpDc0gHiP9G8UxeR4Q9QYFrYw4GOgH0NsAMm4Glro LclA3gR/2vZqIL3VtkOMqVnC1mHS93zFApHf2lQESDyl73Vr6dO1OzgslvoYxLCMffpL VFPbsFythtlPyT78JaYOk8QWzfjk6dSqNmR6h5YUIkDcmXWv3iGcgfJtDIzUKYAeIhFb ZSMt/xnSxsFp9/mW8F6peWse+0UrN3qqXaaSsWBUFNJgnhAG8/yZXQBVUo0+BH2oDwzg 2N93NnEFQVCy4j8R1h+rdgf8Qxz1ycRT6vD0SEq8qOc7rNcU51EgEkwvtjvr0JXMrLUX juEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:mime-version:references:subject:cc:to:from :dkim-signature:dkim-signature:message-id; bh=E5VNsdhocstLmuIwTiCMPIibe4zDdVnAf/ePac5FTrs=; b=Cy7hZu3bpPBjd2fc9owFWZrjfE4raI5bzj5S6RirxKxEr34uSTpbV1kGBsSD5zH4wb 4AMs217NI8icueqSog2PCm5R/RlEyFg0E0Nh0T2KQEGi/VbfPzCA3jpRXwgv6NPN3KFJ 2OkIOwYVZAKcZQj5moVntzGCrUJoZpPgNI8Pdbeb/3sr8sNAh1vZbHkxEya4ZIZxyM9v 5lXwMvmwZWpzJhtO1tI1XXTLMhezkfNlVa2yvGTUQOZd96TJRm4OZrQG33YqdwEpidah xyiS9nOlXnMdjwE2/C9cTSnO73scECDVnXoMe7xq6kXaExTIAnz6QD+8r0Z8tOBV53Ma cq9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=Zy3HnUi2; dkim=neutral (no key) header.i=@linutronix.de header.b=FW65dlnu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m11-20020a654c8b000000b00438854c876dsi4625828pgt.553.2022.09.10.15.53.49; Sat, 10 Sep 2022 15:54:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=Zy3HnUi2; dkim=neutral (no key) header.i=@linutronix.de header.b=FW65dlnu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230028AbiIJW1r (ORCPT + 99 others); Sat, 10 Sep 2022 18:27:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229640AbiIJW1i (ORCPT ); Sat, 10 Sep 2022 18:27:38 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9323738474 for ; Sat, 10 Sep 2022 15:27:37 -0700 (PDT) Message-ID: <20220910222300.466273303@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1662848855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=E5VNsdhocstLmuIwTiCMPIibe4zDdVnAf/ePac5FTrs=; b=Zy3HnUi2VBS5ut9uhR/yxiVuE5M61YjpLA/xPSpsVmYTNqV9p1HHw6cB+/BmwvbvS24vk9 IXDNJmqT1Xe0owRlb//4pc09RTWehYtFXH1BrH2NPDemslzdvI6AeOTfzT1MgCokpYDKXu ijPjGyH+G2WfmZ7QX2ggS/onqNdrBwKvMxjI36H1TZNVjj6UOIkpHSBRhpN5AR5XzAiOBi TqCMSn9Qh4VYejlys4zK5yhUO5ia1wMOUTFQSWtvkmN0pJVBxGEEYfXFbEBOiT01lJMIoN ZdMFegZcBoiBeIbeKQ8qllxcTH6MuyVadZ9fcei/utfLciJhmnFdGH6+4cCKtQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1662848855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=E5VNsdhocstLmuIwTiCMPIibe4zDdVnAf/ePac5FTrs=; b=FW65dlnuCZ6asy8+cb0W/jTJqUbzHFWiipkPt5DjzbMJfAqlNSVG5p7HeFUfebCJj9UYNm VrtaqLn3el0Lq/CQ== From: Thomas Gleixner To: LKML Cc: John Ogness , Petr Mladek , Sergey Senozhatsky , Steven Rostedt , Linus Torvalds , Peter Zijlstra , "Paul E. McKenney" , Daniel Vetter , Greg Kroah-Hartman , Helge Deller , Jason Wessel , Daniel Thompson Subject: [patch RFC 02/29] printk: Declare log_wait properly References: <20220910221947.171557773@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Sun, 11 Sep 2022 00:27:34 +0200 (CEST) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org kernel/printk/printk.c:365:1: warning: symbol 'log_wait' was not declared. Should it be static? Signed-off-by: Thomas Gleixner --- fs/proc/kmsg.c | 2 -- include/linux/syslog.h | 3 +++ 2 files changed, 3 insertions(+), 2 deletions(-) --- a/fs/proc/kmsg.c +++ b/fs/proc/kmsg.c @@ -17,8 +17,6 @@ #include -extern wait_queue_head_t log_wait; - static int kmsg_open(struct inode * inode, struct file * file) { return do_syslog(SYSLOG_ACTION_OPEN, NULL, 0, SYSLOG_FROM_PROC); --- a/include/linux/syslog.h +++ b/include/linux/syslog.h @@ -8,6 +8,8 @@ #ifndef _LINUX_SYSLOG_H #define _LINUX_SYSLOG_H +#include + /* Close the log. Currently a NOP. */ #define SYSLOG_ACTION_CLOSE 0 /* Open the log. Currently a NOP. */ @@ -35,5 +37,6 @@ #define SYSLOG_FROM_PROC 1 int do_syslog(int type, char __user *buf, int count, int source); +extern wait_queue_head_t log_wait; #endif /* _LINUX_SYSLOG_H */