Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ca8d4f94-a106-dc56-893d-d32d43beed85@intel.com>
Date:   Sat, 10 Sep 2022 16:09:55 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [RFC] x86/mm/dump_pagetables: Allow dumping pagetables by pid
Content-Language: en-US
To:     lizhe.67@bytedance.com, dave.hansen@linux.intel.com,
        luto@kernel.org, peterz@infradead.org
Cc:     linux-kernel@vger.kernel.org, lizefan.x@bytedance.com,
        yuanzhu@bytedance.com
References: <20220804070401.86524-1-lizhe.67@bytedance.com>
From:   Dave Hansen <dave.hansen@intel.com>
In-Reply-To: <20220804070401.86524-1-lizhe.67@bytedance.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/4/22 00:04, lizhe.67@bytedance.com wrote:
> In current kernel we can only dump a user task's pagetable
> by task itself. Sometimes we need to inspect the page table
> attributes of different memory maps to user space to meet
> the relevant development and debugging requirements. This
> patch helps us to make our works easier. It add two file
> named 'pid' and 'pid_pgtable_show'. We can use 'pid' to
> input the task we want to inspect and get pagetable info
> from 'pid_pgtable_show'.
> 
> User space can use file 'pid' and 'pid_pgtable_show' as follows.
> ====
> $ echo $pid > /sys/kernel/debug/page_tables/pid
> $ cat /sys/kernel/debug/page_tables/pid_pgtable_show

This seems a wee bit silly considering that we have /proc.  It's also
impossible to have an ABI like this work if multiple processes are
trying to dump different pids.

Are there any other per-process things in debugfs where folks have done
something similar?