Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 10 Sep 2022 19:40:21 -0400
From:   William Breathitt Gray <william.gray@linaro.org>
To:     Julien Panis <jpanis@baylibre.com>
Cc:     linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        mranostay@ti.com, fabien.lahoudere@collabora.com,
        gwendal@chromium.org, enric.balletbo@collabora.com,
        bleung@chromium.org, groeck@chromium.org, jic23@kernel.org,
        david@lechnology.com, robertcnelson@gmail.com
Subject: Re: [RFC PATCH 2/2] counter: Introduce the COUNTER_COMP_ARRAY_U64
 component type
Message-ID: <Yx0gZXvZX7Os2f0q@ishi>
References: <cover.1661785438.git.william.gray@linaro.org>
 <31a35481813ec26949018888253278a634998a92.1661785438.git.william.gray@linaro.org>
 <82ec09fd-a940-cae6-f793-1bb903190664@baylibre.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="SVgqqGCgr8ExcmSD"
Content-Disposition: inline
In-Reply-To: <82ec09fd-a940-cae6-f793-1bb903190664@baylibre.com>
Precedence: bulk


--SVgqqGCgr8ExcmSD
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Sep 06, 2022 at 04:41:16PM +0200, Julien Panis wrote:
>=20
>=20
> On 29/08/2022 17:17, William Breathitt Gray wrote:
> > The COUNTER_COMP_ARRAY_U64 Counter component type is introduced to
> > enable support for Counter array components. With Counter array
> > components, exposure for buffers on counter devices can be defined via
> > new Counter array component macros. This should simplify code for driver
> > authors who would otherwise need to define individual Counter components
> > for each array element.
> >=20
> > Three Counter array component macros are introduced::
> >=20
> >          COUNTER_COMP_DEVICE_ARRAY_U64(_name, _read, _write, _length)
> >          COUNTER_COMP_COUNT_ARRAY_U64(_name, _read, _write, _length)
> >          COUNTER_COMP_SIGNAL_ARRAY_U64(_name, _read, _write, _length)
>=20
> Hi William,
>=20
> I have 2 comments :
>=20
> 1) What about ENUM ? I guess that it will not be possible to handle ARRAY=
 of
> ENUM ?
> =A0=A0=A0 That would be useful for polarity0/1/2/3 in my ECAP driver
> =A0=A0=A0 (something like COUNTER_COMP_SIGNAL_ARRAY_ENUM for instance)
>=20
> 2) I made some tests with COUNTER_COMP_COUNT_ARRAY_U64
> =A0=A0=A0=A0=A0=A0=A0 COUNTER_COMP_COUNT_ARRAY_U64("capture", ecap_cnt_ca=
p_read, NULL,
> ECAP_NB_CEVT)
> =A0=A0=A0 I can get consistent data value when using 'cat captureX' linux
> commands.
> =A0=A0=A0 But I get weird values when using watches from userspace applic=
ation
> code (I will send my test results to you).
>=20
> Julien Panis

I have an idea that might work for supporting enum types, so I'll try to
implement support for that in v2. I was also able to track down the bug
you found so I'll have that fixed as well.

William Breathitt Gray

--SVgqqGCgr8ExcmSD
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCYx0gZQAKCRC1SFbKvhIj
K/5lAP9r6caRdRfG+OCSEGPGWpGgz991ELuJCsYVwlZWIxqXfgEA2N+aDzsizaex
lmvM0bTrCjEsDdWuxeeKiE/Org4B0wM=
=/rSA
-----END PGP SIGNATURE-----

--SVgqqGCgr8ExcmSD--