Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 11 Sep 2022 11:56:24 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     Andrey Konovalov <andreyknvl@gmail.com>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Christoph Lameter <cl@linux.com>,
        Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Hyeonggon Yoo <42.hyeyoo@gmail.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        Jonathan Corbet <corbet@lwn.net>,
        "Hansen, Dave" <dave.hansen@intel.com>,
        Linux Memory Management List <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>,
        kasan-dev <kasan-dev@googlegroups.com>,
        "Sang, Oliver" <oliver.sang@intel.com>
Subject: Re: [PATCH v5 3/4] mm: kasan: Add free_meta size info in struct
 kasan_cache
Message-ID: <Yx1caGQ8R2alhOKh@feng-clx>
References: <20220907071023.3838692-1-feng.tang@intel.com>
 <20220907071023.3838692-4-feng.tang@intel.com>
 <CA+fCnZeT_mYndXDYoi0LHCcDkOK4V1TR_omE6CKdbMf6iDwP+w@mail.gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CA+fCnZeT_mYndXDYoi0LHCcDkOK4V1TR_omE6CKdbMf6iDwP+w@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0auiaTjlBN7p9OggMBAzVEZMpTLs6KW57Ps80b1mr9Vjiub4D3rM+yeONqtF?=
 =?us-ascii?Q?sb/x8+k+NTrmCvS6dGWpEV+k156f9IlCTiDBm0TaVPnhW0lXBKm1lII9OHq/?=
 =?us-ascii?Q?gbfM76wL4Apr47gEtc4hnv2Amj8SD1KqidTs7vk8mWhxLu2mwmM0aOOwkjuQ?=
 =?us-ascii?Q?/UoQk5bx+cx1vTYKSJVFNhqFW8/tqZqkIjvEGSX5WmuXoN8DTXyR9hKm2Dsw?=
 =?us-ascii?Q?E35tpQY7hYpthE0sBgG2EOrR1gmEO/PAr9bn1w/tTnMVoRlhUBzt/z+0C9N8?=
 =?us-ascii?Q?lkWQCqF5YcI64ybsuKjbKhWwk1obL61lRl7IFjbvpOrEYYMVnM0Fb34IwOjC?=
 =?us-ascii?Q?i8QM/x9kjjCxI7h7mj2gB1iuBqYLW50EF/5KEO3LsPHBeVWzU7lhbemOJrDB?=
 =?us-ascii?Q?V4o3vvHcWButL80UdHxnblepw95zfmYQjmBsVp18oyfc8Df1UJlY91swXaEF?=
 =?us-ascii?Q?ds81PMTi10UaDLJ18D3PSLmv9v6pqx3RYmZbdPSX9ySVIRDH25vNTWeIHrJd?=
 =?us-ascii?Q?WnJ3+a6yuE/s3sPggW+/anDk0odLFekNIKb6wmpBBu1pVDByv0Oor8gH4Kys?=
 =?us-ascii?Q?Y+TdpTY3RrRthu40TdLcc+D+RlOKY7wflypyzF0C0cvi+v2BhX5aY3kP1kOB?=
 =?us-ascii?Q?1X3Cc514lLrONMTElnwipoD5ujKbhHPHAAnMopKld79gQ6Io+fCN2wKfKF0r?=
 =?us-ascii?Q?LgytJ+GqDWSZj7I0aEjZjmPOLnTPWhbqW/BXR17ksLifc7yIEVZolmQZg0sb?=
 =?us-ascii?Q?owVQPMDw56Tstzo+/zsunp62RC0/1vKeUGEGJ/RoXOX/kWA3lBNxlulftFiE?=
 =?us-ascii?Q?KgWsSQNRQtomUvw3TDkM4UMJLQ1YnrsuVwDaSfoqM47ZdZiQLs0b/IAzqPqA?=
 =?us-ascii?Q?+D7r796w6jgFXKM1OYWDRp6D4bOB2WMNTEN/dfvaoDdtkyzq+wmghszE+jNN?=
 =?us-ascii?Q?kPieXG151APpoR0EIGgwpnxMV/z+mPsayoMFCgMaV9qKGqTZSf8D4Y2CjdAk?=
 =?us-ascii?Q?CEXxF6HwfmbXDIsBYdynbtqEEevA7Fm9u/lkZe9PdvkfDlwpsUFGFzpSVVUJ?=
 =?us-ascii?Q?B07PTsF/4+/oAekZ72pIfr64GSLI5lLzcl5efoISOC7IxTrf14T9+41tdVsu?=
 =?us-ascii?Q?KjeK18rm6azbIlW3B+Nz7oaf9+6Hl34ZrmNapJc6CecggCDk1TjgEeWunzxn?=
 =?us-ascii?Q?z0h0MJk/PAnvrTgPf81DFqcuYJLnjGI29HtrEEEwukD2Y9A9nqw1zSCHEmNF?=
 =?us-ascii?Q?8ewjYN8VZyekaz7Hiv/ovwiOyeRnpEZV+oJIZO+PGB7oX1e5Oqz0sC67GAfF?=
 =?us-ascii?Q?h04IiRMih+b5zvVazGJ2c9Ho66DJTfsLIiWbMJWN+ebnrfmPhuZlScrFUH2D?=
 =?us-ascii?Q?vG6pcAoQAGfsmfwv0A6iWrQJptzGlWApCgFcr9okQlOcmunTskcsTVRITfEh?=
 =?us-ascii?Q?OIZsy0jPBzF0fpvcr7NEZUacbaaqgNb6FpAsY4CDMNUbjOwyb7PYw5Oiz26/?=
 =?us-ascii?Q?e+988Zv4PGqP68kXaujWQumPazeiMygVFMZNDgolj8u2pKbsXQtE32341XqC?=
 =?us-ascii?Q?f3ORwCT+LYXQFmbD3K1Vfk1d2ymg5zYaGO/nNXZR?=
X-MS-Exchange-CrossTenant-Network-Message-Id: aff0895b-abb5-4001-10de-08da93a9ad70
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2022 03:56:59.6935
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hxgjnm3XJx/8DQoOgzlSh9sjuXgtF3ggKbo3PiSr1xCOSqgcnlyDpr8e4OgGhGj+UMuUg9K2zRkS2/+9xUNYMw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7270
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andrey,

Thanks for reviewing this series!

On Sun, Sep 11, 2022 at 07:14:55AM +0800, Andrey Konovalov wrote:
> On Wed, Sep 7, 2022 at 9:11 AM Feng Tang <feng.tang@intel.com> wrote:
> >
> > When kasan is enabled for slab/slub, it may save kasan' free_meta
> > data in the former part of slab object data area in slab object
> > free path, which works fine.
> >
> > There is ongoing effort to extend slub's debug function which will
> > redzone the latter part of kmalloc object area, and when both of
> > the debug are enabled, there is possible conflict, especially when
> > the kmalloc object has small size, as caught by 0Day bot [1]
> >
> > For better information for slab/slub, add free_meta's data size
> > into 'struct kasan_cache', so that its users can take right action
> > to avoid data conflict.
> >
> > [1]. https://lore.kernel.org/lkml/YuYm3dWwpZwH58Hu@xsang-OptiPlex-9020/
> > Reported-by: kernel test robot <oliver.sang@intel.com>
> > Signed-off-by: Feng Tang <feng.tang@intel.com>
> > Acked-by: Dmitry Vyukov <dvyukov@google.com>
> > ---
> >  include/linux/kasan.h | 2 ++
> >  mm/kasan/common.c     | 2 ++
> >  2 files changed, 4 insertions(+)
> >
> > diff --git a/include/linux/kasan.h b/include/linux/kasan.h
> > index b092277bf48d..293bdaa0ba09 100644
> > --- a/include/linux/kasan.h
> > +++ b/include/linux/kasan.h
> > @@ -100,6 +100,8 @@ static inline bool kasan_has_integrated_init(void)
> >  struct kasan_cache {
> >         int alloc_meta_offset;
> >         int free_meta_offset;
> > +       /* size of free_meta data saved in object's data area */
> > +       int free_meta_size_in_object;
> 
> I thinks calling this field free_meta_size is clear enough. Thanks!

Yes, the name does look long. The "in_object" was added to make it
also a flag for whether the free meta is saved inside object's data
area. 

For 'free_meta_size', the code logic in slub should be:
  
  if (info->free_meta_offset == 0 &&
	info->free_meta_size >= ...)

Thanks,
Feng